Skip to content

Commit 4bb857d

Browse files
fix(build): increase release-please search depths to prevent 250-commit window issue (#342)
## Description Configure release-please search depths to prevent version detection failures when the latest release tag is beyond the default commit scanning window. This addresses a known limitation ([googleapis/release-please#2267](googleapis/release-please#2267)) where release-please fails to find tags older than ~250 commits, causing it to reprocess the entire commit history and incorrectly detect already-released breaking changes. - Added `release-search-depth: 800` at root level to increase release pagination depth - Added `commit-search-depth: 1000` at root level to increase commit scanning depth - Added `include-component-in-tag: true` to explicitly match the existing tag format (`hve-core-vX.Y.Z`) ## Related Issue(s) Related to [googleapis/release-please#2267](googleapis/release-please#2267) ## Type of Change Select all that apply: **Code & Documentation:** - [x] Bug fix (non-breaking change fixing an issue) - [ ] New feature (non-breaking change adding functionality) - [ ] Breaking change (fix or feature causing existing functionality to change) - [ ] Documentation update **Infrastructure & Configuration:** - [ ] GitHub Actions workflow - [ ] Linting configuration (markdown, PowerShell, etc.) - [ ] Security configuration - [ ] DevContainer configuration - [ ] Dependency update **AI Artifacts:** - [ ] Reviewed contribution with `prompt-builder` agent and addressed all feedback - [ ] Copilot instructions (`.github/instructions/*.instructions.md`) - [ ] Copilot prompt (`.github/prompts/*.prompt.md`) - [ ] Copilot agent (`.github/agents/*.agent.md`) > **Note for AI Artifact Contributors**: > > - **Agents**: Research, indexing/referencing other project (using standard VS Code GitHub Copilot/MCP tools), planning, and general implementation agents likely already exist. Review `.github/agents/` before creating new ones. > - **Model Versions**: Only contributions targeting the **latest Anthropic and OpenAI models** will be accepted. Older model versions (e.g., GPT-3.5, Claude 3) will be rejected. > - See [Agents Not Accepted](../docs/contributing/custom-agents.md#agents-not-accepted) and [Model Version Requirements](../docs/contributing/ai-artifacts-common.md#model-version-requirements). **Other:** - [ ] Script/automation (`.ps1`, `.sh`, `.py`) - [ ] Other (please describe): ## Sample Prompts (for AI Artifact Contributions) N/A - This is a configuration fix, not an AI artifact contribution. ## Testing - Validated JSON syntax using `node -e "require('./release-please-config.json')"` - Verified configuration matches the release-please JSON schema (no IDE validation errors) - Expected behavior: Next release-please run will correctly detect the v2.0.1 tag regardless of commit distance ## Checklist ### Required Checks - [x] Documentation is updated (if applicable) - [x] Files follow existing naming conventions - [x] Changes are backwards compatible (if applicable) - [ ] Tests added for new functionality (if applicable) ### AI Artifact Contributions N/A ### Required Automated Checks The following validation commands must pass before merging: - [ ] Markdown linting: `npm run lint:md` - [ ] Spell checking: `npm run spell-check` - [ ] Frontmatter validation: `npm run lint:frontmatter` - [ ] Link validation: `npm run lint:md-links` - [ ] PowerShell analysis: `npm run lint:ps` ## Security Considerations - [x] This PR does not contain any sensitive or NDA information - [ ] Any new dependencies have been reviewed for security issues - [x] Security-related scripts follow the principle of least privilege ## Additional Notes This fix addresses the erroneous v3.0.0 release PR (#341) that was created immediately after publishing v2.0.1. The root cause was the 250-commit window limitation causing release-please to reprocess the entire commit history and re-detect the breaking change from PR #277 that was already released in v2.0.0. 🔧 - Generated by Copilot
1 parent 23c2b9f commit 4bb857d

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

release-please-config.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,13 @@
11
{
22
"$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json",
33
"draft": true,
4+
"release-search-depth": 800,
5+
"commit-search-depth": 1000,
46
"packages": {
57
".": {
68
"release-type": "node",
79
"package-name": "hve-core",
10+
"include-component-in-tag": true,
811
"changelog-path": "CHANGELOG.md",
912
"changelog-sections": [
1013
{"type": "feat", "section": "✨ Features", "hidden": false},

0 commit comments

Comments
 (0)