Make sure UniquePtrs get destructed after MsQuicRegistration

We were failing one of the DataTests due to the Client/Server secrets
getting destroyed before the underlying TLS structure was done with
them.

This was occuring because in QuicTestConnectAndPing, the test function
returns before the openssl TLS layer had completing registering the
server side application read key, which isn't needed for the reporting
of an established connection.  The function returned, cleaned the
secrets buffer, after which the TLS layer tried to access them, and
boom.

Thanks to @guhetier, who noted that the destruction of the
MsQuicRegistration forces shutdown of the connection, and blocks on its
completion, so if we move the declaration of the UniquePtr buffers to
before the allocation of said registration, the fact that C++ calls
destructors in reverse order ensures that the Secrets memory remains
valid until the connection is shut down.

Author: nhorman

src/test/lib/DataTest.cpp

@@ -419,6 +419,9 @@ QuicTestConnectAndPing(
     }
 #endif
 
+    UniquePtr<QUIC_TLS_SECRETS[]> ClientSecrets;
+    UniquePtr<QUIC_TLS_SECRETS[]> ServerSecrets;
+
     MsQuicRegistration Registration(NULL, QUIC_EXECUTION_PROFILE_TYPE_MAX_THROUGHPUT, true);
     TEST_TRUE(Registration.IsValid());
 
@@ -428,8 +431,6 @@ QuicTestConnectAndPing(
         //
     }
 
-    UniquePtr<QUIC_TLS_SECRETS[]> ClientSecrets;
-    UniquePtr<QUIC_TLS_SECRETS[]> ServerSecrets;
     if (ClientZeroRtt && !ServerRejectZeroRtt) {
         ClientSecrets.reset(
                 new(std::nothrow) QUIC_TLS_SECRETS[ConnectionCount]);