fix(model-apps): dashboard chart tiles emitted ChartId, which the platform rejects

Found by a live build against a real environment. A chart tile set
`parameters.ChartId`, and the platform validates dashboard FormXML against a
schema that enumerates the legal children of `<parameters>`:

  The element 'parameters' has invalid child element 'ChartId'. List of possible
  elements expected: 'ViewId, IsUserView, ... VisualizationId, ...'

So any spec with a chart tile failed the entire `dashboards` phase with a 400.
The correct name is `VisualizationId` — which `download-model-app.js` already
reads, so a dashboard could not round-trip through download -> rebuild either.
Build wrote one name and download looked for the other.

Pre-existing, not a regression from the SDK uptake: `parameters.ChartId` is on
origin/main and dates from the original plugin commit, and this branch had not
touched that function.

Why 1599 tests passed while a real build failed: `sdk-build.test.js` asserted
`chart.parameters.ChartId` — the suite had encoded the wrong wire name, so it
agreed with the bug. A mock cannot validate FormXML against the platform schema,
so the assertion now pins the NAME explicitly and also asserts that `ChartId` is
not emitted, which is the half that would have caught this.

Live-proven: the same spec that failed the dashboards phase now completes
`build complete - 16 created, 0 failed (27 steps)`, and the deployed dashboard
reads back with 3 tiles, 2 VisualizationId and 0 ChartId.

Also documents that teardown deliberately leaves the publisher behind — a
publisher can own other solutions, so deleting it is not this app's decision,
the same fail-safe reasoning that keeps an `external` web resource. It is the
one artifact that legitimately survives a clean teardown.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 42626da2-b66f-4162-acaa-b1127ef23d89

Author: akshay-viz

plugins/model-apps/AGENTS.md

@@ -923,6 +923,10 @@ node scripts/teardown-model-app.js --env <envUrl> --spec @<dir>/app-spec.json --
 
 AI features are **admin-gated** — preflight readiness with `node scripts/ai-preflight.js --env <envUrl>`.
 Prefer a scratch env; always tear down probes (`teardown-model-app.js --apply`) to leave 0 leftovers.
+Teardown needs `--allow-destructive` as well as `--apply`, and it deliberately leaves **one** thing
+behind: the **publisher**. A publisher can own other solutions in the environment, so deleting it is
+not this app's decision to make — the same fail-safe reasoning that keeps an `external` web resource.
+Expect a clean environment afterwards *except* for `<prefix>publisher`.
 
 **After modifying the plugin also:** run `claude --debug` to confirm the plugin loads, exercise the
 skill (`/genpage` or `/app-builder`), and for genpage verify Playwright browser checks

plugins/model-apps/CHANGELOG.md

@@ -129,6 +129,18 @@ and corrects a smoke-eval assertion that could never pass live.
   GitHub Copilot CLI or Claude Code host when a newer version is available.
 
 ### Fixed
+- **Dashboard chart tiles no longer fail the whole `dashboards` phase.** A chart tile emitted
+  `ChartId`, which the platform's FormXML schema rejects — it is not a legal child of
+  `<parameters>` — so the phase died with:
+
+  > The element 'parameters' has invalid child element 'ChartId'. List of possible elements
+  > expected: 'ViewId, IsUserView, … VisualizationId, …'
+
+  The correct name is `VisualizationId`, which is what `download-model-app.js` already read, so a
+  dashboard could not round-trip through download → rebuild either. Found by a live build; the
+  mock-based test had asserted the wrong name, so the suite agreed with the bug. Both are corrected,
+  and the test now also asserts that `ChartId` is *not* emitted.
+
 - **Rebuilds no longer duplicate sub-grids or skip field removals** — the plugin now
   awaits the maker SDK's asynchronous artifact surface.
 

plugins/model-apps/scripts/lib/sdk-build.js

@@ -142,8 +142,16 @@ function dashboardTileOpts(spec, tile, result) {
 function dashboardComponent(t, index) {
   const parameters = {};
   if (t.type === 'chart') {
+    // `VisualizationId`, NOT `ChartId`. The platform validates dashboard FormXML against a schema
+    // that enumerates the legal children of `<parameters>`, and `ChartId` is not one of them:
+    //   The element 'parameters' has invalid child element 'ChartId'. List of possible elements
+    //   expected: 'ViewId, IsUserView, ... VisualizationId, ...'
+    // A chart tile therefore failed the whole dashboards phase with a 400. Caught by a live build;
+    // the mock-based test had asserted the wrong name, so the suite agreed with the bug.
+    // `download-model-app.js` already reads `VisualizationId`, so this also makes a dashboard
+    // round-trip through download -> rebuild instead of losing its chart binding.
     parameters.TargetEntityType = t.targetEntity; parameters.ViewId = t.viewId;
-    parameters.ChartId = t.visualizationId; parameters.ChartGridMode = 'Chart';
+    parameters.VisualizationId = t.visualizationId; parameters.ChartGridMode = 'Chart';
   } else if (t.type === 'list') {
     parameters.TargetEntityType = t.targetEntity; parameters.ViewId = t.viewId;
     parameters.IsUserView = 'false'; parameters.ChartGridMode = 'Grid'; parameters.RecordsPerPage = '10';

plugins/model-apps/scripts/tests/sdk-build.test.js

@@ -967,7 +967,13 @@ test('dashboards: chart + list tiles resolve the created view/visualization ids'
   const chart = tileComps.find((t) => t.type === 'chart');
   assert.strictEqual(chart.parameters.TargetEntityType, 'new_ticket', 'entity derived from the view');
   assert.ok(chart.parameters.ViewId, 'view id resolved');
-  assert.ok(chart.parameters.ChartId, 'chart visualization id resolved');
+  // `VisualizationId`, NOT `ChartId`. This assertion previously named the wrong parameter, so the
+  // suite agreed with a bug that failed the whole dashboards phase on a real environment with a
+  // 400: "The element 'parameters' has invalid child element 'ChartId'". A mock cannot validate
+  // FormXML against the platform schema, so the wire NAME has to be pinned explicitly here.
+  assert.ok(chart.parameters.VisualizationId, 'chart visualization id resolved');
+  assert.strictEqual(chart.parameters.ChartId, undefined,
+    'the rejected `ChartId` spelling is not emitted (it is not a legal <parameters> child)');
   const list = tileComps.find((t) => t.type === 'list');
   assert.strictEqual(list.name, 'Recent');
   assert.ok(list.parameters.ViewId);