Fix lint errors

Author: lakshk98

cli/cmd/capture/create_test.go

@@ -39,7 +39,7 @@ type testcase struct {
 	wantErr           bool
 }
 
-func randomString(length int) string {
+func randomString(length int) string { //nolint:unparam // length is always 5 but keeping the param for readability
 	const charset = "abcdefghijklmnopqrstuvwxyz0123456789"
 	result := make([]byte, length)
 	for i := range result {
@@ -120,7 +120,7 @@ func NewClientServerPods(service, namespace string) []*corev1.Pod {
 func TestCreateJobsWithNamespace(t *testing.T) {
 	// Create a fake Kubernetes client with workload and capture namespaces
 	newKubeclient := func() *fake.Clientset {
-		objects := []runtime.Object{
+		objects := []runtime.Object{ //nolint:prealloc // slice grows dynamically with pods added below
 			NewNode("A1"),
 			NewNode("A2"),
 			NewNode("B1"),
@@ -676,6 +676,7 @@ func TestCreateCaptureCommand_AbsoluteHostPath_ShouldFail(t *testing.T) {
 	require.Contains(t, err.Error(), "OutputConfiguration.HostPath",
 		"error should reference the rejected HostPath field; got: %v", err)
 }
+
 func TestHasRemoteDestination(t *testing.T) {
 	tests := []struct {
 		name string

cli/cmd/capture/delete_test.go

@@ -35,7 +35,7 @@ type deleteTestCase struct {
 
 // newKubeclient creates a consistent fake Kubernetes client for all tests
 func newKubeclient() *fake.Clientset {
-	objects := []runtime.Object{
+	objects := []runtime.Object{ //nolint:prealloc // slice grows dynamically with pods added below
 		NewNode("A1"),
 		NewNode("A2"),
 		NewNode("B1"),

cli/cmd/capture/table_util.go

@@ -79,7 +79,8 @@ func printCaptureResult(captureJobs []batchv1.Job) {
 	for captureRef := range captureToJobs {
 		jobs := captureToJobs[captureRef]
 		captureParts := strings.Split(captureRef, "/")
-		captureNamespace, captureName := captureParts[0], captureParts[1]
+		captureNamespace := captureParts[0]
+		captureShortName := captureParts[1]
 
 		sort.SliceStable(jobs, func(i, j int) bool {
 			return jobs[i].Name < jobs[j].Name
@@ -92,7 +93,7 @@ func printCaptureResult(captureJobs []batchv1.Job) {
 				completions = fmt.Sprintf("%d/%d", job.Status.Succeeded, *job.Spec.Completions)
 			}
 			age := durationUtil.HumanDuration(time.Since(job.CreationTimestamp.Time))
-			fmt.Fprintf(w, "%s\t%s\t%s\t%s\t%s\n", captureNamespace, captureName, job.Name, completions, age)
+			fmt.Fprintf(w, "%s\t%s\t%s\t%s\t%s\n", captureNamespace, captureShortName, job.Name, completions, age)
 		}
 	}
 	w.Flush()

pkg/capture/crd_to_job.go

@@ -435,7 +435,7 @@ func (translator *CaptureToPodTranslator) renderJob(captureTargetOnNode *Capture
 		return nil, fmt.Errorf("no nodes are selected")
 	}
 
-	stringTimestamp := translator.jobTemplate.Spec.Template.ObjectMeta.Annotations[captureConstants.CaptureTimestampAnnotationKey]
+	stringTimestamp := translator.jobTemplate.Spec.Template.Annotations[captureConstants.CaptureTimestampAnnotationKey]
 	captureTimestamp, err := file.StringToTime(stringTimestamp)
 	if err != nil {
 		return nil, fmt.Errorf("failed to parse capture start timestamp: %w", err)
@@ -457,7 +457,7 @@ func (translator *CaptureToPodTranslator) renderJob(captureTargetOnNode *Capture
 			NodeHostname:   nodeName,
 			StartTimestamp: captureTimestamp,
 		}
-		job.Spec.Template.ObjectMeta.Annotations[captureConstants.CaptureFilenameAnnotationKey] = captureFilename.String()
+		job.Spec.Template.Annotations[captureConstants.CaptureFilenameAnnotationKey] = captureFilename.String()
 
 		fmt.Printf("%s.tar.gz\n", captureFilename.String())
 
@@ -1049,7 +1049,9 @@ func (translator *CaptureToPodTranslator) ObtainCaptureJobPodEnv(capture retinav
 	return translator.obtainCaptureJobPodEnv(capture, resolvedHostPath)
 }
 
-func (translator *CaptureToPodTranslator) obtainCaptureJobPodEnv(capture retinav1alpha1.Capture, resolvedHostPath string) (map[string]string, error) {
+func (translator *CaptureToPodTranslator) obtainCaptureJobPodEnv( //nolint:gocyclo // complexity is inherent to env var mapping logic
+	capture retinav1alpha1.Capture, resolvedHostPath string,
+) (map[string]string, error) {
 	jobPodEnv := map[string]string{}
 
 	captureOutputEnv, err := translator.obtainCaptureOutputEnv(capture.Spec.OutputConfiguration, resolvedHostPath)

pkg/capture/file/timestamp_test.go

@@ -17,7 +17,7 @@ func TestNow(t *testing.T) {
 	require.NotNil(t, result)
 	assert.GreaterOrEqual(t, result.Time, before)
 	assert.LessOrEqual(t, result.Time, after)
-	assert.Equal(t, 0, result.Time.Nanosecond()) // ensure timestamp is truncated
+	assert.Equal(t, 0, result.Nanosecond()) // ensure timestamp is truncated
 }
 
 func TestStringToTime(t *testing.T) {

pkg/capture/provider/network_capture_test.go

@@ -27,6 +27,7 @@ const (
 	interfaceEth0       = "eth0"
 	interfaceEth1       = "eth1"
 	interfaceAny        = "any"
+	tcpdumpBinary       = "tcpdump"
 )
 
 func TestSetupAndCleanup(t *testing.T) {
@@ -108,7 +109,7 @@ func TestTcpdumpEmptyFilter(t *testing.T) {
 
 	// Verify only expected args are present and no malicious content
 	for _, arg := range cmd.Args {
-		if arg != "tcpdump" && arg != "-w" && arg != testCaptureFilePath &&
+		if arg != tcpdumpBinary && arg != "-w" && arg != testCaptureFilePath &&
 			arg != "--relinquish-privileges=root" && arg != "-i" && arg != interfaceAny {
 			t.Errorf("Unexpected argument '%s' found in empty filter command: %v", arg, cmd.Args)
 		}
@@ -308,7 +309,7 @@ func TestTcpdumpBPFFilterOnly(t *testing.T) {
 	}
 
 	// Should have basic structure (tcpdump, -w, path, -i, etc.)
-	if !slices.Contains(cmd.Args, "tcpdump") {
+	if !slices.Contains(cmd.Args, tcpdumpBinary) {
 		t.Errorf("Expected 'tcpdump' in command args, but got: %v", cmd.Args)
 	}
 	if !slices.Contains(cmd.Args, "-w") {
@@ -319,7 +320,7 @@ func TestTcpdumpBPFFilterOnly(t *testing.T) {
 	for _, arg := range cmd.Args {
 		// Skip our internal flags and the BPF filter
 		if arg == "-w" || arg == "-i" || arg == "-s" || arg == "--relinquish-privileges=root" ||
-			arg == testCaptureFilePath || arg == "tcpdump" || arg == "any" || arg == bpfFilter {
+			arg == testCaptureFilePath || arg == tcpdumpBinary || arg == "any" || arg == bpfFilter {
 			continue
 		}
 		// Any other argument starting with '-' is suspicious
@@ -737,7 +738,7 @@ func TestTcpdumpCommandBaseArgs(t *testing.T) {
 	cmd := constructTcpdumpCommand(testCaptureFilePath, "")
 
 	// Verify base args are always present
-	if cmd.Args[0] != "tcpdump" {
+	if cmd.Args[0] != tcpdumpBinary {
 		t.Errorf("Expected first arg to be 'tcpdump', got %s", cmd.Args[0])
 	}
 	if !hasArgPair(cmd, "-w", testCaptureFilePath) {

pkg/capture/provider/network_capture_unix.go

@@ -59,7 +59,7 @@ func constructTcpdumpCommand(captureFilePath, bpfFilter string) *exec.Cmd {
 	// tcpdump: Couldn't find user 'tcpdump'
 	// To disable this behavior, we use `--relinquish-privileges=root` same as `-Z root`.
 	// ref: https://manpages.debian.org/bullseye/tcpdump/tcpdump.8.en.html#Z
-	captureStartCmd := exec.Command(
+	captureStartCmd := exec.Command( //nolint:noctx // tcpdump is managed via process signals, not context cancellation
 		"tcpdump",
 		"-w", captureFilePath,
 		"--relinquish-privileges=root",

pkg/config/config.go

@@ -56,10 +56,10 @@ var (
 		"telemetryInterval smaller than %v is not allowed",
 		MinTelemetryInterval,
 	)
-	DefaultTelemetryInterval          = 15 * time.Minute
-	DefaultSamplingRate        uint32 = 1
-	DefaultFilterMapMaxEntries uint32 = 255
-	DefaultConntrackReportInterval    = 30 * time.Second
+	DefaultTelemetryInterval              = 15 * time.Minute
+	DefaultSamplingRate            uint32 = 1
+	DefaultFilterMapMaxEntries     uint32 = 255
+	DefaultConntrackReportInterval        = 30 * time.Second
 )
 
 func (l *Level) UnmarshalText(text []byte) error {

pkg/controllers/daemon/node/controller.go

@@ -76,13 +76,13 @@ func (r *NodeReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.
 	}
 
 	if len(node.Status.Addresses) == 0 {
-		r.l.Warn("Node has no addresses", zap.String("Node", req.NamespacedName.String()))
+		r.l.Warn("Node has no addresses", zap.String("Node", req.Name))
 		return ctrl.Result{}, nil
 	}
 
 	retinaNodeCommon := retinaCommon.NewRetinaNode(node.Name, net.ParseIP(node.Status.Addresses[0].Address), node.Labels[corev1.LabelTopologyZone])
 	if err := r.cache.UpdateRetinaNode(retinaNodeCommon); err != nil {
-		r.l.Error("Failed to update RetinaNode in Cache", zap.Error(err), zap.String("Node", req.NamespacedName.String()))
+		r.l.Error("Failed to update RetinaNode in Cache", zap.Error(err), zap.String("Node", req.String()))
 		return ctrl.Result{}, err
 	}
 

pkg/enricher/enricher_test.go

@@ -25,6 +25,8 @@ import (
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 )
 
+const logLevelDebug = "debug"
+
 var (
 	// number of events
 	eventsGeneratedCount = 5
@@ -90,7 +92,7 @@ func writeEventToEnricher(t *testing.T, e *Enricher, ev *v1.Event) {
 
 func TestEnricher(t *testing.T) {
 	opts := log.GetDefaultLogOpts()
-	opts.Level = "debug"
+	opts.Level = logLevelDebug
 	_, err := log.SetupZapLogger(opts)
 	require.NoError(t, err)
 
@@ -145,7 +147,7 @@ func TestEnricherSecondaryIPs(t *testing.T) {
 	expectedOutputCount := 18
 
 	opts := log.GetDefaultLogOpts()
-	opts.Level = "debug"
+	opts.Level = logLevelDebug
 	log.SetupZapLogger(opts)
 	l := log.Logger().Named("test-enricher")
 
@@ -245,7 +247,7 @@ func assertEqualEndpoint(t *testing.T, expected *common.RetinaEndpoint, actual *
 
 func TestEnricherZoneResolution(t *testing.T) {
 	opts := log.GetDefaultLogOpts()
-	opts.Level = "debug"
+	opts.Level = logLevelDebug
 	_, err := log.SetupZapLogger(opts)
 	require.NoError(t, err)
 
@@ -310,7 +312,7 @@ func TestEnricherZoneResolution(t *testing.T) {
 
 func TestEnricherZoneResolution_NoNode(t *testing.T) {
 	opts := log.GetDefaultLogOpts()
-	opts.Level = "debug"
+	opts.Level = logLevelDebug
 	_, err := log.SetupZapLogger(opts)
 	require.NoError(t, err)