Skip to content

Viewer incorrectly assumes byteOffset implies a binary file #616

Description

@awscullinan

clippy-sarif, for example, produces regions for source files than have both text and binary regions, like this:

                "region": {
                  "byteLength": 34,
                  "byteOffset": 411,
                  "endColumn": 61,
                  "endLine": 14,
                  "startColumn": 27,
                  "startLine": 14
                }

The viewer assumes that this means the file is a binary, and puts the selection in the wrong place

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions