Skip to content

Commit 4855cbf

Browse files
committed
Address review comments
1 parent 9bfbb38 commit 4855cbf

File tree

5 files changed

+5
-4
lines changed

5 files changed

+5
-4
lines changed

dotnet/src/VectorData/SqliteVec/SqlitePropertyMapping.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ public static List<SqliteColumn> GetColumns(IReadOnlyList<IPropertyModel> proper
6262
else
6363
{
6464
// The Key column in included in both Vector and Data tables.
65-
Debug.Assert(property is IKeyPropertyModel, "property is VectorStoreRecordIKeyPropertyModel");
65+
Debug.Assert(property is IKeyPropertyModel, "property is not an IKeyPropertyModel");
6666

6767
propertyType = GetStorageDataPropertyType(property);
6868
isPrimary = true;

dotnet/src/VectorData/VectorData.Abstractions/ProviderServices/IPropertyModel.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ public interface IPropertyModel
4646
/// <summary>
4747
/// Gets a dictionary of provider-specific annotations for this property.
4848
/// </summary>
49-
Dictionary<string, object?>? ProviderAnnotations { get; }
49+
IReadOnlyDictionary<string, object?>? ProviderAnnotations { get; }
5050

5151
/// <summary>
5252
/// Reads the property from the given <paramref name="record"/>, returning the value as an <see cref="object"/>.

dotnet/src/VectorData/VectorData.Abstractions/ProviderServices/KeyPropertyModel.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ public class KeyPropertyModel(string modelName, Type type) : PropertyModel(model
2323
/// (e.g. CosmosDB NoSQL uses "id"): the serializer produces a JSON object with the policy-transformed name, and
2424
/// the connector needs to find and replace it with the reserved storage name.
2525
/// </summary>
26-
[Experimental("MEVD9001")]
2726
public string? SerializedKeyName { get; set; }
2827

2928
/// <inheritdoc/>

dotnet/src/VectorData/VectorData.Abstractions/ProviderServices/PropertyModel.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,8 @@ public string StorageName
5555
/// </remarks>
5656
public Dictionary<string, object?>? ProviderAnnotations { get; set; }
5757

58+
IReadOnlyDictionary<string, object?>? IPropertyModel.ProviderAnnotations => this.ProviderAnnotations;
59+
5860
/// <summary>
5961
/// Gets whether the property type is nullable. For value types, this is <see langword="true"/> when the type is
6062
/// <see cref="Nullable{T}"/>. For reference types on .NET 6+, this uses NRT annotations via

dotnet/test/VectorData/VectorData.UnitTests/PropertyModelTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
namespace VectorData.UnitTests;
88

9-
public class IPropertyModelTests
9+
public class PropertyModelTests
1010
{
1111
#region Value type nullability
1212

0 commit comments

Comments
 (0)