Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes perspective-based semantic model deployment by updating TOM perspective utilities and reworking _reduce_model to derive included objects directly from TOM perspectives (instead of relying on an undefined dfP).
Changes:
- Refactors perspective/translation object-type validation into shared helper methods.
- Enhances
add_to_perspective/remove_from_perspectiveto be idempotent and ensure parent tables exist for non-table objects. - Reworks
_reduce_modelto gather tables/columns/measures/hierarchies from the perspective and track added dependency objects.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bo-zhou-ms
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1140