Transferred: Extension causes high cpu load

[pwang347]

Original issue with cpuprofile: microsoft/vscode-data-wrangler#334

• Issue Type: Performance
• Extension Name: datawrangler
• Extension Version: 1.12.0
• OS Version: Windows_NT x64 10.0.22631
• VS Code version: 1.94.2

⚠️ Make sure to attach this file from your home-directory:
⚠️file:///c%3A/Users/spw/AppData/Local/Temp/ms-toolsai.datawrangler-unresponsive.cpuprofile.txt

Find more details here: https://github.com/microsoft/vscode/wiki/Explain-extension-causes-high-cpu-load

--

Transferring since these calls seem to be from the tas-client.

[lramos15]

I was just reviewing this repo and came across this issue. This is due to their network / firewall blocking the request and causing a long timeout.

We had a similar issue in Copilot Chat and decided to move the tas client fetch off the hot path. We could add a fetch timeout here but calling fetch over and over would still lead to the timeout being hit every time.

cc @sbatten for any other ideas

[sbatten]

This is caused by the extension, no?

[pwang347]

@sbatten to my knowledge the experimentation service implementation here is extremely simple; it's only initialized and is never touched again since it's only used for the built-in boolean value assignments. So don't think the extension is doing anything weird here (I can share the implementation with you if you'd like).

[lramos15]

@sbatten What do you mean?

[sbatten]

I mean should we do anything here? Or should we say the extension should not put this on the hot path?

[lramos15]

I mean should we do anything here? Or should we say the extension should not put this on the hot path?

The fact that the module doesn't time out like ever seems a bit rough, the module if we wanted could be smarter about detecting blocked networks

[sbatten]

Makes sense.