Replace hardcoded gen_ai string constants with OTel semantic-conventions library imports

- genAiAttributes.ts: Import ATTR_GEN_AI_* from @opentelemetry/semantic-conventions/incubating
  and ATTR_ERROR_TYPE/ATTR_SERVER_* from @opentelemetry/semantic-conventions stable.
  Replace all hardcoded gen_ai.* strings in GenAiAttr, GenAiOperationName, GenAiProviderName,
  GenAiTokenType, and StdAttr with OTel library constants. Keep custom attributes
  (cache, reasoning, agent.version) that are not yet standardized.
- genAiEvents.ts: Use ATTR_EVENT_NAME and EVENT_GEN_AI_CLIENT_INFERENCE_OPERATION_DETAILS
  from OTel library instead of hardcoded strings.
- genAiMetrics.ts: Use METRIC_GEN_AI_CLIENT_OPERATION_DURATION and
  METRIC_GEN_AI_CLIENT_TOKEN_USAGE from OTel library.
- otelChatDebugLogProvider.ts: Replace hardcoded gen_ai.* attribute strings
  with GenAiAttr/GenAiOperationName/CopilotChatAttr constants.

Agent-Logs-Url: https://github.com/microsoft/vscode-copilot-chat/sessions/aaf7dc17-ec13-4d9a-8507-4acb95edbcbd

Co-authored-by: zhichli <57812115+zhichli@users.noreply.github.com>

Author: Copilot

src/extension/trajectory/vscode-node/otelChatDebugLogProvider.ts

@@ -6,6 +6,7 @@
 import * as vscode from 'vscode';
 import { ConfigKey, IConfigurationService } from '../../../platform/configuration/common/configurationService';
 import { ILogService } from '../../../platform/log/common/logService';
+import { CopilotChatAttr, GenAiAttr, GenAiOperationName } from '../../../platform/otel/common/genAiAttributes';
 import { IOTelService, type ICompletedSpanData, type ISpanEventData } from '../../../platform/otel/common/otelService';
 import { decodeSessionId } from '../../../platform/otel/common/sessionUtils';
 import { IExperimentationService } from '../../../platform/telemetry/common/nullExperimentationService';
@@ -41,32 +42,32 @@ function coreEventToSpan(event: vscode.ChatDebugEvent, traceId: string): IComple
 	};
 
 	if (event instanceof vscode.ChatDebugGenericEvent) {
-		attributes['gen_ai.operation.name'] = 'core_event';
-		attributes['copilot_chat.debug_name'] = event.name;
+		attributes[GenAiAttr.OPERATION_NAME] = 'core_event';
+		attributes[CopilotChatAttr.DEBUG_NAME] = event.name;
 		if (event.details) { attributes['copilot_chat.event_details'] = event.details; }
 		if (event.category) { attributes['copilot_chat.event_category'] = event.category; }
 		attributes['copilot_chat.log_level'] = event.level;
 	} else if (event instanceof vscode.ChatDebugToolCallEvent) {
-		attributes['gen_ai.operation.name'] = 'execute_tool';
-		attributes['gen_ai.tool.name'] = event.toolName;
-		if (event.input) { attributes['gen_ai.tool.call.arguments'] = event.input; }
-		if (event.output) { attributes['gen_ai.tool.call.result'] = event.output; }
+		attributes[GenAiAttr.OPERATION_NAME] = GenAiOperationName.EXECUTE_TOOL;
+		attributes[GenAiAttr.TOOL_NAME] = event.toolName;
+		if (event.input) { attributes[GenAiAttr.TOOL_CALL_ARGUMENTS] = event.input; }
+		if (event.output) { attributes[GenAiAttr.TOOL_CALL_RESULT] = event.output; }
 	} else if (event instanceof vscode.ChatDebugModelTurnEvent) {
-		attributes['gen_ai.operation.name'] = 'chat';
-		if (event.model) { attributes['gen_ai.request.model'] = event.model; }
-		if (event.inputTokens !== undefined) { attributes['gen_ai.usage.input_tokens'] = event.inputTokens; }
-		if (event.outputTokens !== undefined) { attributes['gen_ai.usage.output_tokens'] = event.outputTokens; }
+		attributes[GenAiAttr.OPERATION_NAME] = GenAiOperationName.CHAT;
+		if (event.model) { attributes[GenAiAttr.REQUEST_MODEL] = event.model; }
+		if (event.inputTokens !== undefined) { attributes[GenAiAttr.USAGE_INPUT_TOKENS] = event.inputTokens; }
+		if (event.outputTokens !== undefined) { attributes[GenAiAttr.USAGE_OUTPUT_TOKENS] = event.outputTokens; }
 	} else {
 		// Unknown event type — store as generic
-		attributes['gen_ai.operation.name'] = 'core_event';
+		attributes[GenAiAttr.OPERATION_NAME] = 'core_event';
 	}
 
 	// Preserve the event ID and parent for hierarchy
 	const eventId = 'id' in event ? (event as { id?: string }).id : undefined;
 	const parentEventId = 'parentEventId' in event ? (event as { parentEventId?: string }).parentEventId : undefined;
 
 	return {
-		name: attributes['copilot_chat.debug_name'] as string ?? 'core-event',
+		name: attributes[CopilotChatAttr.DEBUG_NAME] as string ?? 'core-event',
 		spanId: eventId ?? id,
 		traceId,
 		parentSpanId: parentEventId,

src/platform/otel/common/genAiAttributes.ts

@@ -3,12 +3,60 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
+import {
+	ATTR_GEN_AI_AGENT_DESCRIPTION,
+	ATTR_GEN_AI_AGENT_ID,
+	ATTR_GEN_AI_AGENT_NAME,
+	ATTR_GEN_AI_CONVERSATION_ID,
+	ATTR_GEN_AI_INPUT_MESSAGES,
+	ATTR_GEN_AI_OPERATION_NAME,
+	ATTR_GEN_AI_OUTPUT_MESSAGES,
+	ATTR_GEN_AI_OUTPUT_TYPE,
+	ATTR_GEN_AI_PROVIDER_NAME,
+	ATTR_GEN_AI_REQUEST_FREQUENCY_PENALTY,
+	ATTR_GEN_AI_REQUEST_MAX_TOKENS,
+	ATTR_GEN_AI_REQUEST_MODEL,
+	ATTR_GEN_AI_REQUEST_PRESENCE_PENALTY,
+	ATTR_GEN_AI_REQUEST_SEED,
+	ATTR_GEN_AI_REQUEST_STOP_SEQUENCES,
+	ATTR_GEN_AI_REQUEST_TEMPERATURE,
+	ATTR_GEN_AI_REQUEST_TOP_P,
+	ATTR_GEN_AI_RESPONSE_FINISH_REASONS,
+	ATTR_GEN_AI_RESPONSE_ID,
+	ATTR_GEN_AI_RESPONSE_MODEL,
+	ATTR_GEN_AI_SYSTEM_INSTRUCTIONS,
+	ATTR_GEN_AI_TOKEN_TYPE,
+	ATTR_GEN_AI_TOOL_CALL_ARGUMENTS,
+	ATTR_GEN_AI_TOOL_CALL_ID,
+	ATTR_GEN_AI_TOOL_CALL_RESULT,
+	ATTR_GEN_AI_TOOL_DEFINITIONS,
+	ATTR_GEN_AI_TOOL_DESCRIPTION,
+	ATTR_GEN_AI_TOOL_NAME,
+	ATTR_GEN_AI_TOOL_TYPE,
+	ATTR_GEN_AI_USAGE_INPUT_TOKENS,
+	ATTR_GEN_AI_USAGE_OUTPUT_TOKENS,
+	GEN_AI_OPERATION_NAME_VALUE_CHAT,
+	GEN_AI_OPERATION_NAME_VALUE_EMBEDDINGS,
+	GEN_AI_OPERATION_NAME_VALUE_EXECUTE_TOOL,
+	GEN_AI_OPERATION_NAME_VALUE_INVOKE_AGENT,
+	GEN_AI_PROVIDER_NAME_VALUE_ANTHROPIC,
+	GEN_AI_PROVIDER_NAME_VALUE_AZURE_AI_OPENAI,
+	GEN_AI_PROVIDER_NAME_VALUE_OPENAI,
+	GEN_AI_TOKEN_TYPE_VALUE_INPUT,
+	GEN_AI_TOKEN_TYPE_VALUE_OUTPUT,
+} from '@opentelemetry/semantic-conventions/incubating';
+import {
+	ATTR_ERROR_TYPE,
+	ATTR_SERVER_ADDRESS,
+	ATTR_SERVER_PORT,
+} from '@opentelemetry/semantic-conventions';
+
 // gen_ai.operation.name values
 export const GenAiOperationName = {
-	CHAT: 'chat',
-	INVOKE_AGENT: 'invoke_agent',
-	EXECUTE_TOOL: 'execute_tool',
-	EMBEDDINGS: 'embeddings',
+	CHAT: GEN_AI_OPERATION_NAME_VALUE_CHAT,
+	INVOKE_AGENT: GEN_AI_OPERATION_NAME_VALUE_INVOKE_AGENT,
+	EXECUTE_TOOL: GEN_AI_OPERATION_NAME_VALUE_EXECUTE_TOOL,
+	EMBEDDINGS: GEN_AI_OPERATION_NAME_VALUE_EMBEDDINGS,
 	/** Extension-specific: standalone markdown content event */
 	CONTENT_EVENT: 'content_event',
 	/** Extension-specific: hook command execution */
@@ -17,82 +65,88 @@ export const GenAiOperationName = {
 
 // gen_ai.provider.name values
 export const GenAiProviderName = {
+	/** Extension-specific: GitHub as a provider */
 	GITHUB: 'github',
-	OPENAI: 'openai',
-	ANTHROPIC: 'anthropic',
-	AZURE_AI_OPENAI: 'azure.ai.openai',
+	OPENAI: GEN_AI_PROVIDER_NAME_VALUE_OPENAI,
+	ANTHROPIC: GEN_AI_PROVIDER_NAME_VALUE_ANTHROPIC,
+	AZURE_AI_OPENAI: GEN_AI_PROVIDER_NAME_VALUE_AZURE_AI_OPENAI,
 } as const;
 
 // gen_ai.token.type values
 export const GenAiTokenType = {
-	INPUT: 'input',
-	OUTPUT: 'output',
+	INPUT: GEN_AI_TOKEN_TYPE_VALUE_INPUT,
+	OUTPUT: GEN_AI_TOKEN_TYPE_VALUE_OUTPUT,
 } as const;
 
 // gen_ai.tool.type values
 export const GenAiToolType = {
 	FUNCTION: 'function',
+	/** Extension-specific: VS Code extension tool */
 	EXTENSION: 'extension',
 } as const;
 
 /**
  * OTel GenAI semantic convention attribute keys.
+ * Uses constants from `@opentelemetry/semantic-conventions/incubating` where available.
  * @see https://github.com/open-telemetry/semantic-conventions/blob/main/docs/gen-ai/gen-ai-spans.md
  */
 export const GenAiAttr = {
 	// Core
-	OPERATION_NAME: 'gen_ai.operation.name',
-	PROVIDER_NAME: 'gen_ai.provider.name',
+	OPERATION_NAME: ATTR_GEN_AI_OPERATION_NAME,
+	PROVIDER_NAME: ATTR_GEN_AI_PROVIDER_NAME,
 
 	// Request
-	REQUEST_MODEL: 'gen_ai.request.model',
-	REQUEST_TEMPERATURE: 'gen_ai.request.temperature',
-	REQUEST_MAX_TOKENS: 'gen_ai.request.max_tokens',
-	REQUEST_TOP_P: 'gen_ai.request.top_p',
-	REQUEST_FREQUENCY_PENALTY: 'gen_ai.request.frequency_penalty',
-	REQUEST_PRESENCE_PENALTY: 'gen_ai.request.presence_penalty',
-	REQUEST_SEED: 'gen_ai.request.seed',
-	REQUEST_STOP_SEQUENCES: 'gen_ai.request.stop_sequences',
+	REQUEST_MODEL: ATTR_GEN_AI_REQUEST_MODEL,
+	REQUEST_TEMPERATURE: ATTR_GEN_AI_REQUEST_TEMPERATURE,
+	REQUEST_MAX_TOKENS: ATTR_GEN_AI_REQUEST_MAX_TOKENS,
+	REQUEST_TOP_P: ATTR_GEN_AI_REQUEST_TOP_P,
+	REQUEST_FREQUENCY_PENALTY: ATTR_GEN_AI_REQUEST_FREQUENCY_PENALTY,
+	REQUEST_PRESENCE_PENALTY: ATTR_GEN_AI_REQUEST_PRESENCE_PENALTY,
+	REQUEST_SEED: ATTR_GEN_AI_REQUEST_SEED,
+	REQUEST_STOP_SEQUENCES: ATTR_GEN_AI_REQUEST_STOP_SEQUENCES,
 
 	// Response
-	RESPONSE_MODEL: 'gen_ai.response.model',
-	RESPONSE_ID: 'gen_ai.response.id',
-	RESPONSE_FINISH_REASONS: 'gen_ai.response.finish_reasons',
+	RESPONSE_MODEL: ATTR_GEN_AI_RESPONSE_MODEL,
+	RESPONSE_ID: ATTR_GEN_AI_RESPONSE_ID,
+	RESPONSE_FINISH_REASONS: ATTR_GEN_AI_RESPONSE_FINISH_REASONS,
 
 	// Usage
-	USAGE_INPUT_TOKENS: 'gen_ai.usage.input_tokens',
-	USAGE_OUTPUT_TOKENS: 'gen_ai.usage.output_tokens',
+	USAGE_INPUT_TOKENS: ATTR_GEN_AI_USAGE_INPUT_TOKENS,
+	USAGE_OUTPUT_TOKENS: ATTR_GEN_AI_USAGE_OUTPUT_TOKENS,
+	/** Custom: not yet standardized in OTel GenAI conventions */
 	USAGE_CACHE_READ_INPUT_TOKENS: 'gen_ai.usage.cache_read.input_tokens',
+	/** Custom: not yet standardized in OTel GenAI conventions */
 	USAGE_CACHE_CREATION_INPUT_TOKENS: 'gen_ai.usage.cache_creation.input_tokens',
 	/** Custom: reasoning/thinking token count (not yet standardized in GenAI conventions) */
 	USAGE_REASONING_TOKENS: 'gen_ai.usage.reasoning_tokens',
 
 	// Conversation
-	CONVERSATION_ID: 'gen_ai.conversation.id',
-	OUTPUT_TYPE: 'gen_ai.output.type',
+	CONVERSATION_ID: ATTR_GEN_AI_CONVERSATION_ID,
+	OUTPUT_TYPE: ATTR_GEN_AI_OUTPUT_TYPE,
 
 	// Token type (for metrics)
-	TOKEN_TYPE: 'gen_ai.token.type',
+	TOKEN_TYPE: ATTR_GEN_AI_TOKEN_TYPE,
 
 	// Agent
-	AGENT_NAME: 'gen_ai.agent.name',
-	AGENT_ID: 'gen_ai.agent.id',
+	AGENT_NAME: ATTR_GEN_AI_AGENT_NAME,
+	AGENT_ID: ATTR_GEN_AI_AGENT_ID,
+	/** Custom: not yet standardized in OTel GenAI conventions */
 	AGENT_VERSION: 'gen_ai.agent.version',
-	AGENT_DESCRIPTION: 'gen_ai.agent.description',
+	AGENT_DESCRIPTION: ATTR_GEN_AI_AGENT_DESCRIPTION,
 
 	// Tool
-	TOOL_NAME: 'gen_ai.tool.name',
-	TOOL_TYPE: 'gen_ai.tool.type',
-	TOOL_CALL_ID: 'gen_ai.tool.call.id',
-	TOOL_DESCRIPTION: 'gen_ai.tool.description',
-	TOOL_CALL_ARGUMENTS: 'gen_ai.tool.call.arguments',
-	TOOL_CALL_RESULT: 'gen_ai.tool.call.result',
+	TOOL_NAME: ATTR_GEN_AI_TOOL_NAME,
+	TOOL_TYPE: ATTR_GEN_AI_TOOL_TYPE,
+	TOOL_CALL_ID: ATTR_GEN_AI_TOOL_CALL_ID,
+	TOOL_DESCRIPTION: ATTR_GEN_AI_TOOL_DESCRIPTION,
+	TOOL_CALL_ARGUMENTS: ATTR_GEN_AI_TOOL_CALL_ARGUMENTS,
+	TOOL_CALL_RESULT: ATTR_GEN_AI_TOOL_CALL_RESULT,
 
 	// Content (opt-in)
-	INPUT_MESSAGES: 'gen_ai.input.messages',
-	OUTPUT_MESSAGES: 'gen_ai.output.messages',
-	SYSTEM_INSTRUCTIONS: 'gen_ai.system_instructions',
-	TOOL_DEFINITIONS: 'gen_ai.tool.definitions',
+	INPUT_MESSAGES: ATTR_GEN_AI_INPUT_MESSAGES,
+	OUTPUT_MESSAGES: ATTR_GEN_AI_OUTPUT_MESSAGES,
+	SYSTEM_INSTRUCTIONS: ATTR_GEN_AI_SYSTEM_INSTRUCTIONS,
+	TOOL_DEFINITIONS: ATTR_GEN_AI_TOOL_DEFINITIONS,
 } as const;
 
 /**
@@ -133,9 +187,10 @@ export const CopilotChatAttr = {
 
 /**
  * Standard OTel attributes used alongside GenAI attributes.
+ * Uses constants from `@opentelemetry/semantic-conventions`.
  */
 export const StdAttr = {
-	ERROR_TYPE: 'error.type',
-	SERVER_ADDRESS: 'server.address',
-	SERVER_PORT: 'server.port',
+	ERROR_TYPE: ATTR_ERROR_TYPE,
+	SERVER_ADDRESS: ATTR_SERVER_ADDRESS,
+	SERVER_PORT: ATTR_SERVER_PORT,
 } as const;

src/platform/otel/common/genAiEvents.ts

@@ -3,6 +3,7 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
+import { ATTR_EVENT_NAME, EVENT_GEN_AI_CLIENT_INFERENCE_OPERATION_DETAILS } from '@opentelemetry/semantic-conventions/incubating';
 import { GenAiAttr, GenAiOperationName, StdAttr } from './genAiAttributes';
 import { truncateForOTel } from './messageFormatters';
 import type { IOTelService } from './otelService';
@@ -30,7 +31,7 @@ export function emitInferenceDetailsEvent(
 	error?: { type: string; message: string },
 ): void {
 	const attributes: Record<string, unknown> = {
-		'event.name': 'gen_ai.client.inference.operation.details',
+		[ATTR_EVENT_NAME]: EVENT_GEN_AI_CLIENT_INFERENCE_OPERATION_DETAILS,
 		[GenAiAttr.OPERATION_NAME]: GenAiOperationName.CHAT,
 		[GenAiAttr.REQUEST_MODEL]: request.model,
 	};

src/platform/otel/common/genAiMetrics.ts

@@ -3,6 +3,7 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
+import { METRIC_GEN_AI_CLIENT_OPERATION_DURATION, METRIC_GEN_AI_CLIENT_TOKEN_USAGE } from '@opentelemetry/semantic-conventions/incubating';
 import { GenAiAttr, StdAttr } from './genAiAttributes';
 import type { IOTelService } from './otelService';
 
@@ -27,7 +28,7 @@ export class GenAiMetrics {
 			errorType?: string;
 		},
 	): void {
-		otel.recordMetric('gen_ai.client.operation.duration', durationSec, {
+		otel.recordMetric(METRIC_GEN_AI_CLIENT_OPERATION_DURATION, durationSec, {
 			[GenAiAttr.OPERATION_NAME]: attrs.operationName,
 			[GenAiAttr.PROVIDER_NAME]: attrs.providerName,
 			[GenAiAttr.REQUEST_MODEL]: attrs.requestModel,
@@ -50,7 +51,7 @@ export class GenAiMetrics {
 			serverAddress?: string;
 		},
 	): void {
-		otel.recordMetric('gen_ai.client.token.usage', tokenCount, {
+		otel.recordMetric(METRIC_GEN_AI_CLIENT_TOKEN_USAGE, tokenCount, {
 			[GenAiAttr.OPERATION_NAME]: attrs.operationName,
 			[GenAiAttr.PROVIDER_NAME]: attrs.providerName,
 			[GenAiAttr.TOKEN_TYPE]: tokenType,