Skip to content

Commit c3d3f8d

Browse files
jrualesCopilot
andauthored
Make simpleBrowser.useIntegratedBrowser true by default (#296775)
* Update default value for useIntegratedBrowser setting Changed default value of useIntegratedBrowser to true. * Address feedback on default setting for `simpleBrowser.useIntegratedBrowser` (#296776) * Initial plan * Change default fallback for useIntegratedBrowserSetting from false to true Co-authored-by: jruales <1588988+jruales@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jruales <1588988+jruales@users.noreply.github.com> * Remove "experimental" label from simpleBrowser.useIntegratedBrowser setting description (#296777) * Initial plan * Remove 'experimental' from useIntegratedBrowser setting description Co-authored-by: jruales <1588988+jruales@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jruales <1588988+jruales@users.noreply.github.com> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
1 parent ec33e9d commit c3d3f8d

File tree

3 files changed

+4
-8
lines changed

3 files changed

+4
-8
lines changed

extensions/simple-browser/package.json

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -54,13 +54,9 @@
5454
},
5555
"simpleBrowser.useIntegratedBrowser": {
5656
"type": "boolean",
57-
"default": false,
57+
"default": true,
5858
"markdownDescription": "%configuration.useIntegratedBrowser.description%",
59-
"scope": "application",
60-
"tags": [
61-
"experimental",
62-
"onExP"
63-
]
59+
"scope": "application"
6460
}
6561
}
6662
}

extensions/simple-browser/package.nls.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@
22
"displayName": "Simple Browser",
33
"description": "A very basic built-in webview for displaying web content.",
44
"configuration.focusLockIndicator.enabled.description": "Enable/disable the floating indicator that shows when focused in the simple browser.",
5-
"configuration.useIntegratedBrowser.description": "When enabled, the `simpleBrowser.show` command will open URLs in the integrated browser instead of the Simple Browser webview. **Note:** This setting is experimental and only available on desktop."
5+
"configuration.useIntegratedBrowser.description": "When enabled, the `simpleBrowser.show` command will open URLs in the integrated browser instead of the Simple Browser webview. **Note:** This setting is only available on desktop."
66
}

extensions/simple-browser/src/extension.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ const openerId = 'simpleBrowser.open';
3838
*/
3939
async function shouldUseIntegratedBrowser(): Promise<boolean> {
4040
const config = vscode.workspace.getConfiguration();
41-
if (!config.get<boolean>(useIntegratedBrowserSetting, false)) {
41+
if (!config.get<boolean>(useIntegratedBrowserSetting, true)) {
4242
return false;
4343
}
4444

0 commit comments

Comments
 (0)