Commit d012d19
committed
Address CodeRabbit review: harden CI token handling, fail loud on no tests
- Set persist-credentials: false and scope the workflow token to
contents: read, since this job runs pull_request-triggered installs
and tests from potentially untrusted forks (flagged by zizmor;
matches the permissions: block already used in black.yml).
- Drop --passWithNoTests so a broken test-discovery config fails CI
loudly instead of silently reporting success with zero tests run —
exactly the failure mode this PR exists to prevent.
Left actions/setup-node@v3 as-is: CodeRabbit flagged it as unsupported,
but this repo's own Linting-Precommit workflow uses the same action
version and succeeded as recently as 2026-08-03, so the claim doesn't
hold for this repo's actual runners.1 parent b6c4a14 commit d012d19
1 file changed
Lines changed: 6 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
13 | 16 | | |
14 | 17 | | |
15 | 18 | | |
16 | 19 | | |
17 | 20 | | |
18 | 21 | | |
19 | 22 | | |
| 23 | + | |
| 24 | + | |
20 | 25 | | |
21 | 26 | | |
22 | 27 | | |
| |||
28 | 33 | | |
29 | 34 | | |
30 | 35 | | |
31 | | - | |
| 36 | + | |
32 | 37 | | |
0 commit comments