Skip to content

Commit b3ffc3b

Browse files
author
Mikolaj Graf
committed
Improve popup filter layout, readability and UX
Brighten ilvl labels, section labels, and item row ilvl text for better readability on dark background. Resize Transmog/Soulbound checkboxes to match quality filter rows. Add visual gaps between filter groups. Fix slot row padding so avg equipped ilvl text no longer overlaps buttons.
1 parent bf1b936 commit b3ffc3b

1 file changed

Lines changed: 20 additions & 17 deletions

File tree

AutoSellPlus/Popup.lua

Lines changed: 20 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ local addonName, ns = ...
33
-- Layout constants
44
local ROW_HEIGHT = 28
55
local POPUP_WIDTH = 580
6-
local POPUP_HEIGHT = 620
6+
local POPUP_HEIGHT = 650
77

88
local FLAT_BACKDROP = ns.FLAT_BACKDROP
99

@@ -318,7 +318,7 @@ local function CreateItemRow(parent, index)
318318
ilvlText:SetPoint("LEFT", badge, "RIGHT", 2, 0)
319319
ilvlText:SetWidth(80)
320320
ilvlText:SetJustifyH("CENTER")
321-
ilvlText:SetTextColor(0.55, 0.55, 0.55)
321+
ilvlText:SetTextColor(0.70, 0.70, 0.70)
322322
row.ilvlText = ilvlText
323323

324324
-- AH value column (shown when TSM/Auctionator detected)
@@ -404,11 +404,11 @@ local function SetRowData(row, item)
404404
if item.isUpgrade then
405405
row.ilvlText:SetTextColor(0.1, 1.0, 0.1)
406406
else
407-
row.ilvlText:SetTextColor(0.55, 0.55, 0.55)
407+
row.ilvlText:SetTextColor(0.70, 0.70, 0.70)
408408
end
409409
else
410410
row.ilvlText:SetText("")
411-
row.ilvlText:SetTextColor(0.55, 0.55, 0.55)
411+
row.ilvlText:SetTextColor(0.70, 0.70, 0.70)
412412
end
413413

414414
-- AH value
@@ -518,7 +518,7 @@ local function CreateQualityFilterRow(f, filterTop, label, checkKey, sliderKey,
518518
local sliderLabel = f:CreateFontString(nil, "OVERLAY", "GameFontHighlightSmall")
519519
sliderLabel:SetPoint("LEFT", checkLabel, "RIGHT", 12, 0)
520520
sliderLabel:SetText("ilvl <=")
521-
sliderLabel:SetTextColor(0.50, 0.50, 0.50)
521+
sliderLabel:SetTextColor(0.65, 0.65, 0.65)
522522

523523
local slider = CreateStyledSlider(f, 0, 700, 5)
524524
slider:SetPoint("LEFT", sliderLabel, "RIGHT", 8, 0)
@@ -683,12 +683,13 @@ local function CreateFilterSection(f)
683683

684684
f.equipCheck = CreateQualityFilterRow(f, filterTop, "Only Equippable", "onlyEquippable", nil, nil, rowY)
685685
rowY = rowY - 22
686+
rowY = rowY - 4
686687

687688
-- Allow transmog checkbox (inverted: checked = protection OFF)
688-
local transmogCheck = CreateStyledCheck(f, 14)
689-
transmogCheck:SetPoint("TOPLEFT", filterLeft, filterTop + rowY + 2)
690-
local transmogLabel = f:CreateFontString(nil, "OVERLAY", "GameFontHighlightSmall")
691-
transmogLabel:SetPoint("LEFT", transmogCheck, "RIGHT", 4, 0)
689+
local transmogCheck = CreateStyledCheck(f, 18)
690+
transmogCheck:SetPoint("TOPLEFT", filterLeft, filterTop + rowY)
691+
local transmogLabel = f:CreateFontString(nil, "OVERLAY", "GameFontHighlight")
692+
transmogLabel:SetPoint("LEFT", transmogCheck, "RIGHT", 6, 0)
692693
transmogLabel:SetText("Allow Transmog")
693694
transmogLabel:SetTextColor(0.70, 0.70, 0.70)
694695
transmogCheck:SetScript("OnClick", function(self)
@@ -703,10 +704,10 @@ local function CreateFilterSection(f)
703704
rowY = rowY - 22
704705

705706
-- Soulbound only checkbox
706-
local soulboundCheck = CreateStyledCheck(f, 14)
707-
soulboundCheck:SetPoint("TOPLEFT", filterLeft, filterTop + rowY + 2)
708-
local soulboundLabel = f:CreateFontString(nil, "OVERLAY", "GameFontHighlightSmall")
709-
soulboundLabel:SetPoint("LEFT", soulboundCheck, "RIGHT", 4, 0)
707+
local soulboundCheck = CreateStyledCheck(f, 18)
708+
soulboundCheck:SetPoint("TOPLEFT", filterLeft, filterTop + rowY)
709+
local soulboundLabel = f:CreateFontString(nil, "OVERLAY", "GameFontHighlight")
710+
soulboundLabel:SetPoint("LEFT", soulboundCheck, "RIGHT", 6, 0)
710711
soulboundLabel:SetText("Soulbound Only")
711712
soulboundLabel:SetTextColor(0.70, 0.70, 0.70)
712713
soulboundCheck:SetScript("OnClick", function(self)
@@ -717,12 +718,13 @@ local function CreateFilterSection(f)
717718
end)
718719
f.soulboundCheck = soulboundCheck
719720
rowY = rowY - 22
721+
rowY = rowY - 4
720722

721723
-- Category filters
722724
local catLabel = f:CreateFontString(nil, "OVERLAY", "GameFontHighlightSmall")
723725
catLabel:SetPoint("TOPLEFT", filterLeft, filterTop + rowY)
724726
catLabel:SetText("Categories:")
725-
catLabel:SetTextColor(0.50, 0.50, 0.50)
727+
catLabel:SetTextColor(0.60, 0.60, 0.60)
726728

727729
local catX = 80
728730
local catNames = {
@@ -749,12 +751,13 @@ local function CreateFilterSection(f)
749751
catX = catX + 70
750752
end
751753
rowY = rowY - 22
754+
rowY = rowY - 4
752755

753756
-- Expansion filter
754757
local expLabel = f:CreateFontString(nil, "OVERLAY", "GameFontHighlightSmall")
755758
expLabel:SetPoint("TOPLEFT", filterLeft, filterTop + rowY)
756759
expLabel:SetText("Expansion:")
757-
expLabel:SetTextColor(0.50, 0.50, 0.50)
760+
expLabel:SetTextColor(0.60, 0.60, 0.60)
758761

759762
local expBtn = CreateFlatButton(f, "All", 80, 18)
760763
expBtn:SetPoint("LEFT", expLabel, "RIGHT", 8, 0)
@@ -788,7 +791,7 @@ local function CreateFilterSection(f)
788791
local slotLabel = f:CreateFontString(nil, "OVERLAY", "GameFontHighlightSmall")
789792
slotLabel:SetPoint("TOPLEFT", filterLeft, filterTop + rowY)
790793
slotLabel:SetText("Slots:")
791-
slotLabel:SetTextColor(0.50, 0.50, 0.50)
794+
slotLabel:SetTextColor(0.60, 0.60, 0.60)
792795

793796
local slotBtnX = 50
794797
local slotIDs = {1, 3, 5, 6, 7, 8, 9, 10, 15, 16, 17}
@@ -824,7 +827,7 @@ local function CreateFilterSection(f)
824827
f.slotButtons[slotID] = slotBtn
825828
slotBtnX = slotBtnX + 28
826829
end
827-
rowY = rowY - 4
830+
rowY = rowY - 22
828831

829832
-- Set filter background height
830833
local filterHeight = math.abs(rowY) + 6

0 commit comments

Comments
 (0)