fix: add notes length validation and consolidate character types

Author: mikkisguy

apps/backend/src/lib/__tests__/validation.unit.test.ts

@@ -1213,6 +1213,34 @@ describe("Character Schemas", () => {
       const result = createCharacterSchema.safeParse(invalidData);
       expect(result.success).toBe(false);
     });
+
+    it("should accept notes with exactly 10000 characters", () => {
+      const validData = {
+        projectId: "550e8400-e29b-41d4-a716-446655440000",
+        name: "Character Name",
+        displayName: "Display Name",
+        renpyTag: "char",
+        color: "#FF5733",
+        notes: "x".repeat(10000),
+      };
+
+      const result = createCharacterSchema.safeParse(validData);
+      expect(result.success).toBe(true);
+    });
+
+    it("should reject notes with 10001 characters", () => {
+      const validData = {
+        projectId: "550e8400-e29b-41d4-a716-446655440000",
+        name: "Character Name",
+        displayName: "Display Name",
+        renpyTag: "char",
+        color: "#FF5733",
+        notes: "x".repeat(10001),
+      };
+
+      const result = createCharacterSchema.safeParse(validData);
+      expect(result.success).toBe(false);
+    });
   });
 
   describe("characterIdParamsSchema", () => {

apps/backend/src/services/characters.service.ts

@@ -49,22 +49,7 @@ import type {
 // Types
 // ============================================================================
 
-/** Character summary returned in list views */
-export interface CharacterSummary {
-  id: string;
-  name: string;
-  displayName: string;
-  renpyTag: string;
-  color: string;
-  routeAffiliation: string | null;
-  isLoveInterest: boolean;
-  isNarrator: boolean;
-  notes: string | null;
-  conditionalPrefix: string | null;
-  avatarUrl: string | null;
-}
-
-/** Full character detail returned for single-character operations */
+/** Character detail returned for list-views and single-character operations */
 export interface CharacterDetail {
   id: string;
   name: string;
@@ -472,7 +457,7 @@ export class CharactersService {
   async listCharacters(
     projectId: string,
     userId: string
-  ): Promise<CharacterSummary[]> {
+  ): Promise<CharacterDetail[]> {
     await requireProjectOwnership(projectId, userId);
 
     const db = getDb();

apps/frontend/src/components/CharacterEditDialog.tsx

@@ -51,6 +51,7 @@ interface CharacterFormState {
   displayNameError?: string;
   renpyTagError?: string;
   colorError?: string;
+  notesError?: string;
 }
 
 type FormAction =
@@ -63,6 +64,7 @@ type FormAction =
   | { type: "SET_NAME_ERROR"; value: string }
   | { type: "SET_DISPLAY_NAME_ERROR"; value: string }
   | { type: "SET_RENPY_TAG_ERROR"; value: string }
+  | { type: "SET_NOTES_ERROR"; value: string }
   | { type: "SET_COLOR_ERROR"; value: string };
 
 const INITIAL_EMPTY: CharacterFormState = {
@@ -83,6 +85,7 @@ const INITIAL_EMPTY: CharacterFormState = {
   displayNameError: "",
   renpyTagError: "",
   colorError: "",
+  notesError: "",
 };
 
 function formReducer(
@@ -134,6 +137,8 @@ function formReducer(
       return { ...state, renpyTagError: action.value };
     case "SET_COLOR_ERROR":
       return { ...state, colorError: action.value };
+    case "SET_NOTES_ERROR":
+      return { ...state, notesError: action.value };
   }
 }
 
@@ -158,6 +163,9 @@ function validateForm(state: CharacterFormState): {
   if (!/^#[0-9A-Fa-f]{6}$/.test(state.color)) {
     errors.color = "Color must be valid hex (#RRGGBB)";
   }
+  if (state.notes.length > 10000) {
+    errors.notes = "Notes must be 10000 characters or fewer";
+  }
 
   return { valid: Object.keys(errors).length === 0, errors };
 }
@@ -245,6 +253,7 @@ export function CharacterEditDialog({
     dispatch({ type: "SET_DISPLAY_NAME_ERROR", value: "" });
     dispatch({ type: "SET_RENPY_TAG_ERROR", value: "" });
     dispatch({ type: "SET_COLOR_ERROR", value: "" });
+    dispatch({ type: "SET_NOTES_ERROR", value: "" });
   };
 
   const handleAvatarSelect = (e: React.ChangeEvent<HTMLInputElement>) => {
@@ -295,6 +304,8 @@ export function CharacterEditDialog({
         dispatch({ type: "SET_RENPY_TAG_ERROR", value: errors.renpyTag });
       if (errors.color)
         dispatch({ type: "SET_COLOR_ERROR", value: errors.color });
+      if (errors.notes)
+        dispatch({ type: "SET_NOTES_ERROR", value: errors.notes });
       return;
     }
 
@@ -557,7 +568,11 @@ export function CharacterEditDialog({
               value={form.notes}
               onChange={(e) => handleFieldChange("notes", e.target.value)}
               disabled={isSaving}
+              maxLength={10000}
             />
+            {form.notesError && (
+              <p className="text-xs text-destructive">{form.notesError}</p>
+            )}
           </div>
 
           {/* Love Interest + Narrator */}