Add tests for nested conditions and mixed variable handling in extractTechnicalConstructs

Author: mikkisguy

apps/backend/src/services/__tests__/technical-parser.service.unit.test.ts

@@ -117,6 +117,26 @@ describe("extractTechnicalConstructs - comparison operators", () => {
       },
     });
   });
+
+  it("handles nested conditions with parentheses", () => {
+    const rpyContent = "if (strength >= 5 or magic > 10):";
+    const result = extractTechnicalConstructs(rpyContent, 0);
+    expect(result.conditions).toBeDefined();
+    expect(result.conditions?.stats).toEqual({
+      strength: { value: 5, operator: ">=" },
+      magic: { value: 10, operator: ">" },
+    });
+  });
+
+  it("extracts stats when mixed with variables", () => {
+    const rpyContent = "if strength >= 5 and flag_luna:";
+    const result = extractTechnicalConstructs(rpyContent, 0);
+    expect(result.conditions).toBeDefined();
+    expect(result.conditions?.stats).toEqual({
+      strength: { value: 5, operator: ">=" },
+    });
+    expect(result.conditions?.variables).toEqual(["flag_luna"]);
+  });
 });
 
 describe("extractTechnicalConstructs - if/elif conditions with deltas", () => {

apps/backend/src/services/rpy-parser.service.ts

@@ -1976,6 +1976,7 @@ export function extractTechnicalConstructs(
       .trim();
 
     // Extract stat comparisons: e.g., "strength >= 5" or "magic < 10"
+    // Limitations: Does not handle variable comparisons (e.g., "strength >= max_value")
     const statRegex = /([a-zA-Z_][a-zA-Z0-9_]*)\s*(>=|<=|>|<|==|!=)\s*(-?\d+)/g;
     let statMatch;
     while ((statMatch = statRegex.exec(conditionExpr)) !== null) {

apps/frontend/src/contexts/__tests__/ThemeContext.test.tsx

@@ -26,7 +26,7 @@ const localStorageMock = (() => {
   };
 })();
 
-Object.defineProperty(global, "localStorage", {
+Object.defineProperty(globalThis, "localStorage", {
   value: localStorageMock,
 });
 

apps/frontend/src/lib/api/__tests__/auth.unit.test.ts

@@ -10,7 +10,7 @@ import type { LoginCredentials, RegisterCredentials } from "../auth";
 
 // Mock fetch globally
 const mockFetch = vi.fn();
-global.fetch = mockFetch;
+globalThis.fetch = mockFetch;
 
 describe("Auth API", () => {
   beforeEach(() => {

apps/frontend/src/lib/api/__tests__/gitlab.unit.test.ts

@@ -10,7 +10,7 @@ import { gitlabApi } from "../gitlab.js";
 
 // Mock fetch
 const mockFetch = vi.fn();
-global.fetch = mockFetch as unknown as typeof fetch;
+globalThis.fetch = mockFetch as unknown as typeof fetch;
 
 describe("GitLab API Client", () => {
   afterEach(() => {

apps/frontend/src/lib/api/__tests__/variables.unit.test.ts

@@ -11,7 +11,7 @@ import type { Variable } from "@branchforge/shared";
 
 // Mock fetch globally
 const mockFetch = vi.fn();
-global.fetch = mockFetch;
+globalThis.fetch = mockFetch;
 
 describe("Variables API", () => {
   const mockVariable: Variable = {

apps/frontend/tsconfig.json

@@ -15,6 +15,7 @@
     "noUnusedLocals": true,
     "noUnusedParameters": true,
     "noFallthroughCasesInSwitch": true,
+    "types": ["vitest/globals", "@testing-library/jest-dom"],
     "paths": {
       "@/*": ["./src/*"]
     }