Refactor technical badge seeding and update condition handling for stat deltas

Author: mikkisguy

apps/backend/scripts/seed-technical-badges.ts

@@ -332,26 +332,6 @@ async function seedTechnicalBadgesData() {
       },
     },
 
-    // Line 10: All comparison operators in one place
-    {
-      labelId,
-      sequence: 10,
-      content: "Testing all comparison operators.",
-      contentType: "NARRATION",
-      speakerId: null,
-      visualType: "GENERATED",
-      conditions: {
-        stats: {
-          strength: { value: 10, operator: ">=" },
-          dexterity: { value: 5, operator: "<=" },
-          intelligence: { value: 15, operator: ">" },
-          wisdom: { value: 3, operator: "<" },
-          charisma: { value: 8, operator: "==" },
-          luck: { value: 0, operator: "!=" },
-        },
-      },
-    },
-
     // Line 9: Complex menu with condition flags
     {
       labelId,
@@ -376,6 +356,26 @@ async function seedTechnicalBadgesData() {
         },
       ],
     },
+
+    // Line 10: All comparison operators in one place
+    {
+      labelId,
+      sequence: 10,
+      content: "Testing all comparison operators.",
+      contentType: "NARRATION",
+      speakerId: null,
+      visualType: "GENERATED",
+      conditions: {
+        stats: {
+          strength: { value: 10, operator: ">=" },
+          dexterity: { value: 5, operator: "<=" },
+          intelligence: { value: 15, operator: ">" },
+          wisdom: { value: 3, operator: "<" },
+          charisma: { value: 8, operator: "==" },
+          luck: { value: 0, operator: "!=" },
+        },
+      },
+    },
   ];
 
   await db.insert(labelLines).values(testLines);

apps/backend/src/services/__tests__/label-line-mapper.service.unit.test.ts

@@ -1,6 +1,6 @@
 import { describe, it, expect } from "vitest";
 import { mapEntriesToLabelLineValues } from "../label-line-mapper";
-import type { ComparisonOperator } from "@branchforge/shared";
+import type { ComparisonOperator, StatCondition } from "@branchforge/shared";
 
 describe("mapEntriesToLabelLineValues - technical metadata", () => {
   const charactersByTag = new Map<string, string>();
@@ -118,6 +118,39 @@ describe("mapEntriesToLabelLineValues - technical metadata", () => {
     });
   });
 
+  it("preserves statDeltas when present with stats", () => {
+    const entries = [
+      {
+        type: "DIALOGUE" as const,
+        text: "Hello",
+        speaker: "char1",
+        lineNumber: 1,
+        indentLevel: 0,
+        conditions: {
+          stats: {
+            affection_luna: {
+              value: 50,
+              operator: ">=",
+            } as StatCondition,
+          },
+          statDeltas: { affection_luna: 10 },
+        },
+      },
+    ];
+
+    const result = mapEntriesToLabelLineValues(
+      entries,
+      "label1",
+      "project1",
+      charactersByTag
+    );
+
+    expect(result[0].conditions).toMatchObject({
+      stats: { affection_luna: { value: 50, operator: ">=" } },
+      statDeltas: { affection_luna: 10 },
+    });
+  });
+
   it("maps null conditions when not present", () => {
     const entries = [
       {

apps/backend/src/services/__tests__/technical-parser.service.unit.test.ts

@@ -104,6 +104,14 @@ describe("extractTechnicalConstructs - comparison operators", () => {
     });
   });
 
+  it("handles elif the same as if", () => {
+    const rpyContent = "elif affection_luna >= 50:";
+    const result = extractTechnicalConstructs(rpyContent, 0);
+    expect(result.conditions).toEqual({
+      stats: { affection_luna: { value: 50, operator: ">=" } },
+    });
+  });
+
   it("captures <=, >, <, ==, != operators", () => {
     const rpyContent = `if strength <= 5 and magic > 10 and charm < 3 and mood == 2 and trust != 1:`;
     const result = extractTechnicalConstructs(rpyContent, 0);

apps/backend/src/services/label-line-mapper.ts

@@ -33,6 +33,7 @@ export type ContentType =
 export type LineConditions = {
   stats?: Record<string, number | StatCondition>;
   variables?: string[];
+  statDeltas?: Record<string, number>;
 };
 
 /**

apps/backend/src/services/labels.service.ts

@@ -30,6 +30,7 @@ import {
   LabelStatus,
   sanitizeLabelName,
   RENPY_LABEL_REGEX,
+  type ComparisonOperator,
 } from "@branchforge/shared";
 import { createAuditFields, updateAuditFields } from "../lib/audit.js";
 import {
@@ -1728,6 +1729,22 @@ export async function authorizeLabelAccess(
  * @param label - The label data (with filePath from JOIN)
  */
 function mapToPublicLabel(label: LabelForPublic): PublicLabel {
+  // Transform database format to API format for conditions.stats
+  // Database stores stats as Record<string, number>, API expects Record<string, StatCondition>
+  const transformedConditions: PublicLabel["conditions"] = label.conditions
+    ? {
+        variables: label.conditions.variables,
+        stats: label.conditions.stats
+          ? Object.fromEntries(
+              Object.entries(label.conditions.stats).map(([key, value]) => [
+                key,
+                { value, operator: ">=" as ComparisonOperator },
+              ])
+            )
+          : undefined,
+      }
+    : null;
+
   return {
     id: label.id,
     projectId: label.projectId,
@@ -1742,7 +1759,7 @@ function mapToPublicLabel(label: LabelForPublic): PublicLabel {
     visibility: label.visibility,
     version: label.version,
     contentHash: label.contentHash,
-    conditions: label.conditions ?? null,
+    conditions: transformedConditions,
     projectFileId: label.projectFileId,
     fileName: extractFileName(label.filePath),
     createdAt: label.createdAt.toISOString(),

apps/frontend/src/components/__tests__/TechnicalPopover.test.tsx

@@ -1,5 +1,6 @@
 import { render, screen } from "@testing-library/react";
-import { TechnicalPopover } from "../write-mode/TechnicalPopover";
+import { describe, it, expect } from "vitest";
+import { TechnicalPopover } from "@/components/write-mode/TechnicalPopover";
 import type { StatCondition } from "@branchforge/shared";
 
 describe("TechnicalPopover", () => {

apps/frontend/src/lib/api/__tests__/gitlab.unit.test.ts

@@ -10,7 +10,7 @@ import { gitlabApi } from "../gitlab.js";
 
 // Mock fetch
 const mockFetch = vi.fn();
-globalThis.fetch = mockFetch as unknown as typeof fetch;
+globalThis.fetch = mockFetch;
 
 describe("GitLab API Client", () => {
   afterEach(() => {

apps/frontend/tsconfig.json

@@ -15,7 +15,7 @@
     "noUnusedLocals": true,
     "noUnusedParameters": true,
     "noFallthroughCasesInSwitch": true,
-    "types": ["vitest/globals", "@testing-library/jest-dom"],
+    "types": ["@testing-library/jest-dom"],
     "paths": {
       "@/*": ["./src/*"]
     }

packages/shared/src/index.ts

@@ -384,7 +384,7 @@ export interface PublicLabel {
   /** Variable and stat conditions for this label */
   conditions: {
     variables?: string[];
-    stats?: Record<string, number>;
+    stats?: Record<string, StatCondition>;
   } | null;
   createdAt: string;
   updatedAt: string;