test(search): cover the warm restore path as well as the cold start

The two tests added with the fix both drive the cold-start branch. This adds one
for the cached branch, where the `finally` used to override the `catch`, so both
halves of the change have a test that fails without it.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Author: ppcvote

CHANGELOG.md

@@ -5,7 +5,7 @@
 ### Bug Fixes
 
 * Settle the search index write when an IndexedDB write fails, instead of leaving the promise pending and the search spinner up.
-* Disable the search controls and explain why when the search index cannot be built, instead of leaving the spinner running for as long as the page is open.
+* Disable the search controls and explain why when the search index cannot be built, instead of leaving the spinner running for as long as the page is open. A failed restore from the cached index is no longer reported as a successful load.
 
 ## v5.0.0 (2026-08-06)
 

attack-search/__tests__/search-events.test.js

@@ -128,6 +128,15 @@ describe('search event bindings', () => {
     expect(parsingIcon.hide).toHaveBeenCalled();
   });
 
+  test('a failed restore from the cache is not reported as a successful load', async () => {
+    await loadIndexWithAFailingWarmRestore();
+
+    // The catch used to set the loaded flag false and the finally set it straight back to
+    // true, so `search` went on to query an index that was never populated.
+    expect(mockJqueryApis['#search-input'].prop).toHaveBeenCalledWith('disabled', true);
+    expect(mockJqueryApis['#search-icon'].addClass).toHaveBeenCalledWith('error-icon');
+  });
+
   test('a failed index build puts the search controls into their unavailable state', async () => {
     await loadIndexWithAFailingColdStart();
 
@@ -159,6 +168,24 @@ async function loadIndexWithAFailingColdStart() {
   await new Promise(resolve => setImmediate(resolve));
 }
 
+// Load the module on the cached path, with restoring the index from IndexedDB failing.
+async function loadIndexWithAFailingWarmRestore() {
+  const { searchCacheCompatibilityVersion, searchCacheSchemaVersion } = require('../src/settings');
+  const version = `${searchCacheSchemaVersion}-${searchCacheCompatibilityVersion}`;
+
+  global.window = { indexedDB: {} };
+  global.localStorage.getItem.mockReturnValue(`${global.build_uuid}-search-${version}`);
+
+  jest.doMock('../src/search-service.js', () => class {
+    initializeAsync() {
+      return Promise.reject(new Error('cached index is unreadable'));
+    }
+  });
+
+  require('../src/index');
+  await new Promise(resolve => setImmediate(resolve));
+}
+
 function eventsForSelector(selector) {
   return mockJqueryCalls
     .filter(call => call.selector === selector || call.delegatedSelector === selector)