Commit 75e3dd3
committed
ci: drop JAMWIDE_BUILD_TESTS + VIDEO_SPIKE from mac CI for v1.3 betas
The current mac CI configure step inherited JAMWIDE_BUILD_TESTS=ON and
JAMWIDE_VIDEO_SPIKE=ON from Phase 14.3 work, which builds test_flac_codec.
That test target has a pre-existing CMake-vs-header gap:
- CMakeLists.txt:472 sets WDL_VORBIS_INTERFACE_ONLY compile-def on
test_flac_codec with the comment 'Only expose interfaces from
vorbisencdec.h (no Vorbis codec deps)'
- wdl/vorbisencdec.h:42 unconditionally #includes vorbis/vorbisenc.h
without a WDL_VORBIS_INTERFACE_ONLY guard
Result on arm64-only mac CI:
wdl/vorbisencdec.h:42:10: fatal error: 'vorbis/vorbisenc.h' file not found
This is pre-existing test-infra rot (not a product issue) — beta.20.5
sidestepped it by not setting JAMWIDE_BUILD_TESTS at all. Match that
surface for v1.3 betas:
- Drop -DJAMWIDE_BUILD_TESTS=ON
- Drop -DJAMWIDE_VIDEO_SPIKE=ON (was paired with the test surface)
- Drop the 'Run Phase 14.3 unit tests' step (its target executables
no longer exist without BUILD_TESTS)
Phase 23+ will re-enable the test surface once the
WDL_VORBIS_INTERFACE_ONLY guard is actually added to the header (or the
test target is wired to link vorbis directly).1 parent 30ee519 commit 75e3dd3
1 file changed
Lines changed: 6 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
64 | 70 | | |
65 | 71 | | |
66 | 72 | | |
67 | 73 | | |
68 | 74 | | |
69 | 75 | | |
70 | 76 | | |
71 | | - | |
72 | | - | |
73 | 77 | | |
74 | 78 | | |
75 | 79 | | |
76 | 80 | | |
77 | 81 | | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | 82 | | |
88 | 83 | | |
89 | 84 | | |
| |||
0 commit comments