Skip to content
This repository was archived by the owner on Mar 10, 2022. It is now read-only.

Commit d02bc48

Browse files
Jakob MygindJakob Mygind
authored andcommitted
Made Noted more swift3y
1 parent 13fbee6 commit d02bc48

2 files changed

Lines changed: 5 additions & 7 deletions

File tree

Noted/Classes/Noted.swift

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ public class Noted {
4242

4343
public static let defaultInstance = Noted()
4444

45-
4645
private let notedQueue = DispatchQueue(label: "com.nodes.noted", attributes: .concurrent)
4746

4847
private var _observers = NSHashTable<NoteObserverInfo>(options: .weakMemory)
@@ -51,24 +50,23 @@ public class Noted {
5150
return _observers.allObjects.map {$0.receiver}
5251
}
5352

54-
5553
private init() {}
5654

57-
public func addObserver(_ observer: NoteObserver, filter: NoteFilter = PassthroughNoteFilter()) {
55+
public func add(observer: NoteObserver, filter: NoteFilter = PassthroughNoteFilter()) {
5856
notedQueue.async(group: nil, qos: .default, flags: .barrier) {
5957
self._observers.add(NoteObserverInfo(receiver: observer, filter: filter))
6058
}
6159
}
6260

63-
public func removeObserver(_ observer: NoteObserver) {
61+
public func remove(observer: NoteObserver) {
6462
notedQueue.async(group: nil, qos: .default, flags: .barrier) {
6563
if let foundEntry = (self._observers.allObjects).first(where: {$0.receiver === observer}) {
6664
self._observers.remove(foundEntry)
6765
}
6866
}
6967
}
7068

71-
public func postNote(_ note: NoteType) {
69+
public func post(note: NoteType) {
7270
notedQueue.async {
7371
for receiver in self._observers.allObjects {
7472
if !receiver.filter.shouldFilter(note:note) {

NotedTests/ThreadSafeTests.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,8 @@ class ThreadSafeTests: XCTestCase {
4848
receiverStore.append(controller)
4949
let queue = DispatchQueue(label:"com.noted.queue.\(index)")
5050
queue.async {
51-
Noted.defaultInstance.addObserver(controller)
52-
Noted.defaultInstance.postNote(TestNotification.TestUpdated)
51+
Noted.defaultInstance.add(observer: controller)
52+
Noted.defaultInstance.post(note: TestNotification.TestUpdated)
5353

5454
}
5555

0 commit comments

Comments
 (0)