Heads-up, and no urgency — I started wiring the EnVar → OMOP mapping against this schema a bit early (while it's still in progress), and hit one thing worth flagging.
On ExternalExposure, the FK and concept-id slots (location_id and the *_concept_id columns) are marked identifier: true. In LinkML that implies required, so validating real external_exposure rows fails — OMOP treats these as nullable FKs / 0 for unmapped concepts. Looks like only external_exposure_id should be the identifier.
I've patched it locally for now, so nothing's blocked on my side. Flagging in case it's useful — your call on the fix, since you may be mid-design here. Happy to open a small PR if you'd like.
Heads-up, and no urgency — I started wiring the EnVar → OMOP mapping against this schema a bit early (while it's still in progress), and hit one thing worth flagging.
On
ExternalExposure, the FK and concept-id slots (location_idand the*_concept_idcolumns) are markedidentifier: true. In LinkML that implies required, so validating realexternal_exposurerows fails — OMOP treats these as nullable FKs /0for unmapped concepts. Looks like onlyexternal_exposure_idshould be the identifier.I've patched it locally for now, so nothing's blocked on my side. Flagging in case it's useful — your call on the fix, since you may be mid-design here. Happy to open a small PR if you'd like.