Skip to content

Set CURLOPT_HTTP09_ALLOWED to true - #155

Open
ExpDev07 wants to merge 1 commit into
monero-integrations:masterfrom
ExpDev07:patch-1
Open

Set CURLOPT_HTTP09_ALLOWED to true#155
ExpDev07 wants to merge 1 commit into
monero-integrations:masterfrom
ExpDev07:patch-1

Conversation

@ExpDev07

Copy link
Copy Markdown

CURL allowed HTTP/0.9 responses by default before 7.66.0, but since 7.66.0, libcurl requires this option set to 1L to allow HTTP/0.9 responses. This is required for interacting with Monero wallet as it uses HTTP/0.9.

https://curl.se/libcurl/c/CURLOPT_HTTP09_ALLOWED.html

@recanman

Copy link
Copy Markdown
Contributor

This code is old and is to be replaced by #154.

@ExpDev07

ExpDev07 commented May 25, 2024

Copy link
Copy Markdown
Author

I'll just patch it until the release then @recanman.

But wouldn't this still be good to merge as it's such a small non breaking change, and we don't know when the new version is going to be replaced. If people wanna use it and have a newer cURL version, they literally can't use it without the patch.

@recanman

Copy link
Copy Markdown
Contributor

Good point. I don't have write access and I cannot merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants