fix: keep node failover available

Author: Slow

includes/class-wc-gateway-monero.php

@@ -615,18 +615,26 @@ private function nodes_match_network( $nodes, $network ) {
 			return 'ok' === $health;
 		}
 		require_once __DIR__ . '/class-monero-scanner.php';
-		$health = 'ok';
+		$infos = array();
 		foreach ( $nodes as $node ) {
-			$info = ( new Monero_Scanner( $node, $network, 12 ) )->node_info();
-			if ( empty( $info['ok'] ) || empty( $info['nettype'] ) || 'unknown' === $info['nettype'] || $network !== $info['nettype'] ) {
-				$health = 'invalid';
-				break;
-			}
+			$infos[] = ( new Monero_Scanner( $node, $network, 12 ) )->node_info();
 		}
+		$health = self::node_health_allows_payments( $infos, $network ) ? 'ok' : 'invalid';
 		set_transient( $key, $health, 'ok' === $health ? 5 * MINUTE_IN_SECONDS : MINUTE_IN_SECONDS );
 		return 'ok' === $health;
 	}
 
+	public static function node_health_allows_payments( $infos, $network ) {
+		$healthy = 0;
+		foreach ( (array) $infos as $info ) {
+			if ( empty( $info['ok'] ) ) { continue; }
+			$nettype = isset( $info['nettype'] ) ? (string) $info['nettype'] : 'unknown';
+			if ( 'unknown' !== $nettype && $network !== $nettype ) { return false; }
+			$healthy++;
+		}
+		return $healthy > 0;
+	}
+
 	private function live_rate_stale() {
 		$source = $this->get_option( 'price_source', 'coingecko' );
 		if ( 'fixed' === $source || (float) $this->get_option( 'fixed_rate' ) > 0 ) {

tests/node-auth.test.php

@@ -35,6 +35,17 @@ class WC_Payment_Gateway {}
 ok_auth( '401 diagnostic is specific', 'unauthorized' === $diagnostic['code'] && false !== strpos( $diagnostic['msg'], 'credentials' ) );
 $diagnostic = WC_Gateway_Monero::node_setup_diagnostic( array( 'code' => 'digest_unavailable' ) );
 ok_auth( 'Digest diagnostic requests cURL', 'digest_unavailable' === $diagnostic['code'] && false !== strpos( $diagnostic['msg'], 'cURL' ) );
+ok_auth( 'one healthy node tolerates an unreachable fallback', WC_Gateway_Monero::node_health_allows_payments( array(
+	array( 'ok' => true, 'nettype' => 'stagenet' ),
+	array( 'ok' => false, 'nettype' => 'unknown' ),
+), 'stagenet' ) );
+ok_auth( 'reachable wrong-network node is rejected', ! WC_Gateway_Monero::node_health_allows_payments( array(
+	array( 'ok' => true, 'nettype' => 'stagenet' ),
+	array( 'ok' => true, 'nettype' => 'mainnet' ),
+), 'stagenet' ) );
+ok_auth( 'no healthy node fails closed', ! WC_Gateway_Monero::node_health_allows_payments( array(
+	array( 'ok' => false, 'nettype' => 'unknown' ),
+), 'stagenet' ) );
 
 $responses[] = array( 'code' => 200, 'body' => json_encode( array( 'height' => 123, 'nettype' => 'mainnet' ) ) );
 $scanner = new Monero_Scanner( array( array( 'url' => 'https://node.test', 'auth' => 'basic', 'username' => 'u', 'password' => 'p' ) ) );