Skip to content

Commit 5efbc6d

Browse files
committed
Do not log payment proof txid, address, message or signature
1 parent b712912 commit 5efbc6d

1 file changed

Lines changed: 4 additions & 9 deletions

File tree

main.qml

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1068,10 +1068,8 @@ ApplicationWindow {
10681068
var result = currentWallet.getReserveProof(false, currentWallet.currentSubaddressAccount, amount, message)
10691069
txProofComputed(null, result)
10701070
} else {
1071-
console.log("Getting payment proof: ")
1072-
console.log("\ttxid: ", txid,
1073-
", address: ", address,
1074-
", message: ", message);
1071+
// Don't log txid/address/message; payment-proof signatures are
1072+
// sensitive and must not end up in the logs.
10751073
function spendProofFallback(txid, result){
10761074
if (!result || result.indexOf("error|") === 0) {
10771075
currentWallet.getSpendProofAsync(txid, message, txProofComputed);
@@ -1100,11 +1098,8 @@ ApplicationWindow {
11001098

11011099
// called on "checkProof"
11021100
function handleCheckProof(txid, address, message, signature) {
1103-
console.log("Checking payment proof: ")
1104-
console.log("\ttxid: ", txid,
1105-
", address: ", address,
1106-
", message: ", message,
1107-
", signature: ", signature);
1101+
// Don't log txid/address/message/signature; payment-proof signatures
1102+
// are sensitive and must not end up in the logs.
11081103

11091104
var result;
11101105
var isReserveProof = signature.indexOf("ReserveProofV") === 0;

0 commit comments

Comments
 (0)