fix allocator-bench

Author: monosans

.github/scripts/allocator_bench_alpine.sh

@@ -34,4 +34,10 @@ docker run --rm \
 # actions/upload-artifact can read them.
 sudo chown -R "$(id -u):$(id -g)" . 2>/dev/null || true
 
-cat alpine-summary.md >> "$GITHUB_STEP_SUMMARY"
+# Cosmetic, like the summary itself: the measured rows live in
+# bench-results.tsv and are uploaded regardless.
+if [ -f alpine-summary.md ]; then
+  cat alpine-summary.md >> "$GITHUB_STEP_SUMMARY"
+else
+  echo "::warning::no alpine-summary.md (results are still in bench-results.tsv)"
+fi

.github/scripts/allocator_bench_report.sh

@@ -28,7 +28,11 @@ cell_id="$2"
         a[j + 1] = t
       }
     }
-    function stat(src, n, out,   i, s[1], d[1], med) {
+    # s and d are locals: awk gives a function extra parameters as fresh
+    # locals, and they become arrays on first subscripted use. They must be
+    # named plainly - "s[1]" in a parameter list is a syntax error, and mawk
+    # (the default awk on Ubuntu runners) reports it as one.
+    function stat(src, n, out,   i, s, d, med) {
       for (i = 1; i <= n; i++) s[i] = src[i]
       isort(s, n); med = median(s, n)
       for (i = 1; i <= n; i++) d[i] = (s[i] > med) ? s[i] - med : med - s[i]

.github/scripts/allocator_bench_unix.sh

@@ -211,8 +211,13 @@ done
 IFS="$old_ifs"
 done
 
+# The summary is cosmetic; bench-results.tsv is the artifact that matters and
+# the aggregate job reads that, not this. A formatting bug here must never
+# discard a cell that already ran to completion - which is exactly what an awk
+# syntax error did once, throwing away every measured repetition of the job.
 echo "$cells" | while read -r cell; do
   if [ -n "$cell" ]; then
-    sh .github/scripts/allocator_bench_report.sh "$results" "$cell"
+    sh .github/scripts/allocator_bench_report.sh "$results" "$cell" \
+      || echo "::warning::summary failed for $cell (results are still in $results)" >&2
   fi
 done

.github/scripts/allocator_bench_windows.ps1

@@ -201,6 +201,10 @@ foreach ($workload in $workloads) {
 
     # Median rather than mean, MAD rather than stddev: with 5 reps a single
     # descheduled run would drag a mean far enough to invent a difference.
+    # Wrapped because the summary is cosmetic: bench-results.tsv is the
+    # artifact the aggregate job reads, and a formatting bug must not discard
+    # a cell that already ran to completion.
+    try {
     $summary = @("### $cellId", '',
       "reps: $($rows.Count)    cores: $cores    rustc: $toolchain    exe: $exeSha", '',
       '| metric | median | MAD |', '| --- | ---: | ---: |')
@@ -213,5 +217,8 @@ foreach ($workload in $workloads) {
     }
     $summary += ''
     ($summary -join "`n") | Add-Content -Path $env:GITHUB_STEP_SUMMARY -Encoding utf8
+    } catch {
+      Write-Host "::warning::summary failed for $cellId ($($_.Exception.Message)); results are still in $results"
+    }
   }
 }