improve chargen creation, warn for old species tables, version number

Author: moo-man

README.md

@@ -168,6 +168,8 @@ npm run pack
 
 - [Places & Perils](https://foundryvtt.com/packages/wfrp4e-owb3/) - Contains seven more titles previously released as short PDF only options that will help expand your WFRP adventures, this time focused on various locations and people.
 
+- [Deft Steps Light Fingers](https://foundryvtt.com/packages/wfrp4e-dslf/) - A supplement for playing Characters in the Rogue or Ranger class.
+
 **Unofficial**
 
 - [The GM Toolkit](https://foundryvtt.com/packages/wfrp4e-gm-toolkit) - Adds advantage automation, extends the Token HUD for more information, and adds useful macros!

src/apps/chargen/char-gen.js

@@ -128,6 +128,12 @@ export default class CharGenWfrp4e extends FormApplication {
       ui.notifications.warn(game.i18n.localize("CHARGEN.NoGMWarning"), {permanent : true})
     }
 
+    let speciesTable = game.wfrp4e.tables.findTable("species");
+
+    if (speciesTable.results.some(i => !i.name))
+    {
+      ui.notifications.warn("The configured Species table is from an older version and may not be compatible with character creation in V13. To ensure it works correctly, please delete and reimport the table from the compendium.", {permanent : true})
+    }
 
     Hooks.call("wfrp4e:chargen", this)
   }
@@ -353,38 +359,36 @@ export default class CharGenWfrp4e extends FormApplication {
         return i instanceof Item.implementation ? i.toObject() : i
       })
 
+
+      // Must create items separately so preCreate scripts run
+      let actorItems = this.actor.items;
+      this.actor.items = [];
+
       if (game.user.isGM || game.settings.get("core", "permissions").ACTOR_CREATE.includes(game.user.role))
       {
-        // Must create items separately so preCreate scripts run
-        let actorItems = this.actor.items;
-        this.actor.items = [];
-        let document = await Actor.create(this.actor, {skipItems : true});
+
+        let document = await Actor.implementation.create(this.actor, {skipItems : true});
         await document.createEmbeddedDocuments("Item", actorItems, {skipSpecialisationChoice : true})
-        for(let i of document.items.contents)
-        {
-          // Run onCreate scripts
-          await i._onCreate(i._source, {}, game.user.id);
-        }
+        // for(let i of document.items.contents)
+        // {
+        //   // Run onCreate scripts
+        //   await i._onCreate(i._source, {}, game.user.id);
+        // }
         document.sheet.render(true);
         localStorage.removeItem("wfrp4e-chargen")
       }
       else {
-        // Create temp actor to handle any immediate scripts
-        let tempActor = await Actor.create(this.actor, {temporary: true})
-        for(let i of tempActor.items.contents)
-        {
-          // Run preCreate scripts
-          await i._preCreate(i._source, {skipSpecialisationChoice : true}, game.user.id);
-        }
-        const payload =  {id : game.user.id, data : tempActor.toObject(), options : {skipSpecialisationChoice : true}}
+        const payload =  {id : game.user.id, data : this.actor, options : {skipSpecialisationChoice : true}}
         let id = await SocketHandlers.executeOnUserAndWait("GM", "createActor", payload);
         let actor = game.actors.get(id);
-        if (actor && actor.isOwner) {
-          for(let i of actor.items.contents)
-          {
-            // Run onCreate scripts
-            await i._onCreate(i._source, {}, game.user.id);
-          }
+        await actor.createEmbeddedDocuments("Item", actorItems, {skipSpecialisationChoice : true})
+        if (actor && actor.isOwner) 
+        {
+          // for(let i of actor.items.contents)
+          // {
+          //   // Run onCreate scripts
+          //   await i._onCreate(i._source, {}, game.user.id);
+          // }
           actor.sheet.render(true)
           localStorage.removeItem("wfrp4e-chargen")
         }

src/apps/chargen/species.js

@@ -48,10 +48,10 @@ export class SpeciesStage extends ChargenStage {
 
     for (let result of speciesTable.results)
     {
-      let speciesKey = warhammer.utility.findKey(result.text, game.wfrp4e.config.species)
+      let speciesKey = warhammer.utility.findKey(result.name, game.wfrp4e.config.species)
       if (speciesKey)
       {
-        data.species[speciesKey] = result.text
+        data.species[speciesKey] = result.name
       }
     }
 
@@ -139,8 +139,8 @@ export class SpeciesStage extends ChargenStage {
     this.context.exp = 20;
     this.context.roll = await game.wfrp4e.tables.rollTable("species");
     this.context.choose = false;
-    this.updateMessage("Rolled", {rolled : this.context.roll.result})
-    this.setSpecies(findKey(this.context.roll.result, game.wfrp4e.config.species));
+    this.updateMessage("Rolled", {rolled : this.context.roll.name})
+    this.setSpecies(findKey(this.context.roll.name, game.wfrp4e.config.species));
   }
 
   // Set chosen species, but don't unset "roll" (prevents users from rolling again after they've rolled once)

src/system/tables-wfrp4e.js

@@ -96,6 +96,7 @@ export default class WFRP_Tables {
         result : rollResult?.getChatText(),
         roll : displayTotal,
         total : rollValue,
+        name : rollResult?.name,
         object : rollResult?.toObject(),
         title : table.name,
       }

static/templates/apps/chargen/species.hbs

@@ -28,7 +28,7 @@
     {{#if context.choose}}
     <div><b>{{localize "Choose"}}:</b> {{configLookup "species" context.choose}}</div>
     {{else if context.roll}}
-    <div><b>{{localize "Roll"}}:</b> {{context.roll.roll}} - {{context.roll.result}}</div>
+    <div><b>{{localize "Roll"}}:</b> {{context.roll.roll}} - {{context.roll.name}}</div>
     {{/if}}
 
 

system.json

@@ -2,7 +2,7 @@
   "id": "wfrp4e",
   "title": "Warhammer Fantasy Roleplay 4th Edition",
   "description": "A comprehensive system for running grim and perilous games of Warhammer Fantasy Roleplay in the Foundry VTT environment.",
-  "version": "9.0.6",
+  "version": "9.1.0",
   "authors" : [
     {
       "name": "Moo Man",
@@ -63,15 +63,15 @@
     "requires": [{
       "id": "warhammer-lib",
       "type": "module",
-      "manifest": "https://raw.githubusercontent.com/moo-man/WarhammerLibrary-FVTT/2.0.4/module.json",
+      "manifest": "https://raw.githubusercontent.com/moo-man/WarhammerLibrary-FVTT/2.0.5/module.json",
       "compatibility": {
-        "minimum" : "2.0.4",
-        "verified": "2.0.4"
+        "minimum" : "2.0.5",
+        "verified": "2.0.5"
       }
     }]
   },
   "socket": true,
   "manifest" :  "https://github.com/moo-man/WFRP4e-FoundryVTT/releases/latest/download/system.json",
-  "download" :  "https://github.com/moo-man/WFRP4e-FoundryVTT/releases/download/9.0.6/wfrp4e.zip",
+  "download" :  "https://github.com/moo-man/WFRP4e-FoundryVTT/releases/download/9.1.0/wfrp4e.zip",
   "url" : "https://github.com/moo-man/WFRP4e-FoundryVTT"
 }