Polish.

Author: milesj

CHANGELOG.md

@@ -16,8 +16,8 @@
   extensive work, as the JavaScript ecosystem is quite unique. The following plugins are being
   introduced:
   - `unstable_javascript`
-    - A new JavaScript specific plugin that is a superset of all JavaScript runtimes (Deno coming
-      soon).
+    - A new JavaScript specific plugin that is a superset of all JavaScript runtimes (Bun & Node,
+      with Deno coming soon).
     - Implements tier 1 and 2 features, and is now in charge of defining the package manager,
       installing dependencies, extending the project graph (aliases and tasks), parsing
       lockfiles/manifests, and much more.

crates/actions/tests/sync_workspace_test.rs

@@ -69,7 +69,14 @@ mod sync_workspace {
 
         assert_eq!(
             ids,
-            ["tc-tier1", "tc-tier2", "tc-tier2-setup-env", "tc-tier3"]
+            [
+                "tc-tier1",
+                "tc-tier2",
+                "tc-tier2-reqs",
+                "tc-tier2-setup-env",
+                "tc-tier3",
+                "tc-tier3-reqs"
+            ]
         );
 
         // Verify operation and changed files

crates/cli/tests/snapshots/toolchain_info_test__toolchain_info__renders.snap

@@ -51,7 +51,6 @@ Configuration ──────────────────────
 Tier 1 - Usage detection ───────────────────────────────────
 
   Config files: tsconfig.json, tsconfig.*.json, *.tsconfig.json, .tsbuildinfo, *.tsbuildinfo
-  Executable names: tsc, tsserver
   APIs:
     🟢 register_toolchain (required)
     🟢 define_toolchain_config
@@ -72,7 +71,7 @@ Tier 2 - Platform integration ────────────────
     ⚫️ extend_task_script
     ⚫️ locate_dependencies_root
     ⚫️ install_dependencies
-    🟢 hash_task_contents
+    ⚫️ hash_task_contents
     ⚫️ parse_lock
     ⚫️ parse_manifest
     ⚫️ setup_environment

crates/project-builder/tests/project_builder_test.rs

@@ -226,15 +226,15 @@ mod project_builder {
             assert_eq!(project.language, LanguageType::JavaScript);
             assert_eq!(
                 project.toolchains,
-                vec![Id::raw("unstable_javascript"), Id::raw("unstable_bun")]
+                vec![Id::raw("unstable_bun"), Id::raw("unstable_javascript")]
             );
 
             let project = build_lang_project("bun-config").await;
 
             assert_eq!(project.language, LanguageType::JavaScript);
             assert_eq!(
                 project.toolchains,
-                vec![Id::raw("unstable_javascript"), Id::raw("unstable_bun")]
+                vec![Id::raw("unstable_bun"), Id::raw("unstable_javascript")]
             );
         }
 
@@ -374,7 +374,7 @@ mod project_builder {
             assert_eq!(project.language, LanguageType::Unknown);
             assert_eq!(
                 project.toolchains,
-                vec![Id::raw("typescript"), Id::raw("system")]
+                vec![Id::raw("system"), Id::raw("typescript")]
             );
 
             let project = build_lang_project("ts-disabled").await;

crates/project-graph/tests/project_graph_test.rs

@@ -1594,10 +1594,10 @@ mod project_graph {
             let graph = build_graph_from_fixture("query").await;
 
             let projects = graph
-                .query_projects(build_query("task=build && taskToolchain=deno").unwrap())
+                .query_projects(build_query("task=build && taskToolchain=system").unwrap())
                 .unwrap();
 
-            assert_eq!(get_ids_from_projects(projects), vec!["d"]);
+            assert_eq!(get_ids_from_projects(projects), vec!["a", "d"]);
         }
 
         #[tokio::test]

crates/workspace-graph/src/query_projects.rs

@@ -120,11 +120,17 @@ impl WorkspaceGraph {
                             .get_all_for_project(&project.id, false)?
                             .iter()
                             .any(|task| {
-                                let toolchains = task
-                                    .toolchains
-                                    .iter()
-                                    .map(|t| t.as_str())
-                                    .collect::<Vec<_>>();
+                                let mut toolchains = vec![];
+
+                                // Support stable and unstable IDs
+                                for id in &task.toolchains {
+                                    let (stable_id, unstable_id) = Id::stable_and_unstable(&id);
+                                    toolchains.push(stable_id);
+                                    toolchains.push(unstable_id);
+                                }
+
+                                let toolchains =
+                                    toolchains.iter().map(|t| t.as_str()).collect::<Vec<_>>();
 
                                 condition.matches_list(ids, &toolchains).unwrap_or_default()
                             })),