fix: Audit 07/27 (#2069)

* Fix unknown layer.

* Bump.

Author: milesj

.yarn/versions/3e67dece.yml

@@ -0,0 +1,9 @@
+releases:
+  "@moonrepo/cli": patch
+  "@moonrepo/core-linux-arm64-gnu": patch
+  "@moonrepo/core-linux-arm64-musl": patch
+  "@moonrepo/core-linux-x64-gnu": patch
+  "@moonrepo/core-linux-x64-musl": patch
+  "@moonrepo/core-macos-arm64": patch
+  "@moonrepo/core-macos-x64": patch
+  "@moonrepo/core-windows-x64-msvc": patch

CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## Unreleased
+
+#### 🐞 Fixes
+
+- Fixed a regression where an unknown/unconfigured `layer` would trigger a violation error.
+
 ## 1.39.2
 
 #### 🐞 Fixes

crates/project-constraints/src/lib.rs

@@ -73,6 +73,11 @@ pub fn enforce_layer_relationships(
         return Ok(());
     }
 
+    // Unknown layers can depend on anything, since we don't know what it is!
+    if source.layer == LayerType::Unknown {
+        return Ok(());
+    }
+
     let mut allowed = vec![];
     let mut found_layer = false;
 

crates/project-constraints/tests/constraints_test.rs

@@ -1,4 +1,5 @@
 use moon_common::Id;
+use moon_config::schematic::ConfigEnum;
 use moon_config::{DependencyScope, StackType};
 use moon_project::{LayerType, Project, ProjectConfig};
 use moon_project_constraints::{enforce_layer_relationships, enforce_tag_relationships};
@@ -438,6 +439,18 @@ mod by_layer {
         .unwrap();
     }
 
+    #[test]
+    fn unknown_can_use_everything() {
+        for layer in LayerType::variants() {
+            enforce_layer_relationships(
+                &create_project("foo", LayerType::Unknown),
+                &create_project("bar", layer),
+                &DependencyScope::Production,
+            )
+            .unwrap();
+        }
+    }
+
     mod config {
         use super::*;