Polish.

Author: milesj

CHANGELOG.md

@@ -32,6 +32,7 @@
   `notifier.terminalNotifications` setting in `.moon/workspace.yml`.
 - Added a `notifier.webhookAcknowledge` setting, that ensures webhooks resolve with a 2xx status
   code.
+- Updated project graph invalidation to take manifests from toolchain plugins into account.
 
 #### 🐞 Fixes
 

crates/plugin/src/plugin.rs

@@ -8,7 +8,8 @@ use warpgate::{Id, PluginContainer, PluginLocator};
 
 pub struct PluginRegistration {
     pub container: PluginContainer,
-    pub id: Id,
+    pub id: Id,        // unstable_foo
+    pub id_stable: Id, // foo
     pub locator: PluginLocator,
     pub moon_env: Arc<MoonEnvironment>,
     pub proto_env: Arc<ProtoEnvironment>,

crates/plugin/src/plugin_registry.rs

@@ -179,17 +179,15 @@ impl<T: Plugin> PluginRegistry<T> {
                 // expect a specific ID, for example "rust", and if we provide
                 // "unstable_rust", it breaks in weird ways.
                 let orig_id = entry.key().as_str();
-                let stable_id = orig_id.strip_prefix("unstable_").unwrap_or(orig_id);
+                let stable_id =
+                    PluginId::new(orig_id.strip_prefix("unstable_").unwrap_or(orig_id))?;
 
                 // Combine everything into the container and register
                 let plugin = T::new(PluginRegistration {
-                    container: PluginContainer::new(
-                        PluginId::new(stable_id)?,
-                        manifest,
-                        functions,
-                    )?,
+                    container: PluginContainer::new(stable_id.clone(), manifest, functions)?,
                     locator: locator.to_owned(),
                     id: entry.key().to_owned(),
+                    id_stable: stable_id,
                     moon_env: Arc::clone(&self.host_data.moon_env),
                     proto_env: Arc::clone(&self.host_data.proto_env),
                     wasm_file: plugin_file,

crates/task-runner/src/task_hashing.rs

@@ -222,12 +222,14 @@ async fn apply_toolchain_dependencies(
     let mut lock_files = vec![];
     let mut workspace_manifests = vec![];
     let mut project_manifests = vec![];
+    let has_parse_manifest = toolchain.has_func("parse_manifest").await;
+    let has_parse_lock = toolchain.has_func("parse_lock").await;
 
     // Load the project manifest
     for manifest_file_name in &toolchain.metadata.manifest_file_names {
         let manifest_path = project_root.join(manifest_file_name);
 
-        if toolchain.has_func("parse_manifest").await {
+        if manifest_path.exists() && has_parse_manifest {
             project_manifests.push(
                 toolchain
                     .parse_manifest(ParseManifestInput {
@@ -264,7 +266,7 @@ async fn apply_toolchain_dependencies(
 
             if lock_path.exists()
                 && app_context.workspace_config.hasher.optimization == HasherOptimization::Accuracy
-                && toolchain.has_func("parse_lock").await
+                && has_parse_lock
             {
                 lock_files.push(
                     toolchain
@@ -281,10 +283,7 @@ async fn apply_toolchain_dependencies(
         for manifest_file_name in &toolchain.metadata.manifest_file_names {
             let manifest_path = deps_root.join(manifest_file_name);
 
-            if manifest_path.exists()
-                && deps_root != project_root
-                && toolchain.has_func("parse_manifest").await
-            {
+            if manifest_path.exists() && deps_root != project_root && has_parse_manifest {
                 workspace_manifests.push(
                     toolchain
                         .parse_manifest(ParseManifestInput {
@@ -345,6 +344,7 @@ fn apply_toolchain_dependencies_by_manifest(
     );
 
     let mut inject = false;
+    let empty_deps = BTreeMap::new();
 
     for manifest in project_manifests {
         for (scope, project_deps) in [
@@ -355,7 +355,7 @@ fn apply_toolchain_dependencies_by_manifest(
         ] {
             if apply_toolchain_dependencies_by_scope(
                 project_deps,
-                workspace_deps.get(&scope).unwrap(),
+                workspace_deps.get(&scope).unwrap_or(&empty_deps),
                 &locked_deps,
                 hash_content,
             ) {

crates/toolchain-plugin/src/toolchain_plugin.rs

@@ -45,7 +45,7 @@ impl Plugin for ToolchainPlugin {
             tool: if plugin.has_func("register_tool").await {
                 Some(RwLock::new(
                     Tool::new(
-                        registration.id.clone(),
+                        registration.id_stable,
                         Arc::clone(&registration.proto_env),
                         Arc::clone(&plugin),
                     )

website/blog/2025-06-24_moon-v1.38.mdx

@@ -2,8 +2,8 @@
 slug: moon-v1.38
 title: moon v1.38 - Go WASM toolchain, MCP tools, terminal notifications, and more!
 authors: [milesj]
-tags: [toolchain, wasm, plugin, go, mcp, ai, webhooks]
-# image: ./img/moon/v1.38.png
+tags: [toolchain, wasm, plugin, go, mcp, ai, webhooks, terminal, notifications]
+image: ./img/moon/v1.38.png
 ---
 
 In this release, we're stoked to release the Go WASM toolchain plugin, and improved MCP/AI support!