Merge pull request #20 from mordachai/soundfx

new audio config and bug fixes

Author: mordachai

module.json

@@ -2,7 +2,7 @@
   "id": "investigation-board",
   "title": "Investigation Board",
   "description": "<p>A Foundry VTT module that lets everyone create, edit, and move sticky and photo notes on the scene as collaborative investigation tools.</p>",
-  "version": "4.1.1",
+  "version": "4.2.0",
   "socket": true,
   "authors": [
     {

scripts/canvas/connection-manager.js

@@ -628,27 +628,41 @@ export function onPinClick(event, drawing) {
 export function resetPinConnectionState() {
   pinConnectionFirstNote = null;
   if (pinConnectionHighlight) {
-    canvas.controls.removeChild(pinConnectionHighlight);
-    pinConnectionHighlight.destroy();
+    try {
+      if (!pinConnectionHighlight.destroyed) {
+        if (pinConnectionHighlight.parent) pinConnectionHighlight.parent.removeChild(pinConnectionHighlight);
+        pinConnectionHighlight.destroy();
+      }
+    } catch (err) {
+      console.warn("Investigation Board: Error destroying pin highlight", err);
+    }
     pinConnectionHighlight = null;
   }
   clearConnectionPreview();
 }
 
 export function cleanupConnectionLines() {
   if (connectionLinesContainer) {
-    if (connectionLinesContainer.parent) {
-      connectionLinesContainer.parent.removeChild(connectionLinesContainer);
+    try {
+      if (!connectionLinesContainer.destroyed) {
+        if (connectionLinesContainer.parent) connectionLinesContainer.parent.removeChild(connectionLinesContainer);
+        connectionLinesContainer.destroy({children: true, texture: false, baseTexture: false});
+      }
+    } catch (err) {
+      console.warn("Investigation Board: Error destroying lines container", err);
     }
-    connectionLinesContainer.destroy();
     connectionLinesContainer = null;
   }
 
   if (pinsContainer) {
-    if (pinsContainer.parent) {
-      pinsContainer.parent.removeChild(pinsContainer);
+    try {
+      if (!pinsContainer.destroyed) {
+        if (pinsContainer.parent) pinsContainer.parent.removeChild(pinsContainer);
+        pinsContainer.destroy({children: true});
+      }
+    } catch (err) {
+      console.warn("Investigation Board: Error destroying pins container", err);
     }
-    pinsContainer.destroy();
     pinsContainer = null;
   }
 }

scripts/utils/audio-utils.js

@@ -14,13 +14,13 @@ export function applyTapeEffect(context, inputNode, outputNode) {
   // Create High-pass filter (removes bass/lows for that tinny sound)
   const hpFilter = context.createBiquadFilter();
   hpFilter.type = "highpass";
-  hpFilter.frequency.value = 400; // Cut everything below 400Hz
+  hpFilter.frequency.value = 600; // Cut everything below 500Hz
   hpFilter.Q.value = 1;
 
   // Create Low-pass filter (removes very high frequencies to simulate tape degradation)
   const lpFilter = context.createBiquadFilter();
   lpFilter.type = "lowpass";
-  lpFilter.frequency.value = 4000; // Cut everything above 4000Hz
+  lpFilter.frequency.value = 2500; // Cut everything above 3000Hz
   lpFilter.Q.value = 1;
 
   // Create a Gain node to boost the signal slightly if it feels too quiet after filtering

scripts/utils/creation-utils.js

@@ -161,7 +161,7 @@ export async function createPhotoNoteFromActor(actor, isUnknown = false) {
   const height = Math.round(photoW / (225 / 290));
 
   const viewCenter = canvas.stage.pivot;
-  const x = viewCenter.x - width / 2;
+  const x = viewCenter.x - photoW / 2;
   const y = viewCenter.y - height / 2;
 
   const created = await collaborativeCreate({
@@ -214,7 +214,7 @@ export async function createPhotoNoteFromScene(targetScene) {
   const height = Math.round(photoW / (225 / 290));
 
   const viewCenter = canvas.stage.pivot;
-  const x = viewCenter.x - width / 2;
+  const x = viewCenter.x - photoW / 2;
   const y = viewCenter.y - height / 2;
 
   const displayName = targetScene.navName || targetScene.name || "Unknown Location";
@@ -276,8 +276,8 @@ export async function createHandoutNoteFromPage(page) {
   const handoutH = game.settings.get(MODULE_ID, "handoutNoteHeight") || 400;
 
   const viewCenter = canvas.stage.pivot;
-  const x = viewCenter.x - width / 2;
-  const y = viewCenter.y - height / 2;
+  const x = viewCenter.x - handoutW / 2;
+  const y = viewCenter.y - handoutH / 2;
 
   const imagePath = page.src || "modules/investigation-board/assets/newhandout.webp";
 
@@ -355,7 +355,7 @@ export async function createMediaNoteFromSound(sound) {
   const height = Math.round(mediaW * 0.74);
 
   const viewCenter = canvas.stage.pivot;
-  const x = viewCenter.x - width / 2;
+  const x = viewCenter.x - mediaW / 2;
   const y = viewCenter.y - height / 2;
 
   const imagePath = await _getRandomCassetteImage();