v5.8.2

Author: mordachai

module.json

@@ -2,7 +2,7 @@
   "id": "investigation-board",
   "title": "Investigation Board",
   "description": "<p>A Foundry VTT module that lets everyone create, edit, and move sticky and photo notes on the scene as collaborative investigation tools.</p>",
-  "version": "5.8.1",
+  "version": "5.8.2",
   "socket": true,
   "authors": [
     {
@@ -15,7 +15,9 @@
     "minimum": "14",
     "verified": "14"
   },
-  "esmodules": ["scripts/main.js"],
+  "esmodules": [
+    "scripts/main.js"
+  ],
   "styles": [
     {
       "src": "styles/style.css"
@@ -30,19 +32,23 @@
       "ownership": {
         "PLAYER": "OBSERVER",
         "ASSISTANT": "OWNER"
-      }
+      },
+      "flags": {}
     }
   ],
   "packFolders": [
     {
       "name": "Investigation Board",
       "sorting": "m",
       "color": "#061f6a",
-      "packs": ["ib-scenes"]
+      "packs": [
+        "ib-scenes"
+      ],
+      "folders": []
     }
   ],
   "url": "https://github.com/mordachai/investigation-board",
-  "manifest": "https://github.com/mordachai/investigation-board/releases/latest/download/module.json",
-  "download": "https://github.com/mordachai/investigation-board/releases/latest/download/module.zip",
+  "manifest": "https://github.com/mordachai/investigation-board/releases/download/v5.8.1/module.json",
+  "download": "https://github.com/mordachai/investigation-board/releases/download/v5.8.1/module.zip",
   "flags": {}
-}
+}

scripts/canvas/custom-drawing.js

@@ -1,7 +1,7 @@
 import { MODULE_ID, SOCKET_NAME, VIDEO_EXTENSIONS, DOC_BACKGROUNDS } from "../config.js";
 import { InvestigationBoardState } from "../state.js";
 import { collaborativeUpdate, collaborativeDelete, socket, activeGlobalSounds, activeVideoBroadcasts } from "../utils/socket-handler.js";
-import { truncateText, resolvePinImage, getAvailablePinFiles, resolveStampImage, getAvailableStampFiles } from "../utils/helpers.js";
+import { truncateText, resolvePinImage, getAvailablePinFiles, pickPinFileForDrawing, resolveStampImage, getAvailableStampFiles } from "../utils/helpers.js";
 import { NotePreviewer } from "../apps/note-previewer.js";
 import { VideoPlayer } from "../apps/video-player.js";
 import { drawAllConnectionLines, beginConnectionFrom, resetPinConnectionState } from "./connection-manager.js";
@@ -940,9 +940,10 @@ export class CustomDrawing extends Drawing {
    *
    * The global "pinColor" setting controls visibility:
    *   "none"   → destroy any existing sprite and bail out.
-   *   "random" → pick a random image from the pin folder on first render,
-   *              persist the choice to the note's flags so every client
-   *              shows the same pin.
+   *   "random" → deterministically pick an image from the pin folder based
+   *              on the drawing ID (same result on every client); the GM
+   *              client persists the choice to the note's flags so it stays
+   *              stable even if the folder contents later change.
    *
    * The per-note flag `noteData.pinColor` stores the bare filename
    * (e.g. "redPin.webp").  resolvePinImage() prepends the configured
@@ -971,9 +972,16 @@ export class CustomDrawing extends Drawing {
 
     let pinFilename = noteData.pinColor;
     if (!pinFilename) {
+      // Deterministic "random": hash the drawing ID into the sorted file list
+      // so every client resolves the same pin without waiting on a flag write.
       const files = await getAvailablePinFiles();
-      pinFilename = files[Math.floor(Math.random() * files.length)];
-      await collaborativeUpdate(this.document.id, { [`flags.${MODULE_ID}.pinColor`]: pinFilename });
+      pinFilename = pickPinFileForDrawing(this.document.id, files);
+      if (!pinFilename) return;
+      // Persist from the GM client only — avoids N clients racing to write
+      // different values through the socket on first render.
+      if (game.user.isGM) {
+        await collaborativeUpdate(this.document.id, { [`flags.${MODULE_ID}.pinColor`]: pinFilename });
+      }
     }
 
     const pinImage = resolvePinImage(pinFilename);

scripts/utils/helpers.js

@@ -48,17 +48,36 @@ export async function getAvailablePinFiles() {
     const result = await FilePicker.browse("data", folder);
     _pinFilesCache = result.files
       .filter(f => /\.(webp|png)$/i.test(f))
-      .map(f => f.split("/").pop());
+      .map(f => f.split("/").pop())
+      .sort();
     _pinFolderCache = folder;
   } catch {
     // No FILES_BROWSE permission or folder doesn't exist — use built-in list
-    _pinFilesCache = [...PIN_COLORS];
+    _pinFilesCache = [...PIN_COLORS].sort();
     _pinFolderCache = folder;
   }
 
   return _pinFilesCache;
 }
 
+/**
+ * Deterministically pick a pin file for a drawing so every client resolves
+ * the same "random" pin without needing a flag write to land first.
+ * Hashes the drawing ID into an index over the sorted file list.
+ *
+ * @param {string} drawingId
+ * @param {string[]} files  Sorted list of bare filenames
+ * @returns {string|undefined}
+ */
+export function pickPinFileForDrawing(drawingId, files) {
+  if (!files?.length) return undefined;
+  let hash = 0;
+  for (let i = 0; i < drawingId.length; i++) {
+    hash = (hash * 31 + drawingId.charCodeAt(i)) >>> 0;
+  }
+  return files[hash % files.length];
+}
+
 // ---------------------------------------------------------------------------
 // Stamp image helpers
 // ---------------------------------------------------------------------------