-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathhydration.go
More file actions
603 lines (545 loc) · 17.4 KB
/
Copy pathhydration.go
File metadata and controls
603 lines (545 loc) · 17.4 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
package app
import (
"context"
"encoding/json"
"errors"
"fmt"
"time"
"github.com/morluto/gitcontribute/internal/cli"
"github.com/morluto/gitcontribute/internal/corpus"
"github.com/morluto/gitcontribute/internal/domain"
"github.com/morluto/gitcontribute/internal/github"
)
// Thread facets that selective hydration can retrieve.
const (
FacetIssueComments = "issue_comments"
FacetPRDetails = "pr_details"
FacetPRReviews = "pr_reviews"
FacetPRReviewComments = "pr_review_comments"
FacetPRChecks = "pr_checks"
FacetPRReviewThreads = "pr_review_threads"
FacetPRMergeState = "pr_merge_state"
FacetPRMergeQueue = "pr_merge_queue"
FacetPRClosingIssues = "pr_closing_issues"
FacetPRFiles = "pr_files"
FacetIssueTimeline = "issue_timeline"
)
var issueFacets = []string{FacetIssueComments}
var pullRequestFacets = []string{FacetIssueComments, FacetPRDetails, FacetPRReviews, FacetPRReviewComments}
const maxHydrationPages = 100
// HydrateResult reports the outcome of hydrating a thread.
type HydrateResult struct {
Repo cli.RepoRef
Number int
Kind string
Facets []HydratedFacet
Pages int
Requests int
Capped bool
Message string
}
// HydratedFacet reports coverage and counts for one hydrated facet.
type HydratedFacet struct {
Facet string
Count int
Pages int
Complete bool
}
// HydrateOptions controls selective thread hydration.
type HydrateOptions struct {
// Facets lists the facets to retrieve. An empty list hydrates all facets
// applicable to the thread kind.
Facets []string
// MaxPages bounds pagination per facet. Zero defaults to 50.
MaxPages int
}
// HydrateThread fetches the requested facets for an issue or pull request and
// stores immutable facet observations. It is explicit, bounded, paginated,
// cancellation-aware, and records independent facet coverage plus run
// completion/failure statistics.
func (s *Service) HydrateThread(ctx context.Context, repo cli.RepoRef, number int, opts HydrateOptions) (*HydrateResult, error) {
ref := domain.RepoRef{Owner: repo.Owner, Repo: repo.Repo}
if err := ref.Validate(); err != nil {
return nil, err
}
if number <= 0 {
return nil, errors.New("thread number must be positive")
}
c, err := s.openCorpus(ctx)
if err != nil {
return nil, err
}
reader, err := s.githubReader()
if err != nil {
return nil, err
}
run, err := c.StartRun(ctx, "hydrate")
if err != nil {
return nil, err
}
var hydrateErr error
defer func() {
if hydrateErr == nil {
return
}
cleanupCtx, cancel := context.WithTimeout(context.WithoutCancel(ctx), 5*time.Second)
defer cancel()
_ = c.FailRun(cleanupCtx, run.ID, hydrateErr.Error())
}()
repoProjection, err := c.GetRepository(ctx, ref.Owner, ref.Repo)
if err != nil {
hydrateErr = fmt.Errorf("get repository: %w", err)
return nil, hydrateErr
}
if repoProjection == nil {
hydrateErr = fmt.Errorf("repository %s has not been synced", ref)
return nil, hydrateErr
}
thread, err := c.GetThreadByNumber(ctx, repoProjection.ID, number)
if err != nil {
hydrateErr = fmt.Errorf("get thread: %w", err)
return nil, hydrateErr
}
if thread == nil {
hydrateErr = fmt.Errorf("thread %s#%d has not been synced", ref, number)
return nil, hydrateErr
}
if err := c.RecordRunEvent(ctx, run.ID, "info", fmt.Sprintf("hydrating %s#%d (%s)", ref, number, thread.Kind)); err != nil {
hydrateErr = err
return nil, hydrateErr
}
facets, err := selectFacets(thread.Kind, opts.Facets)
if err != nil {
hydrateErr = err
return nil, hydrateErr
}
maxPages := opts.MaxPages
if maxPages <= 0 {
maxPages = 50
}
if maxPages > maxHydrationPages {
hydrateErr = fmt.Errorf("max pages cannot exceed %d", maxHydrationPages)
return nil, hydrateErr
}
result := &HydrateResult{
Repo: repo,
Number: number,
Kind: thread.Kind,
Facets: make([]HydratedFacet, 0, len(facets)),
}
for _, facet := range facets {
if err := ctx.Err(); err != nil {
hydrateErr = err
return nil, hydrateErr
}
f := &facetRunner{
ctx: ctx,
c: c,
reader: reader,
ref: ref,
thread: thread,
repoID: repoProjection.ID,
threadID: thread.ID,
runID: run.ID,
maxPages: maxPages,
}
var facetResult HydratedFacet
switch facet {
case FacetIssueComments:
facetResult, err = f.hydrateIssueComments()
case FacetPRDetails:
facetResult, err = f.hydratePullRequestDetails()
case FacetPRReviews:
facetResult, err = f.hydratePullRequestReviews()
case FacetPRReviewComments:
facetResult, err = f.hydratePullRequestReviewComments()
case FacetIssueTimeline:
facetResult, err = f.hydrateIssueTimeline()
default:
hydrateErr = fmt.Errorf("unknown facet %q", facet)
return nil, hydrateErr
}
if err != nil {
hydrateErr = fmt.Errorf("hydrate %s: %w", facet, err)
return nil, hydrateErr
}
result.Facets = append(result.Facets, facetResult)
result.Pages += facetResult.Pages
result.Requests += facetResult.Pages
}
statsPayload, _ := json.Marshal(map[string]any{
"facets": len(result.Facets),
"pages": result.Pages,
"requests": result.Requests,
})
if err := c.FinishRun(ctx, run.ID, string(statsPayload)); err != nil {
hydrateErr = err
return nil, hydrateErr
}
result.Message = fmt.Sprintf("hydrated %d facets for %s#%d", len(result.Facets), ref, number)
return result, nil
}
func selectFacets(kind string, requested []string) ([]string, error) {
var allowed []string
switch kind {
case corpus.ThreadKindIssue:
allowed = issueFacets
case corpus.ThreadKindPullRequest:
allowed = pullRequestFacets
default:
return nil, fmt.Errorf("unknown thread kind %q", kind)
}
if len(requested) == 0 {
return allowed, nil
}
// Timeline history is intentionally opt-in because it can be much larger
// than the default hydration set.
allowed = append(append([]string(nil), allowed...), FacetIssueTimeline)
allowedSet := make(map[string]struct{}, len(allowed))
for _, f := range allowed {
allowedSet[f] = struct{}{}
}
out := make([]string, 0, len(requested))
seen := make(map[string]struct{}, len(requested))
for _, f := range requested {
if _, ok := allowedSet[f]; !ok {
return nil, fmt.Errorf("facet %q is not applicable to %s threads", f, kind)
}
if _, ok := seen[f]; ok {
continue
}
seen[f] = struct{}{}
out = append(out, f)
}
return out, nil
}
func (f *facetRunner) hydrateIssueTimeline() (HydratedFacet, error) {
reader, ok := f.reader.(github.IssueTimelineReader)
if !ok {
return HydratedFacet{}, errors.New("GitHub reader does not support issue timelines")
}
opts := github.PageOptions{Page: 1, PerPage: 100}
var total, pages int
var complete bool
var pageObservations []corpus.FacetObservationInput
sourceUpdatedAt := f.thread.SourceUpdatedAt
var events []github.IssueTimelineEvent
for pages < f.maxPages {
if err := f.ctx.Err(); err != nil {
return HydratedFacet{}, err
}
res, err := reader.ListIssueTimeline(f.ctx, f.ref.Owner, f.ref.Repo, f.thread.Number, opts)
if err != nil {
return HydratedFacet{}, err
}
pages++
pageUpdatedAt := sourceUpdatedAt
for _, event := range res.Items {
if event.CreatedAt.After(pageUpdatedAt) {
pageUpdatedAt = event.CreatedAt
}
}
payload, err := json.Marshal(res.Items)
if err != nil {
return HydratedFacet{}, fmt.Errorf("marshal issue timeline: %w", err)
}
pageObservations = append(pageObservations, corpus.FacetObservationInput{SourceUpdatedAt: pageUpdatedAt, Payload: string(payload)})
events = append(events, res.Items...)
total += len(res.Items)
if pageUpdatedAt.After(sourceUpdatedAt) {
sourceUpdatedAt = pageUpdatedAt
}
if !res.Page.HasNext {
complete = true
break
}
opts.Page = res.Page.NextPage
}
if !complete {
if err := f.c.AdvanceFacet(f.ctx, f.repoID, &f.threadID, FacetIssueTimeline, sourceUpdatedAt, false, f.runID); err != nil {
return HydratedFacet{}, err
}
return HydratedFacet{Facet: FacetIssueTimeline, Count: total, Pages: pages, Complete: false}, nil
}
if err := f.c.ApplyFacetObservationSet(f.ctx, f.repoID, &f.threadID, FacetIssueTimeline, sourceUpdatedAt, pageObservations, true, f.runID); err != nil {
return HydratedFacet{}, err
}
coverage, err := f.c.GetCoverage(f.ctx, f.repoID, &f.threadID, FacetIssueTimeline)
if err != nil {
return HydratedFacet{}, err
}
if coverage == nil || !coverage.Complete || !coverage.SourceUpdatedAt.Equal(sourceUpdatedAt.Truncate(time.Second)) {
// A newer stored snapshot won the stale-write comparison. Do not attach
// this older derivation to that snapshot's observation identities.
return HydratedFacet{Facet: FacetIssueTimeline, Count: total, Pages: pages, Complete: true}, nil
}
if err := f.persistTimelineResolution(events, sourceUpdatedAt); err != nil {
return HydratedFacet{}, err
}
return HydratedFacet{Facet: FacetIssueTimeline, Count: total, Pages: pages, Complete: true}, nil
}
func (f *facetRunner) persistTimelineResolution(events []github.IssueTimelineEvent, sourceUpdatedAt time.Time) error {
kind, summary := "", ""
selectedCommit := ""
if f.thread.StateReason == "not_planned" {
kind, summary = "not_planned", "GitHub records this issue as closed without planned work."
}
for _, event := range events {
if event.Event == "closed" && event.CommitID != "" {
kind, summary = "fixed_by_commit", "GitHub records an explicit closing commit: "+event.CommitID
selectedCommit = event.CommitID
}
}
if kind == "" {
return nil
}
var refs []corpus.ObservationRef
if selectedCommit == "" {
observation, err := f.c.GetThreadObservationRevision(f.ctx, f.threadID, f.thread.SourceUpdatedAt, f.thread.ObservationSequence)
if err != nil {
return err
}
refs = []corpus.ObservationRef{{Kind: "thread", ID: observation.ID}}
} else {
observations, _, err := f.c.ListFacetObservationsBounded(f.ctx, f.repoID, &f.threadID, FacetIssueTimeline, 100)
if err != nil {
return err
}
for _, observation := range observations {
var page []github.IssueTimelineEvent
if err := json.Unmarshal([]byte(observation.Payload), &page); err != nil {
return fmt.Errorf("decode issue timeline provenance: %w", err)
}
for _, event := range page {
if event.Event == "closed" && event.CommitID == selectedCommit {
refs = append(refs, corpus.ObservationRef{Kind: "facet", ID: observation.ID})
break
}
}
}
if len(refs) == 0 {
return errors.New("closing commit timeline observation is unavailable")
}
}
_, err := f.c.SaveResolutionRecord(f.ctx, corpus.ResolutionRecord{ThreadID: f.threadID, Kind: kind, Summary: summary, RuleVersion: "resolution.v1", SourceUpdatedAt: sourceUpdatedAt, SourceObservationRefs: refs})
return err
}
type facetRunner struct {
ctx context.Context
c *corpus.Corpus
reader github.Reader
ref domain.RepoRef
thread *corpus.Thread
repoID int64
threadID int64
runID int64
maxPages int
}
func (f *facetRunner) hydrateIssueComments() (HydratedFacet, error) {
opts := github.PageOptions{Page: 1, PerPage: 100}
var total, pages int
var complete bool
var pageObservations []corpus.FacetObservationInput
sourceUpdatedAt := f.thread.SourceUpdatedAt
for {
if pages >= f.maxPages {
break
}
if err := f.ctx.Err(); err != nil {
return HydratedFacet{}, err
}
res, err := f.reader.ListIssueComments(f.ctx, f.ref.Owner, f.ref.Repo, f.thread.Number, opts)
if err != nil {
return HydratedFacet{}, err
}
pages++
pageUpdated := latestFromIssueComments(res.Items)
if pageUpdated.IsZero() {
pageUpdated = f.thread.SourceUpdatedAt
}
if pageUpdated.After(sourceUpdatedAt) {
sourceUpdatedAt = pageUpdated
}
payload, err := json.Marshal(res.Items)
if err != nil {
return HydratedFacet{}, fmt.Errorf("marshal issue comments: %w", err)
}
pageObservations = append(pageObservations, corpus.FacetObservationInput{
SourceUpdatedAt: pageUpdated,
Payload: string(payload),
})
total += len(res.Items)
if !res.Page.HasNext {
complete = true
break
}
opts.Page = res.Page.NextPage
}
if err := f.ctx.Err(); err != nil {
return HydratedFacet{}, err
}
if !complete {
if err := f.c.AdvanceFacet(f.ctx, f.repoID, &f.threadID, FacetIssueComments, sourceUpdatedAt, false, f.runID); err != nil {
return HydratedFacet{}, err
}
return HydratedFacet{Facet: FacetIssueComments, Count: total, Pages: pages, Complete: false}, nil
}
if err := f.c.ApplyFacetObservationSet(f.ctx, f.repoID, &f.threadID, FacetIssueComments, sourceUpdatedAt, pageObservations, true, f.runID); err != nil {
return HydratedFacet{}, err
}
return HydratedFacet{Facet: FacetIssueComments, Count: total, Pages: pages, Complete: complete}, nil
}
func (f *facetRunner) hydratePullRequestDetails() (HydratedFacet, error) {
pr, _, err := f.reader.GetPullRequestDetails(f.ctx, f.ref.Owner, f.ref.Repo, f.thread.Number)
if err != nil {
return HydratedFacet{}, err
}
payload, err := json.Marshal(pr)
if err != nil {
return HydratedFacet{}, fmt.Errorf("marshal pr details: %w", err)
}
updatedAt := pr.UpdatedAt
if updatedAt.IsZero() {
updatedAt = f.thread.SourceUpdatedAt
}
pages := []corpus.FacetObservationInput{{SourceUpdatedAt: updatedAt, Payload: string(payload)}}
if err := f.c.ApplyFacetObservationSet(f.ctx, f.repoID, &f.threadID, FacetPRDetails, updatedAt, pages, true, f.runID); err != nil {
return HydratedFacet{}, err
}
return HydratedFacet{Facet: FacetPRDetails, Count: 1, Pages: 1, Complete: true}, nil
}
func (f *facetRunner) hydratePullRequestReviews() (HydratedFacet, error) {
opts := github.PageOptions{Page: 1, PerPage: 100}
var total, pages int
var complete bool
var pageObservations []corpus.FacetObservationInput
sourceUpdatedAt := f.thread.SourceUpdatedAt
for {
if pages >= f.maxPages {
break
}
if err := f.ctx.Err(); err != nil {
return HydratedFacet{}, err
}
res, err := f.reader.ListPullRequestReviews(f.ctx, f.ref.Owner, f.ref.Repo, f.thread.Number, opts)
if err != nil {
return HydratedFacet{}, err
}
pages++
pageUpdated := latestFromReviews(res.Items)
if pageUpdated.IsZero() {
pageUpdated = f.thread.SourceUpdatedAt
}
if pageUpdated.After(sourceUpdatedAt) {
sourceUpdatedAt = pageUpdated
}
payload, err := json.Marshal(res.Items)
if err != nil {
return HydratedFacet{}, fmt.Errorf("marshal pr reviews: %w", err)
}
pageObservations = append(pageObservations, corpus.FacetObservationInput{
SourceUpdatedAt: pageUpdated,
Payload: string(payload),
})
total += len(res.Items)
if !res.Page.HasNext {
complete = true
break
}
opts.Page = res.Page.NextPage
}
if err := f.ctx.Err(); err != nil {
return HydratedFacet{}, err
}
if !complete {
if err := f.c.AdvanceFacet(f.ctx, f.repoID, &f.threadID, FacetPRReviews, sourceUpdatedAt, false, f.runID); err != nil {
return HydratedFacet{}, err
}
return HydratedFacet{Facet: FacetPRReviews, Count: total, Pages: pages, Complete: false}, nil
}
if err := f.c.ApplyFacetObservationSet(f.ctx, f.repoID, &f.threadID, FacetPRReviews, sourceUpdatedAt, pageObservations, true, f.runID); err != nil {
return HydratedFacet{}, err
}
return HydratedFacet{Facet: FacetPRReviews, Count: total, Pages: pages, Complete: complete}, nil
}
func (f *facetRunner) hydratePullRequestReviewComments() (HydratedFacet, error) {
opts := github.PageOptions{Page: 1, PerPage: 100}
var total, pages int
var complete bool
var pageObservations []corpus.FacetObservationInput
sourceUpdatedAt := f.thread.SourceUpdatedAt
for {
if pages >= f.maxPages {
break
}
if err := f.ctx.Err(); err != nil {
return HydratedFacet{}, err
}
res, err := f.reader.ListPullRequestComments(f.ctx, f.ref.Owner, f.ref.Repo, f.thread.Number, opts)
if err != nil {
return HydratedFacet{}, err
}
pages++
pageUpdated := latestFromReviewComments(res.Items)
if pageUpdated.IsZero() {
pageUpdated = f.thread.SourceUpdatedAt
}
if pageUpdated.After(sourceUpdatedAt) {
sourceUpdatedAt = pageUpdated
}
payload, err := json.Marshal(res.Items)
if err != nil {
return HydratedFacet{}, fmt.Errorf("marshal pr review comments: %w", err)
}
pageObservations = append(pageObservations, corpus.FacetObservationInput{
SourceUpdatedAt: pageUpdated,
Payload: string(payload),
})
total += len(res.Items)
if !res.Page.HasNext {
complete = true
break
}
opts.Page = res.Page.NextPage
}
if err := f.ctx.Err(); err != nil {
return HydratedFacet{}, err
}
if !complete {
if err := f.c.AdvanceFacet(f.ctx, f.repoID, &f.threadID, FacetPRReviewComments, sourceUpdatedAt, false, f.runID); err != nil {
return HydratedFacet{}, err
}
return HydratedFacet{Facet: FacetPRReviewComments, Count: total, Pages: pages, Complete: false}, nil
}
if err := f.c.ApplyFacetObservationSet(f.ctx, f.repoID, &f.threadID, FacetPRReviewComments, sourceUpdatedAt, pageObservations, true, f.runID); err != nil {
return HydratedFacet{}, err
}
return HydratedFacet{Facet: FacetPRReviewComments, Count: total, Pages: pages, Complete: complete}, nil
}
func latestFromIssueComments(items []github.IssueComment) time.Time {
var latest time.Time
for _, c := range items {
if c.UpdatedAt.After(latest) {
latest = c.UpdatedAt
}
}
return latest
}
func latestFromReviews(items []github.Review) time.Time {
var latest time.Time
for _, r := range items {
if r.SubmittedAt.After(latest) {
latest = r.SubmittedAt
}
}
return latest
}
func latestFromReviewComments(items []github.ReviewComment) time.Time {
var latest time.Time
for _, c := range items {
if c.UpdatedAt.After(latest) {
latest = c.UpdatedAt
}
}
return latest
}