Skip to content

Commit 2efd172

Browse files
author
Grace Lee Rui Yue
committed
fix(skills): correct determinant verifier payload
1 parent f491a3f commit 2efd172

3 files changed

Lines changed: 22 additions & 3 deletions

File tree

.agents/skills/jacobian-math/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ Payloads:
3535
- For expression normalization, inspect the known
3636
`polynomial.expression.normalize` contract directly.
3737
- `matrix.determinant.verify` for an independent check:
38-
`{"determinant_uri":"<determinant_uri from compute output>"}`.
38+
`{"input":<same determinant payload>,"candidate":<producer output.result>}`.
3939
- `combinatorics.cyclic_difference_set.extension.decide`:
4040
`{"base_elements":["1","2","4","8","13"],"target_order":7}`.
4141
`combinatorics.cyclic_difference_set.extension.verify` uses

npm/skills/jacobian-math/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ Payloads:
3535
- For expression normalization, inspect the known
3636
`polynomial.expression.normalize` contract directly.
3737
- `matrix.determinant.verify` for an independent check:
38-
`{"determinant_uri":"<determinant_uri from compute output>"}`.
38+
`{"input":<same determinant payload>,"candidate":<producer output.result>}`.
3939
- `combinatorics.cyclic_difference_set.extension.decide`:
4040
`{"base_elements":["1","2","4","8","13"],"target_order":7}`.
4141
`combinatorics.cyclic_difference_set.extension.verify` uses

tests/unit/tooling/test_codex_visibility.py

Lines changed: 20 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,14 @@
2323

2424
from jacobian.adapters.mcp.tools import capability_invoke
2525
from jacobian.contracts.combinatorics import CyclicDifferenceSetExtensionRequest
26-
from jacobian.contracts.matrix_operations import MatrixDeterminantRequest
26+
from jacobian.contracts.matrix_operations import (
27+
MatrixDeterminantRequest,
28+
MatrixDeterminantResult,
29+
)
2730
from jacobian.contracts.number_theory import IntegerPairRequest
2831
from jacobian.contracts.polynomial_operations import PolynomialGcdRequest
2932
from jacobian.eval.telemetry import parse_agent_transcript
33+
from jacobian.exact_domain_checkers import ExactComputedVerificationRequest
3034

3135
_ROOT = Path(__file__).resolve().parents[3]
3236

@@ -181,6 +185,18 @@ def test_codex_skill_keeps_bounded_stable_direct_run_contracts() -> None:
181185
assert polynomial in skill
182186
extension_payload = '{"base_elements":["1","2","4","8","13"],"target_order":7}'
183187
assert extension_payload in skill
188+
determinant_verify_payload = {
189+
"input": json.loads(matrix_payload),
190+
"candidate": {
191+
"determinant": {"num": "1", "den": "1"},
192+
"method": "FRACTION_FREE_BAREISS",
193+
},
194+
}
195+
assert (
196+
'`{"input":<same determinant payload>,'
197+
'"candidate":<producer output.result>}`' in skill
198+
)
199+
assert "determinant_uri" not in skill
184200
run_parameters = signature(capability_invoke).parameters
185201
assert tuple(run_parameters) == ("capability_id", "payload", "ctx")
186202
assert run_parameters["ctx"].kind is Parameter.KEYWORD_ONLY
@@ -192,6 +208,9 @@ def test_codex_skill_keeps_bounded_stable_direct_run_contracts() -> None:
192208
assert '"candidate":<producer output.result>' in skill
193209
IntegerPairRequest.model_validate_json(integer_payload)
194210
MatrixDeterminantRequest.model_validate_json(matrix_payload)
211+
ExactComputedVerificationRequest[
212+
MatrixDeterminantRequest, MatrixDeterminantResult
213+
].model_validate(determinant_verify_payload)
195214
polynomial_value = json.loads(polynomial)
196215
PolynomialGcdRequest.model_validate(
197216
{"left": polynomial_value, "right": polynomial_value}

0 commit comments

Comments
 (0)