refactor(portfolio): remove package re-export facade (#1313)

Author: morluto

src/jacobian/composition.py

@@ -5,7 +5,7 @@
 from pathlib import Path
 
 from jacobian.installation.context import create_installation_context
-from jacobian.portfolio import install_portfolio
+from jacobian.portfolio.assembler import install_portfolio
 from jacobian.runtime.bootstrap import bootstrap_services
 from jacobian.runtime.config import RuntimeOptions
 from jacobian.runtime.model import JacobianRuntime

src/jacobian/portfolio/__init__.py

@@ -1,23 +1,3 @@
-"""Explicit mathematical portfolio installation."""
+"""Internal owners for explicit mathematical portfolio installation."""
 
-from jacobian.portfolio.assembler import install_portfolio
-from jacobian.portfolio.builtin import build_builtin_portfolio
-from jacobian.portfolio.model import PortfolioPlan
-from jacobian.portfolio.result import (
-    PROVIDER_UNAVAILABLE,
-    BundleInstallation,
-    BundleInstallationStatus,
-    PortfolioDiagnostic,
-    PortfolioInstallationResult,
-)
-
-__all__ = [
-    "PROVIDER_UNAVAILABLE",
-    "BundleInstallation",
-    "BundleInstallationStatus",
-    "PortfolioDiagnostic",
-    "PortfolioInstallationResult",
-    "PortfolioPlan",
-    "build_builtin_portfolio",
-    "install_portfolio",
-]
+__all__: tuple[str, ...] = ()

tests/boundary/process/public_api/test_import_isolation.py

@@ -71,6 +71,43 @@ def test_runtime_assembly_does_not_import_packaged_backends(tmp_path: Path) -> N
     assert completed.returncode == 0, completed.stderr
 
 
+def test_portfolio_leaf_import_does_not_load_assembly_or_domains() -> None:
+    _assert_not_imported(
+        _imported_modules("jacobian.portfolio.provider_resolution"),
+        (
+            "jacobian.domains",
+            "jacobian.portfolio.assembler",
+            "jacobian.portfolio.builtin",
+            "jacobian.runtime",
+        ),
+    )
+
+
+def test_portfolio_root_is_an_import_transparent_internal_namespace() -> None:
+    script = """
+import jacobian.portfolio as portfolio
+import sys
+
+assert portfolio.__all__ == ()
+assert not hasattr(portfolio, "PortfolioPlan")
+assert not hasattr(portfolio, "install_portfolio")
+children = sorted(
+    name for name in sys.modules if name.startswith("jacobian.portfolio.")
+)
+if children:
+    raise AssertionError(f"portfolio root imported child modules: {children}")
+"""
+    completed = subprocess.run(
+        [sys.executable, "-c", script],
+        check=False,
+        capture_output=True,
+        env={**os.environ, "SYMPY_GROUND_TYPES": "python"},
+        text=True,
+    )
+
+    assert completed.returncode == 0, completed.stderr
+
+
 def test_native_matrices_does_not_import_capabilities_or_provider_loading() -> None:
     _assert_not_imported(
         _imported_modules("jacobian.math.matrices"),

tests/composition/portfolio/test_builtin_portfolio_installation.py

@@ -8,7 +8,7 @@
 from jacobian.domains.polynomial_nullstellensatz.singular import (
     PRODUCE_CAPABILITY_ID,
 )
-from jacobian.portfolio import build_builtin_portfolio
+from jacobian.portfolio.builtin import build_builtin_portfolio
 from jacobian.providers.singular_runtime import singular_provider_runtime
 from jacobian.runtime.model import JacobianRuntime
 

tests/composition/portfolio/test_portfolio_assembler.py

@@ -34,9 +34,10 @@
     DomainSemantics,
     OperationSpec,
 )
-from jacobian.portfolio import PROVIDER_UNAVAILABLE, PortfolioPlan
 from jacobian.portfolio.domain_installation import DomainBundleInstaller
+from jacobian.portfolio.model import PortfolioPlan
 from jacobian.portfolio.result import (
+    PROVIDER_UNAVAILABLE,
     BundleInstallationStatus,
     PortfolioInstallationResult,
 )

tests/composition/portfolio/test_portfolio_plan.py

@@ -5,8 +5,11 @@
 import pytest
 
 from jacobian.domain_bundles import DomainBundle
-from jacobian.portfolio import PortfolioPlan, build_builtin_portfolio
-from jacobian.portfolio.builtin import build_builtin_portfolio_components
+from jacobian.portfolio.builtin import (
+    build_builtin_portfolio,
+    build_builtin_portfolio_components,
+)
+from jacobian.portfolio.model import PortfolioPlan
 
 
 def test_builtin_portfolio_is_an_explicit_plan_of_components() -> None:

tests/composition/runtime/test_portfolio_installation.py

@@ -3,7 +3,7 @@
 from contextlib import nullcontext
 from types import SimpleNamespace
 
-from jacobian.portfolio import assembler
+import jacobian.portfolio.assembler as assembler
 from jacobian.runtime.portfolio import PortfolioResources
 
 

tests/unit/portfolio/test_portfolio_installation_phases.py

@@ -8,14 +8,14 @@
 
 import pytest
 
+import jacobian.portfolio.foundation_installation as foundation_installation
 from jacobian.contracts.capabilities import (
     CapabilityInstallTier,
     CapabilityProviderAvailability,
     CapabilityProviderDigestKind,
     CapabilityProviderRuntime,
 )
 from jacobian.installation.context import InstallationContext
-from jacobian.portfolio import foundation_installation
 from jacobian.portfolio.checker_installation import CheckerPortfolioInstaller
 from jacobian.portfolio.core_installation import CoreApplicationInstaller
 from jacobian.portfolio.foundation_installation import FoundationInstaller

tests/unit/portfolio/test_portfolio_provider_resolution.py

@@ -6,12 +6,12 @@
 
 import pytest
 
+import jacobian.portfolio.provider_resolution as provider_resolution
 from jacobian.contracts.capabilities import (
     CapabilityInstallTier,
     CapabilityProviderAvailability,
     CapabilityProviderRuntime,
 )
-from jacobian.portfolio import provider_resolution
 from jacobian.portfolio.provider_resolution import ProviderAvailabilityResolver
 from jacobian.provider_runtime import ProviderRuntimeError, known_provider_runtime
 

tools/check_test_architecture.py

@@ -22,10 +22,9 @@
 
 _TEST_FILE = "test_*.py"
 
-# These are deliberately narrow names.  Importing a typed domain model from
-# ``jacobian.portfolio`` is fine; importing the explicit built-in plan or its
-# complete installer is the operation that couples a lower tier to the whole
-# application.
+# These are deliberately narrow names. Typed portfolio models come from their
+# concrete owner modules; importing the built-in plan or assembler is the
+# operation that couples a lower tier to the whole application.
 _BUILTIN_PORTFOLIO_NAMES = frozenset(
     {
         "BUILTIN_PORTFOLIO",