fix(pre-commit): remove stale verifier-support hook

Author: morluto

.pre-commit-config.yaml

@@ -37,13 +37,6 @@ repos:
 
   - repo: local
     hooks:
-      - id: jacobian-harbor-verifier-support
-        name: Jacobian Harbor verifier-support generation check
-        entry: uv run --locked python tools/sync_harbor_verifier_support.py --check
-        language: system
-        pass_filenames: false
-        files: ^(benchmarks/tooling/verifier_support\.py|benchmarks/datasets/.*/tests/verifier_support\.py)$
-        stages: [pre-commit]
       - id: jacobian-pre-push
         name: Jacobian pre-push static checks
         # Keep the push hook below the interactive feedback budget.  The

tests/unit/tooling/test_ci_execution_policy.py

@@ -1,8 +1,17 @@
 from __future__ import annotations
 
+import argparse
 import json
+import runpy
+import sys
+from collections.abc import Sequence
 from pathlib import Path
 
+import pytest
+from pre_commit.clientlib import load_config
+from pre_commit.lang_base import hook_cmd
+from pre_commit.parse_shebang import normalize_cmd
+
 ROOT = Path(__file__).parents[3]
 
 
@@ -83,12 +92,56 @@ def test_global_timeout_is_not_a_pytest_deadline() -> None:
     assert 'timeout_method = "thread"' in pyproject
 
 
-def test_pre_push_hook_stays_in_the_static_feedback_lane() -> None:
-    config = (ROOT / ".pre-commit-config.yaml").read_text(encoding="utf-8")
-    hook = config.split("id: jacobian-pre-push", 1)[1]
-
-    assert "entry: make lint typecheck" in hook
-    assert "entry: make check" not in hook
+def test_local_hook_commands_have_parseable_entrypoints_and_arguments(
+    monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    config = load_config(str(ROOT / ".pre-commit-config.yaml"))
+    hooks = [
+        hook
+        for repo in config["repos"]
+        if repo["repo"] == "local"
+        for hook in repo["hooks"]
+    ]
+    assert hooks
+
+    class ArgumentsParsedError(Exception):
+        pass
+
+    original_parse_args = argparse.ArgumentParser.parse_args
+
+    def stop_after_parse(
+        parser: argparse.ArgumentParser,
+        args: Sequence[str] | None = None,
+        namespace: argparse.Namespace | None = None,
+    ) -> None:
+        original_parse_args(parser, args, namespace)
+        raise ArgumentsParsedError
+
+    monkeypatch.setattr(argparse.ArgumentParser, "parse_args", stop_after_parse)
+
+    for hook in hooks:
+        command = hook_cmd(hook["entry"], hook["args"])
+        normalize_cmd(command)
+        if hook["id"] == "jacobian-pre-push":
+            assert command == ("make", "lint", "typecheck")
+            continue
+
+        assert command[:4] == ("uv", "run", "--locked", "python"), hook["id"]
+        script_index = 4
+        assert script_index < len(command), hook["id"]
+        script = (ROOT / command[script_index]).resolve()
+        assert script.is_relative_to(ROOT) and script.is_file(), hook["id"]
+
+        namespace = runpy.run_path(str(script))
+        main = namespace.get("main")
+        assert callable(main), hook["id"]
+        monkeypatch.setattr(
+            sys,
+            "argv",
+            [str(script), *command[script_index + 1 :]],
+        )
+        with pytest.raises(ArgumentsParsedError):
+            main()
 
 
 def test_process_lane_is_invoked_by_ci() -> None: