Resolved coderabbit review comments

Signed-off-by: GOKULRAJ136 <110164849+GOKULRAJ136@users.noreply.github.com>

Author: GOKULRAJ136

registration/registration-services/src/main/java/io/mosip/registration/update/ResumableDownloader.java

@@ -57,7 +57,10 @@ private ResumableDownloader() {
      * @param fileName       the final file name within {@code targetDir}
      * @param connectTimeout connection timeout in milliseconds
      * @param readTimeout    read timeout in milliseconds (0 = infinite)
-     * @throws IOException if the download cannot be completed
+     * @throws IOException              if the download cannot be completed
+     * @throws IllegalArgumentException if {@code fileName} is blank or contains a path separator or a
+     *                                  {@code ..} sequence (guards against path-traversal writes outside
+     *                                  {@code targetDir})
      */
     public static void download(String url, String targetDir, String fileName,
                                 int connectTimeout, int readTimeout) throws IOException {
@@ -343,6 +346,12 @@ private static final class Artifact {
         private final File meta;
 
         private Artifact(File dir, String name) {
+            if (name == null || name.isEmpty()
+                    || name.indexOf('/') >= 0 || name.indexOf('\\') >= 0
+                    || name.contains("..")) {
+                throw new IllegalArgumentException(
+                        "Illegal download file name (path traversal attempt?): " + name);
+            }
             this.dir = dir;
             this.name = name;
             this.target = new File(dir, name);

registration/registration-services/src/main/java/io/mosip/registration/update/SoftwareUpdateUtil.java

@@ -129,7 +129,7 @@ protected static void downloadResumable(String url, String targetDir, String fil
                     getTimeout(READ_TIMEOUT, DEFAULT_READ_TIMEOUT));
         } catch (IOException e) {
             LOGGER.error("Failed to download {}", url, e);
-            throw new RegBaseCheckedException("REG-BUILD-005", "Failed to download " + url);
+            throw new RegBaseCheckedException("REG-BUILD-005", "Failed to download " + url, e);
         }
     }
 
@@ -146,7 +146,7 @@ protected static void ensureSpace(File targetDir, long requiredBytes) throws Reg
         try {
             ResumableDownloader.ensureSpace(targetDir, requiredBytes);
         } catch (IOException e) {
-            throw new RegBaseCheckedException("REG-BUILD-004", e.getMessage());
+            throw new RegBaseCheckedException("REG-BUILD-004", e.getMessage(), e);
         }
     }
 

registration/registration-services/src/test/java/io/mosip/registration/test/update/SoftwareUpdateUtilTest.java

@@ -303,6 +303,17 @@ public void downloadResumable_invalidHost_throws() throws Exception {
         downloadResumable("http://invalid.invalid/file", TEMP_DIR.getAbsolutePath(), "x.bin");
     }
 
+    @Test(expected = IllegalArgumentException.class)
+    public void downloadResumable_pathTraversalName_rejected() throws Exception {
+        // A malicious manifest entry must not be able to write outside the target directory.
+        downloadResumable("http://localhost/file", TEMP_DIR.getAbsolutePath(), "..\\..\\evil.bin");
+    }
+
+    @Test(expected = IllegalArgumentException.class)
+    public void downloadResumable_separatorInName_rejected() throws Exception {
+        downloadResumable("http://localhost/file", TEMP_DIR.getAbsolutePath(), "sub/evil.bin");
+    }
+
     @Test(expected = RegBaseCheckedException.class)
     public void downloadResumable_unexpectedStatus_throws() throws Exception {
         HttpServer server = HttpServer.create(new InetSocketAddress("localhost", 0), 0);