[MOSIP-43903] - Refactor test method based on code rabbit review

Signed-off-by: Nidhi0201 <nidhi.k@cyberpwn.com>

Author: NidhiKumari0201

registration-processor/registration-processor-message-sender-impl/src/test/java/io/mosip/registration/processor/message/sender/test/service/MessageNotificationServiceImplTest.java

@@ -1,6 +1,7 @@
 package io.mosip.registration.processor.message.sender.test.service;
 
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNull;
 import static org.mockito.ArgumentMatchers.*;
 import static org.mockito.Mockito.*;
 
@@ -554,38 +555,43 @@ public void testSendSmsNotificationWhenPreferredLanguagesFailShouldStillSendSmsS
 	}
 
 	@Test
-	public void testSendSmsNotificationShouldThrowJsonParseException() throws IOException, ApisResourceAccessException,
+	public void testSendSmsNotificationShouldHandleJsonParseExceptionGracefully() throws IOException, ApisResourceAccessException,
 			PacketDecryptionFailureException, JSONException, PacketManagerException, JsonProcessingException {
+
 		SyncRegistrationEntity syncEntity = new SyncRegistrationEntity();
 		syncEntity.setAdditionalInfoReqId(null);
 		syncEntity.setRegistrationType("NEW");
 		syncEntity.setPacketId("2018701130000410092018110735");
 		syncEntity.setWorkflowInstanceId("78fc3d34-03f5-11ec-9a03-0242ac130004");
 		syncEntity.setOptionalValues(new byte[] {1, 2, 3, 4, 5});
-		List<SyncRegistrationEntity> entities = new ArrayList<SyncRegistrationEntity>();
+		List<SyncRegistrationEntity> entities = new ArrayList<>();
 		entities.add(syncEntity);
 		SyncRegistrationEntity entity = new SyncRegistrationEntity();
 		entities.add(entity);
 
 		Mockito.when(syncRegistrationService.findByRegistrationId(any())).thenReturn(entities);
-
-		when(packetManagerService.getFields(anyString(),anyList(),any(), any())).thenReturn(null);
-
-		file1 = new File("src/test/resources/1001.zip");
-		is = new FileInputStream(file1);
-		IOUtils.toByteArray(is);
-		Mockito.when(decryptor.decrypt(Mockito.any(), Mockito.any(),Mockito.any())).thenReturn(is);
-
-		ResponseWrapper<SmsResponseDto> mockWrapper = new ResponseWrapper<>();
-		SmsResponseDto smsResp = new SmsResponseDto();
-		smsResp.setStatus("OK");
-		mockWrapper.setResponse(smsResp);
-
-		Mockito.when(restClientService.postApi(any(), any(), any(), Mockito.any(RequestWrapper.class),
-				Mockito.eq(ResponseWrapper.class))).thenReturn(mockWrapper);
-
-		messageNotificationServiceImpl.sendSmsNotification("RPR_UIN_GEN_SMS", "12345", "NEW", IdType.RID, attributes,
-				RegistrationType.NEW.name());
+		when(packetManagerService.getFields(anyString(), anyList(), any(), any())).thenReturn(null);
+
+		// Use try-with-resources to ensure FileInputStream is properly closed
+		try (FileInputStream is = new FileInputStream("src/test/resources/1001.zip")) {
+			IOUtils.toByteArray(is);
+			Mockito.when(decryptor.decrypt(Mockito.any(), Mockito.any(), Mockito.any())).thenReturn(is);
+
+			ResponseWrapper<SmsResponseDto> mockWrapper = new ResponseWrapper<>();
+			SmsResponseDto smsResp = new SmsResponseDto();
+			smsResp.setStatus("OK");
+			mockWrapper.setResponse(smsResp);
+
+			Mockito.when(restClientService.postApi(any(), any(), any(), Mockito.any(RequestWrapper.class),
+					Mockito.eq(ResponseWrapper.class))).thenReturn(mockWrapper);
+
+			SmsResponseDto result = messageNotificationServiceImpl.sendSmsNotification(
+					"RPR_UIN_GEN_SMS", "12345", "NEW", IdType.RID, attributes, RegistrationType.NEW.name());
+			assertNull("OK", result.getStatus());
+		} catch (IOException e) {
+			// Handle exception if necessary
+			e.printStackTrace();
+		}
 	}
 
 }