Drop eslint exclusion

Author: flodolo

src/commons/backgroundMessaging/spec.ts

@@ -1,9 +1,15 @@
 /* eslint-disable jest/expect-expect */
-/* eslint-disable @typescript-eslint/no-explicit-any */
+import type { Browser } from 'webextension-polyfill';
 import 'jest-webextension-mock';
 
-const mockBrowser =
-  (globalThis as any).mockBrowser || (globalThis as any).browser || {};
+const _global = globalThis as unknown as {
+  mockBrowser?: Browser;
+  browser?: Browser;
+};
+
+const mockBrowser = (_global.mockBrowser ||
+  _global.browser ||
+  ({} as Browser)) as jest.Mocked<Browser>;
 
 import { getOneOption } from '../options';
 

src/commons/options.spec.ts

@@ -1,5 +1,6 @@
 /* eslint-disable jest/expect-expect */
-/* eslint-disable @typescript-eslint/no-explicit-any */
+import type { Browser } from 'webextension-polyfill';
+
 import 'jest-webextension-mock';
 import { browser } from './webExtensionsApi';
 import {
@@ -10,11 +11,17 @@ import {
 } from './options';
 import { defaultOptionsFor } from './data/defaultOptions';
 
+const _global = globalThis as unknown as {
+  mockBrowser?: Browser;
+  browser?: Browser;
+  jest?: unknown;
+};
+
 const mockBrowser =
-  (browser as any) ||
-  (globalThis as any).mockBrowser ||
-  (globalThis as any).browser ||
-  {};
+  (browser as unknown as jest.Mocked<Browser>) ||
+  (_global.mockBrowser as jest.Mocked<Browser>) ||
+  (_global.browser as jest.Mocked<Browser>) ||
+  ({} as jest.Mocked<Browser>);
 
 jest.mock('@commons/webExtensionsApi/browser');
 jest.mock('@commons/data/defaultOptions');
@@ -25,14 +32,9 @@ jest.mock('@commons/data/defaultOptions');
 
 beforeEach(() => {
   mockBrowser.runtime = mockBrowser.runtime || {};
-  mockBrowser.runtime.getURL =
-    mockBrowser.runtime.getURL && (mockBrowser.runtime.getURL as any).mock
-      ? (mockBrowser.runtime.getURL as jest.Mock).mockReturnValue(
-          'moz-extension://',
-        ) && (mockBrowser.runtime.getURL as jest.Mock)
-      : (globalThis as any).jest
-        ? (globalThis as any).jest.fn().mockReturnValue('moz-extension://')
-        : () => 'moz-extension://';
+  (mockBrowser.runtime.getURL as jest.Mock) = jest
+    .fn()
+    .mockReturnValue('moz-extension://');
 });
 
 describe('options', () => {

src/commons/webExtensionsApi/__mocks__/browser.ts

@@ -5,9 +5,15 @@ import 'jest-webextension-mock';
   by `jest-webextension-mock`. This avoids duplicating mock factories
   and keeps a single source of truth for the mock shape.
 */
-/* eslint-disable @typescript-eslint/no-explicit-any */
+import type { Browser } from 'webextension-polyfill';
 
-const mock =
-  (globalThis as any).mockBrowser || (globalThis as any).browser || {};
+const _global = globalThis as unknown as {
+  mockBrowser?: Browser;
+  browser?: Browser;
+};
+
+const mock = (_global.mockBrowser ||
+  _global.browser ||
+  ({} as Browser)) as jest.Mocked<Browser>;
 
 export default mock;

src/commons/webExtensionsApi/spec.ts

@@ -1,10 +1,15 @@
 /* eslint-disable jest/expect-expect */
-/* eslint-disable @typescript-eslint/no-explicit-any */
-import type { Tabs } from 'webextension-polyfill';
+import type { Tabs, Browser } from 'webextension-polyfill';
 import 'jest-webextension-mock';
 
-const mockBrowser =
-  (globalThis as any).mockBrowser || (globalThis as any).browser || {};
+const _global = globalThis as unknown as {
+  mockBrowser?: Browser;
+  browser?: Browser;
+};
+
+const mockBrowser = (_global.mockBrowser ||
+  _global.browser ||
+  ({} as Browser)) as jest.Mocked<Browser>;
 
 import { defaultOptionsFor } from '../data/defaultOptions';
 
@@ -96,7 +101,11 @@ describe('webExtensionsApi', () => {
 
   it('createNotification', async () => {
     (mockBrowser.notifications.create as jest.Mock).mockResolvedValue('id');
-    mockBrowser.notifications.onClicked = { addListener: jest.fn() };
+    mockBrowser.notifications.onClicked = {
+      addListener: jest.fn(),
+      removeListener: jest.fn(),
+      hasListener: jest.fn(),
+    } as unknown as typeof mockBrowser.notifications.onClicked;
 
     await createNotification({ type: 'basic', title: 'foo', message: 'bar' });
 
@@ -362,7 +371,11 @@ describe('webExtensionsApi', () => {
 
   it('callWithInterval', () => {
     (mockBrowser.alarms.create as jest.Mock) = jest.fn();
-    mockBrowser.alarms.onAlarm = { addListener: jest.fn() };
+    mockBrowser.alarms.onAlarm = {
+      addListener: jest.fn(),
+      removeListener: jest.fn(),
+      hasListener: jest.fn(),
+    } as unknown as typeof mockBrowser.alarms.onAlarm;
 
     callWithInterval('name', { periodInMinutes: 42 }, jest.fn());
 
@@ -376,7 +389,11 @@ describe('webExtensionsApi', () => {
 
   it('callDelayed', () => {
     (mockBrowser.alarms.create as jest.Mock) = jest.fn();
-    mockBrowser.alarms.onAlarm = { addListener: jest.fn() };
+    mockBrowser.alarms.onAlarm = {
+      addListener: jest.fn(),
+      removeListener: jest.fn(),
+      hasListener: jest.fn(),
+    } as unknown as typeof mockBrowser.alarms.onAlarm;
 
     callDelayed({ delayInSeconds: 30 }, jest.fn());
 
@@ -387,7 +404,11 @@ describe('webExtensionsApi', () => {
   });
 
   it('listenToMessages', () => {
-    mockBrowser.runtime.onMessage = { addListener: jest.fn() };
+    mockBrowser.runtime.onMessage = {
+      addListener: jest.fn(),
+      removeListener: jest.fn(),
+      hasListener: jest.fn(),
+    } as unknown as typeof mockBrowser.runtime.onMessage;
 
     listenToMessages<'SEARCH_TEXT_IN_PONTOON'>(
       'search-text-in-pontoon',
@@ -400,7 +421,11 @@ describe('webExtensionsApi', () => {
   });
 
   it('listenToMessagesAndRespond', () => {
-    mockBrowser.runtime.onMessage = { addListener: jest.fn() };
+    mockBrowser.runtime.onMessage = {
+      addListener: jest.fn(),
+      removeListener: jest.fn(),
+      hasListener: jest.fn(),
+    } as unknown as typeof mockBrowser.runtime.onMessage;
 
     listenToMessagesAndRespond<'UPDATE_TEAMS_LIST'>(
       'update-teams-list',