build: fix all remaining -Wpointer-sign compiler warnings

Author: YoussefZidan-1

demux/demux_cue.c

@@ -253,7 +253,7 @@ static int try_open_file(struct demuxer *demuxer, enum demux_check check)
     if (check >= DEMUX_CHECK_UNSAFE) {
         char probe[PROBE_SIZE];
         int len = stream_read_peek(s, probe, sizeof(probe));
-        if (len < 1 || !mp_probe_cue((bstr){probe, len}))
+        if (len < 1 || !mp_probe_cue((bstr){(unsigned char *)probe, len}))
             return -1;
     }
     struct priv *p = talloc_zero(demuxer, struct priv);

demux/demux_playlist.c

@@ -160,7 +160,7 @@ static char *read_line(stream_t *s, char *mem, int max, int utf16)
     int read = 0;
     while (1) {
         // Reserve 1 byte of ptr for terminating \0.
-        int l = read_characters(s, &mem[read], max - read - 1, utf16);
+        int l = read_characters(s, (uint8_t *)&mem[read], max - read - 1, utf16);
         if (l < 0 || memchr(&mem[read], '\0', l)) {
             MP_WARN(s, "error reading line\n");
             return NULL;
@@ -252,7 +252,7 @@ static int parse_m3u(struct pl_parser *p)
             bstr ext = mp_get_ext(bstr0(p->real_stream->url));
             char probe[PROBE_SIZE];
             int len = stream_read_peek(p->real_stream, probe, sizeof(probe));
-            bstr data = {probe, len};
+            bstr data = {(unsigned char *)probe, len};
             if (ext.len && data.len >= 2 && maybe_text(data)) {
                 const char *exts[] = {"m3u", "m3u8", "strm", NULL};
                 for (int n = 0; exts[n]; n++) {

input/input.c

@@ -542,7 +542,7 @@ static mp_cmd_t *get_cmd_from_keys(struct input_ctx *ictx, bstr force_section,
         if (MP_KEY_IS_UNICODE(code)) {
             bstr text = {0};
             mp_append_utf8_bstr(ret, &text, code);
-            ret->key_text = text.start;
+            ret->key_text = (char *)text.start;
         }
         ret->is_mouse_button = code & MP_KEY_EMIT_ON_UP;
     } else {

input/ipc-unix.c

@@ -100,7 +100,7 @@ static MP_THREAD_VOID client_thread(void *p)
     int rc;
 
     struct client_arg *arg = p;
-    bstr client_msg = { talloc_strdup(NULL, ""), 0 };
+    bstr client_msg = { (unsigned char *)talloc_strdup(NULL, ""), 0 };
 
     char *tname = talloc_asprintf(NULL, "ipc/%s", arg->client_name);
     mp_thread_set_name(tname);
@@ -163,7 +163,7 @@ static MP_THREAD_VOID client_thread(void *p)
         if (fds[1].revents & (POLLIN | POLLHUP | POLLNVAL)) {
             while (1) {
                 char buf[128];
-                bstr append = { buf, 0 };
+                bstr append = { (unsigned char *)buf, 0 };
 
                 ssize_t bytes = read(arg->client_fd, buf, sizeof(buf));
                 if (bytes < 0) {

misc/bstr.c

@@ -48,7 +48,7 @@ int bstrcasecmp(struct bstr str1, struct bstr str2)
 {
     int ret = 0;
     if (str1.len && str2.len)
-        ret = strncasecmp(str1.start, str2.start, MPMIN(str1.len, str2.len));
+        ret = strncasecmp((char *)str1.start, (char *)str2.start, MPMIN(str1.len, str2.len));
 
     if (!ret) {
         if (str1.len == str2.len)
@@ -397,7 +397,7 @@ int bstr_xappend_vasprintf(void *talloc_ctx, bstr *s, const char *fmt,
     va_list copy;
     va_copy(copy, ap);
     size_t avail = talloc_get_size(s->start) - s->len;
-    char *dest = s->start ? s->start + s->len : NULL;
+    char *dest = s->start ? (char *)(s->start + s->len) : NULL;
     size = vsnprintf(dest, avail, fmt, copy);
     va_end(copy);
 
@@ -406,7 +406,7 @@ int bstr_xappend_vasprintf(void *talloc_ctx, bstr *s, const char *fmt,
 
     if (avail < 1 || size + 1 > avail) {
         resize_append(talloc_ctx, s, size + 1);
-        vsnprintf(s->start + s->len, size + 1, fmt, ap);
+        vsnprintf((char *)(s->start + s->len), size + 1, fmt, ap);
     }
     s->len += size;
     return size;
@@ -457,7 +457,7 @@ bool bstr_decode_hex(void *talloc_ctx, struct bstr hex, struct bstr *out)
         arr[len++] = (a << 4) | b;
     }
 
-    *out = (struct bstr){ .start = arr, .len = len };
+    *out = (struct bstr){ .start = (unsigned char *)arr, .len = len };
     return true;
 }
 

misc/charset_conv.c

@@ -69,7 +69,7 @@ static const char *mp_uchardet(void *talloc_ctx, struct mp_log *log, bstr buf)
     uchardet_t det = uchardet_new();
     if (!det)
         return NULL;
-    if (uchardet_handle_data(det, buf.start, buf.len) != 0) {
+    if (uchardet_handle_data(det, (char *)buf.start, buf.len) != 0) {
         uchardet_delete(det);
         return NULL;
     }
@@ -180,7 +180,7 @@ bstr mp_iconv_to_utf8(struct mp_log *log, bstr buf, const char *cp, int flags)
     size_t oleft = size - 1;
 
     char *outbuf = talloc_size(NULL, osize);
-    char *ip = buf.start;
+    char *ip = (char *)buf.start;
     char *op = outbuf;
 
     while (1) {
@@ -222,7 +222,7 @@ bstr mp_iconv_to_utf8(struct mp_log *log, bstr buf, const char *cp, int flags)
     iconv_close(icdsc);
 
     outbuf[osize - oleft - 1] = 0;
-    return (bstr){outbuf, osize - oleft - 1};
+    return (bstr){(unsigned char *)outbuf, osize - oleft - 1};
 
 failure:
 #endif

misc/json.c

@@ -125,7 +125,7 @@ static int read_str(void *ta_parent, struct mpv_node *dst, char **src)
         bstr r = bstr0(str);
         if (!mp_append_escaped_string(ta_parent, &unescaped, &r))
             return -1; // broken escapes
-        str = unescaped.start; // the function guarantees null-termination
+        str = (char *)unescaped.start; // the function guarantees null-termination
     }
     dst->format = MPV_FORMAT_STRING;
     dst->u.string = str;
@@ -268,17 +268,17 @@ static void write_json_str(bstr *b, unsigned char *str)
             break;
         bstr_xappend(NULL, b, (bstr){str, cur - str});
         if (cur[0] == '\"') {
-            bstr_xappend(NULL, b, (bstr){"\\\"", 2});
+            bstr_xappend(NULL, b, (bstr){(unsigned char *)"\\\"", 2});
         } else if (cur[0] == '\\') {
-            bstr_xappend(NULL, b, (bstr){"\\\\", 2});
+            bstr_xappend(NULL, b, (bstr){(unsigned char *)"\\\\", 2});
         } else if (cur[0] < sizeof(special_escape) && special_escape[cur[0]]) {
             bstr_xappend_asprintf(NULL, b, "\\%c", special_escape[cur[0]]);
         } else {
             bstr_xappend_asprintf(NULL, b, "\\u%04x", (unsigned char)cur[0]);
         }
         str = cur + 1;
     }
-    APPEND(b, str);
+    APPEND(b, (char *)str);
     APPEND(b, "\"");
 }
 
@@ -312,7 +312,7 @@ int json_append(bstr *b, const struct mpv_node *src, int indent)
         if (indent == 0)
             APPEND(b, src->u.string);
         else
-            write_json_str(b, src->u.string);
+            write_json_str(b, (unsigned char *)(src->u.string));
         return 0;
     case MPV_FORMAT_NODE_ARRAY:
     case MPV_FORMAT_NODE_MAP: {
@@ -325,7 +325,7 @@ int json_append(bstr *b, const struct mpv_node *src, int indent)
                 APPEND(b, ",");
             add_indent(b, next_indent);
             if (is_obj) {
-                write_json_str(b, list->keys[n]);
+                write_json_str(b, (unsigned char *)list->keys[n]);
                 APPEND(b, ":");
             }
             json_append(b, &list->values[n], next_indent);
@@ -342,7 +342,7 @@ static int json_append_str(char **dst, struct mpv_node *src, int indent)
 {
     bstr buffer = bstr0(*dst);
     int r = json_append(&buffer, src, indent);
-    *dst = buffer.start;
+    *dst = (char *) buffer.start;
     return r;
 }
 

misc/path_utils.c

@@ -61,7 +61,7 @@ bstr mp_basename_bstr(bstr path)
 
 const char *mp_basename(const char *path)
 {
-    return mp_basename_bstr(bstr0(path)).start;
+    return (char *)mp_basename_bstr(bstr0(path)).start;
 }
 
 struct bstr mp_dirname(const char *path)

options/m_config_frontend.c

@@ -110,7 +110,7 @@ static int show_profile(struct m_config *config, bstr param, int depth)
                 int l = e - list;
                 if (!l)
                     continue;
-                show_profile(config, (bstr){list, e - list}, depth);
+                show_profile(config, (bstr){(unsigned char *)list, e - list}, depth);
                 list = e + 1;
             }
             if (list[0] != '\0')

options/m_option.c

@@ -1418,7 +1418,7 @@ static char **separate_input_param(const m_option_t *opt, bstr param,
 
     char **list = talloc_array(NULL, char *, n + 2);
     str = bstrdup(NULL, param);
-    char *ptr = str.start;
+    char *ptr = (char *)str.start;
     n = 0;
 
     while (1) {