Feature Request: sr_amf + amf_hqscaler + amf_vqenhance

[JuliusBairaktaris]

See FFmpeg's AMF filters (5.3: https://trac.ffmpeg.org/wiki/Hardware/AMF) — sr_amf / super-resolution scaling.

Would be a nice addition to the already-implemented amf_frc. Since the infrastructure already exists in video/filter/vf_amf.c, amf_hqscaler (HQScaler / VideoSR super-resolution) and amf_vqenhance (VQ Enhancer) should fit he same bucket

Edit: amf_hqscaler already exists — it's sr_amf.

[kasper93]

If it is implemented in ffmpeg, you can use it directly in mpv.

[Jules-A]

If it is implemented in ffmpeg, you can use it directly in mpv.

I've always got errors or corrupted output when trying in MPV. Haven't tried with just ffmpeg though.

Using hardware decoding (d3d11va).
[ffmpeg] filter: AMFHQScaler-Init() failed with error 4
[ffmpeg] filter: Failed to configure output pad on filter
[lavfi] failed to configure the filter graph
Disabling filter sr_amf.00 because it has failed.

Using hardware decoding (amf-copy).
[autoconvert] HW-downloading from amf
[hwdownload] Could not copy hardware frame to CPU memory.
AO: [wasapi] 48000Hz stereo 2ch float
[hwdownload] Could not copy hardware frame to CPU memory.
VO: [gpu-next] 4096x2160 amf[yuv420p]
Assertion failed: frame->num_planes in src/renderer.c:3047

[autoconvert] HW-downloading from amf
[hwdownload] Could not copy hardware frame to CPU memory.
AO: [wasapi] 48000Hz stereo 2ch float
[hwdownload] Could not copy hardware frame to CPU memory.
VO: [gpu-next] 4096x2160 amf[yuv420p]
Assertion failed: frame->num_planes in src/renderer.c:3047

[autoconvert] HW-downloading from amf
[hwdownload] Could not copy hardware frame to CPU memory.
AO: [wasapi] 48000Hz stereo 2ch float
[hwdownload] Could not copy hardware frame to CPU memory.
VO: [gpu-next] 4096x2160 amf[p010]
Assertion failed: frame->num_planes in src/renderer.c:3047

[JuliusBairaktaris]

@kasper93 I get the same issue as @Jules-A. Do you have a minimal working example

[adisib]

I had no issues using it like this on a 720x360 video:
--vf=sr_amf='4096:2048:sharpness=2.0'

Edit: It does not like if I try to use the sr1-1 algorithm though, as I get only a green screen.

[Jules-A]

I had no issues using it like this on a 720x360 video: --vf=sr_amf='4096:2048:sharpness=2.0'

Edit: It does not like if I try to use the sr1-1 algorithm though, as I get only a green screen.

Hmm, I was able to get that sort of working but 480p results in blocky corruption and higher resolutions result in full corruption. I have a video with 432p that was able to play without noticeable artifacts though :/
Also, it would only work with hwdec=amf-copy.

[kasper93]

The command @adisib provided works for me. I would suggest testing in ffmpeg directly those filters first and report to upstream any issues. All the hwdownload failures looks suspicious, but this should work the same in ffmpeg, unless we need to force some format.

[Jules-A]

I would suggest testing in ffmpeg directly those filters first and report to upstream any issues. All the hwdownload failures looks suspicious, but this should work the same in ffmpeg, unless we need to force some format.

I couldn't manage to get it to work in ffmpeg either but I'm not sure if I was doing something wrong. I'm not really familiar with ffplay.
With the above command it outputs as NV12 but when I try to convert it in the same filter it fails.

The command @adisib provided works for me.

Were you also testing the lower resolutions or did you get it working above 432p? What mpv settings did you use?

[kasper93]

Were you also testing the lower resolutions or did you get it working above 432p? What mpv settings did you use?

Tested with 1080p video. As for mpv settings --no-config.

[Jules-A]

Were you also testing the lower resolutions or did you get it working above 432p? What mpv settings did you use?

Tested with 1080p video. As for mpv settings --no-config.

Oh... I see now, it's working with an 8bit source but 10bit fails.

[JuliusBairaktaris]

Also, it would only work with hwdec=amf-copy.

This is suboptimal when trying to mix it with amf frc. @kasper93 Could a fix be added to mpv?

AMF FRC only supports D3D11 input currently. Use --hwdec=d3d11va or --vf-pre=format=d3d11 to upload the data. --d3d11va-zero-copy is also recommended for better performance.

[JuliusBairaktaris]

https://code.ffmpeg.org/FFmpeg/FFmpeg/issues/23344

Please add any testing in that regards here