RFC: Security division naming — security/ vs cybersecurity/ #438
Replies: 6 comments
|
Hey @msitarzewski — thanks for opening this, good to get alignment before things diverge further. Here's my take on the four questions: 1. Directory name: Consistent with the repo's convention — short, lowercase, no prefix redundancy ( 2. Scope: standalone division There are enough distinct specializations (offensive, defensive, IR, cloud, threat intel) to justify a dedicated division. The existing 3 + 4. Agent overlap & division composition I'd propose combining the best from all three PRs:
TL;DR: Happy to help with the coordination if useful. |
|
Thanks for driving this alignment, @msitarzewski — fully agree with the direction.
|
|
I divided files in more files |
|
Thanks for the proposals! I'm on board with renaming |
|
I would use Reasoning:
For overlap, I would merge by capability boundaries rather than PR ownership. A clean initial division could be:
The standalone penetration tester should not live under |
|
✅ Resolved & shipped in #566. The consensus here is now live: a single
Per @yoavprat's call, #383 stays closed (its Penetration Tester overlapped #223's). All 10 passed lint + the originality check. #223 and #326 are closed with credit. Thanks everyone for aligning here before the code diverged further. 🔒 |
Uh oh!
There was an error while loading. Please reload this page.
Context
Two open PRs propose security-focused agent divisions with different directory names:
security/directory with 1 agent (Senior SecOps Engineer) — focused on defensive code-level security, automatic secrets scanningcybersecurity/directory with 5 agents (Penetration Tester, Incident Responder, Cloud Security Architect, Threat Intel Analyst, AppSec Engineer) — comprehensive offensive + defensive divisionAdditionally, PR #383 (@yoavprat) adds a standalone Penetration Tester to
testing/which overlaps with #223's penetration tester.Both PRs modify
scripts/install.sh,scripts/convert.sh,scripts/lint-agents.sh, and the CI workflow — they can't both merge without coordination.Questions for the Community
security/orcybersecurity/? Or something else?engineering/(since we already haveengineering-security-engineer.md)?Please weigh in! Once we align on the approach, the contributors can coordinate and we'll merge.
Ref: PR #326, PR #223, PR #383
All reactions