Merge pull request #455 from ndii-dev/chore/payments-limits-boundaries-cache

refactor: introduce payment limits boundary and cache stub

Author: Jambox11

src/limits/limits.service.spec.ts

@@ -32,6 +32,8 @@ describe('LimitsService', () => {
       incrementLimitChecks: jest.fn(),
     };
 
+    cacheService = { get: jest.fn(), set: jest.fn(), delete: jest.fn() };
+
     const module: TestingModule = await Test.createTestingModule({
       providers: [
         LimitsService,
@@ -68,6 +70,17 @@ describe('LimitsService', () => {
       const result = await service.getLimits(walletId);
       expect(result).toEqual(limit);
     });
+
+    it('should use the cache layer for wallet limits', async () => {
+      const limit = { walletId, dailyLimit: 100, perTransactionLimit: 10 };
+      cacheService.get.mockReturnValue(limit);
+
+      const result = await service.getLimits(walletId);
+
+      expect(result).toEqual(limit);
+      expect(cacheService.get).toHaveBeenCalledWith(`limits:${walletId}`);
+      expect(prisma.walletLimit.findUnique).not.toHaveBeenCalled();
+    });
   });
 
   describe('checkLimits', () => {

src/payments/payments-limits.integration.spec.ts

@@ -43,6 +43,7 @@ describe('Payments and Limits Integration', () => {
         PaymentsService,
         LimitsService,
         { provide: PrismaService, useValue: mockPrisma },
+        { provide: PAYMENT_LIMITS_PORT, useExisting: LimitsService },
         { provide: WalletsService, useValue: mockWalletsService },
         { provide: RequestContextService, useValue: mockRequestContext },
       ],

src/payments/payments.service.spec.ts

@@ -3,7 +3,6 @@ import { BadRequestException, NotFoundException } from '@nestjs/common';
 import { EventEmitter2 } from '@nestjs/event-emitter';
 import { PaymentsService } from './payments.service';
 import { PrismaService } from '../prisma/prisma.service';
-import { LimitsService } from '../limits/limits.service';
 import { WalletsService } from '../wallets/wallets.service';
 import { MetricsService } from '../metrics/metrics.service';
 import { WalletStatus } from '../wallets/domain/wallet.model';
@@ -31,7 +30,7 @@ const BASE_DTO = {
 describe('PaymentsService', () => {
   let service: PaymentsService;
   let prisma: any;
-  let limitsService: any;
+  let paymentLimitsPort: any;
   let walletsService: any;
   let eventEmitter: any;
   let metrics: any;
@@ -46,7 +45,7 @@ describe('PaymentsService', () => {
         count: jest.fn(),
       },
     };
-    limitsService = { checkLimits: jest.fn() };
+    paymentLimitsPort = { checkLimits: jest.fn() };
     walletsService = { findWalletById: jest.fn() };
     eventEmitter = { emit: jest.fn() };
     metrics = {
@@ -59,7 +58,7 @@ describe('PaymentsService', () => {
       providers: [
         PaymentsService,
         { provide: PrismaService, useValue: prisma },
-        { provide: LimitsService, useValue: limitsService },
+        { provide: PAYMENT_LIMITS_PORT, useValue: paymentLimitsPort },
         { provide: WalletsService, useValue: walletsService },
         { provide: EventEmitter2, useValue: eventEmitter },
         { provide: MetricsService, useValue: metrics },
@@ -78,7 +77,7 @@ describe('PaymentsService', () => {
       walletsService.findWalletById
         .mockResolvedValueOnce(ACTIVE_WALLET)
         .mockResolvedValueOnce(RECEIVER_WALLET);
-      limitsService.checkLimits.mockResolvedValue(undefined);
+      paymentLimitsPort.checkLimits.mockResolvedValue(undefined);
       prisma.payment.create.mockResolvedValue({
         id: 1,
         ...BASE_DTO,
@@ -93,7 +92,7 @@ describe('PaymentsService', () => {
       expect(walletsService.findWalletById).toHaveBeenCalledWith(
         BASE_DTO.receiverWalletId,
       );
-      expect(limitsService.checkLimits).toHaveBeenCalledWith(
+      expect(paymentLimitsPort.checkLimits).toHaveBeenCalledWith(
         BASE_DTO.walletId,
         BASE_DTO.amount,
       );
@@ -166,7 +165,7 @@ describe('PaymentsService', () => {
       walletsService.findWalletById
         .mockResolvedValueOnce(ACTIVE_WALLET)
         .mockResolvedValueOnce(RECEIVER_WALLET);
-      limitsService.checkLimits.mockResolvedValue(undefined);
+      paymentLimitsPort.checkLimits.mockResolvedValue(undefined);
       prisma.payment.create.mockResolvedValue({
         id: 1,
         ...BASE_DTO,
@@ -175,7 +174,7 @@ describe('PaymentsService', () => {
 
       await service.create(BASE_DTO);
 
-      expect(limitsService.checkLimits).toHaveBeenCalledWith(
+      expect(paymentLimitsPort.checkLimits).toHaveBeenCalledWith(
         BASE_DTO.walletId,
         BASE_DTO.amount,
       );

src/payments/payments.service.ts

@@ -1,4 +1,5 @@
 import {
+  Inject,
   Injectable,
   NotFoundException,
   BadRequestException,
@@ -8,8 +9,11 @@ import { EventEmitter2 } from '@nestjs/event-emitter';
 import { CreatePaymentDto } from './dto/create-payment.dto';
 import { UpdatePaymentDto } from './dto/update-payment.dto';
 import { PrismaService } from '../prisma/prisma.service';
-import { LimitsService } from '../limits/limits.service';
 import { WalletsService } from '../wallets/wallets.service';
+import {
+  PAYMENT_LIMITS_PORT,
+  PaymentLimitsPort,
+} from './ports/payment-limits.port';
 import { WalletStatus } from '../wallets/domain/wallet.model';
 import { PaymentStatus } from './entities/payment.entity';
 import { PaginationDto, PaginatedResponse } from '../common/dto/pagination.dto';
@@ -33,7 +37,8 @@ export class PaymentsService {
 
   constructor(
     private readonly prisma: PrismaService,
-    private readonly limitsService: LimitsService,
+    @Inject(PAYMENT_LIMITS_PORT)
+    private readonly paymentLimitsPort: PaymentLimitsPort,
     private readonly walletsService: WalletsService,
     private readonly eventEmitter: EventEmitter2,
     private readonly metrics: MetricsService,

src/payments/ports/payment-limits.port.ts

@@ -0,0 +1,8 @@
+import { Injectable, InjectionToken } from '@nestjs/common';
+
+export const PAYMENT_LIMITS_PORT = Symbol('PAYMENT_LIMITS_PORT') as InjectionToken;
+
+@Injectable()
+export abstract class PaymentLimitsPort {
+  abstract checkLimits(walletId: string, amount: number): Promise<void> | void;
+}