* now only invoke ThreadRepository->getThreadsIdByChunks() once for all fids @ forums()

* reuse `new \DateInterval('P1D')` into `self::$cacheAgeSeconds` as int
* set `Cache-Controller` response header with value `max-age=86400, public`
@ `App\Controller\SitemapController`

* optimize the query by return all fid instead only the given `$fid` param to prevent duplicate full table scan @ `App\Repository\Post\ThreadRepository->getThreadsIdByChunks()`
- unused method `getOrderedForumsId()` @ `App\Repository\ForumRepository`
@ be

Author: n0099

be/src/Controller/SitemapController.php

@@ -16,7 +16,8 @@
 
 class SitemapController extends AbstractController
 {
-    public static int $maxUrls = 50000;
+    private static int $maxUrls = 50000;
+    private static int $cacheAgeSeconds = 86400;
 
     public function __construct(
         private readonly CacheInterface $cache,
@@ -30,16 +31,12 @@ public function forums(): Response
         return $this->cache->get(
             '/sitemaps/forums',
             function (ItemInterface $item) {
-                $item->expiresAfter(new \DateInterval('P1D'));
-                $threadsIdKeyByFid = collect($this->forumRepository->getOrderedForumsId())
-                    ->mapWithKeys(fn(int $fid) => [
-                        $fid => $this->threadRepository->getThreadsIdByChunks($fid, self::$maxUrls),
-                    ])
-                    ->toArray();
+                $item->expiresAfter(self::$cacheAgeSeconds);
                 return $this->renderXml(
                     'sitemaps/forums.xml.twig',
-                    ['threads_id_key_by_fid' => $threadsIdKeyByFid],
-                );
+                    ['threads_id_key_by_fid' => collect($this->threadRepository->getThreadsIdByChunks(self::$maxUrls))
+                        ->mapToGroups(static fn(array $i) => [$i['fid'] => $i['tid']])],
+                )->setMaxAge(self::$cacheAgeSeconds)->setPublic();
             },
         );
     }
@@ -53,15 +50,15 @@ public function threads(Request $request, Validator $validator, int $fid): Respo
         return $this->cache->get(
             "/sitemaps/forums/$fid/threads?cursor=$cursor",
             function (ItemInterface $item) use ($fid, $cursor) {
-                $item->expiresAfter(new \DateInterval('P1D'));
+                $item->expiresAfter(self::$cacheAgeSeconds);
                 Helper::abortAPIIfNot(40406, $this->forumRepository->isForumExists($fid));
                 return $this->renderXml(
                     'sitemaps/threads.xml.twig',
                     [
                         'threads' => $this->threadRepository->getThreadsIdWithMaxPostedAtAfter($fid, $cursor, self::$maxUrls),
                         'base_url_fe' => $this->getParameter('app.base_url.fe'),
                     ],
-                );
+                )->setMaxAge(self::$cacheAgeSeconds)->setPublic();
             },
         );
     }

be/src/Repository/ForumRepository.php

@@ -19,12 +19,6 @@ public function getOrderedForums(): array
         return $this->createQuery($dql)->getResult();
     }
 
-    public function getOrderedForumsId(): array
-    {
-        $dql = 'SELECT t.fid FROM App\Entity\Forum t ORDER BY t.fid';
-        return $this->createQuery($dql)->getSingleColumnResult();
-    }
-
     public function isForumExists(int $fid): bool
     {
         $dql = 'SELECT 1 FROM App\Entity\Forum t WHERE t.fid = :fid';

be/src/Repository/Post/ThreadRepository.php

@@ -29,21 +29,20 @@ public function getPosts(int $fid, array|\ArrayAccess $postsId): array
         return $this->getQueryResultWithParams($dql, ['fid' => $fid, 'tid' => $postsId]);
     }
 
-    public function getThreadsIdByChunks(int $fid, int $chunkSize): array
+    public function getThreadsIdByChunks(int $chunkSize): array
     {
         // https://github.com/doctrine/orm/issues/3542
         // https://github.com/doctrine/dbal/issues/5018#issuecomment-2395177479
         // https://github.com/beberlei/DoctrineExtensions/pull/453
         $entityManager = $this->getEntityManager();
         $tableName = $entityManager->getClassMetadata(Thread::class)->getTableName();
         $statement = $entityManager->getConnection()->prepare(<<<"SQL"
-            SELECT tid FROM (
+            SELECT fid, tid FROM (
                 SELECT fid, tid, ROW_NUMBER() OVER (PARTITION BY fid ORDER BY tid) rn FROM $tableName
-            ) t WHERE fid = :fid AND rn % :chunkSize = 0
+            ) t WHERE rn % :chunkSize = 0
             SQL);
-        $statement->bindValue('fid', $fid);
         $statement->bindValue('chunkSize', $chunkSize);
-        return $statement->executeQuery()->fetchFirstColumn();
+        return $statement->executeQuery()->fetchAllAssociative();
     }
 
     public function getThreadsIdWithMaxPostedAtAfter(int $fid, int $after, int $limit): array