* replace key forum with forums that contains all forum of queried posts

* fix prop `$latestReplierId` of `App\Entity\Post\Thread` might be `null` in `$latestRepliersIdKeyByFid`
@ `App\Controller\PostsController::query()`

* rename method `getForum()` to `getForums()` as now querying against multiple forums @ `ForumRepository`
* now return a merge array instead of `Collection` @ `LatestReplierRepository::getLatestRepliersWithoutNameWhenHasUid()`
@ `App\Repository`
@ be

Author: n0099

be/src/Controller/PostsController.php

@@ -65,6 +65,7 @@ public function query(Request $request): array
         $this->stopwatch->start('queryUsers');
         $latestRepliersIdKeyByFid = $this->query->postsTree->threads
             ->map(fn(Thread $thread) => ['fid' => $thread->getFid(), 'latestReplierId' => $thread->getLatestReplierId()])
+            ->filter(fn(array $fidAndLatestReplierId) => $fidAndLatestReplierId['latestReplierId'] !== null)
             ->groupBy(fn(array $fidAndLatestReplierId) => $fidAndLatestReplierId['fid'])
             ->map(fn(Collection $fidAndLatestRepliersUid) => $fidAndLatestRepliersUid->pluck('latestReplierId'));
         $latestRepliers = $this->latestReplierRepository->getLatestRepliersWithoutNameWhenHasUid($latestRepliersIdKeyByFid->flatten());
@@ -73,7 +74,7 @@ public function query(Request $request): array
             $this->query->postsTree->replies,
             $this->query->postsTree->subReplies
         ])->flatten();
-        $latestRepliersUidKeyById = $latestRepliers
+        $latestRepliersUidKeyById = collect($latestRepliers)
             ->mapWithKeys(fn(array|LatestReplier $latestReplier) => [
                 is_array($latestReplier) ? $latestReplier['id'] : $latestReplier->getId() =>
                     is_array($latestReplier) ? $latestReplier['uid'] : $latestReplier->getUid()
@@ -112,6 +113,7 @@ public function query(Request $request): array
                 ->map(fn(int $uid) => $users->get($uid)?->getPortrait())
                 ->filter(fn(?string $portrait) => $portrait !== null))
         ))->keyBy(fn(ForumModerator $forumModerator) => $forumModerator->portrait);
+
         $users = $users->each(fn(User $user) => $user->setForumSpecific([
             'authorExpGrades' => $authorExpGrades->get($user->getUid()),
             'forumModerators' => $forumModerators->get($user->getPortrait())
@@ -124,7 +126,9 @@ public function query(Request $request): array
                 'nextCursor' => $this->query->queryResult->nextCursor,
                 ...$matchQueryPostCounts,
             ],
-            'forum' => $this->forumRepository->getForum($fid),
+            'forums' => collect($this->forumRepository
+                ->getForums($posts->map(fn(Post $post) => $post->getFid())->unique())
+            )->mapWithKeys(fn(array $forum) => [$forum['fid'] => $forum['name']]),
             'threads' => $this->query->postsTree->reOrderNestedPosts(
                 $this->query->postsTree->nestPostsWithParent(),
                 $this->query->getOrderByField(),

be/src/Repository/ForumRepository.php

@@ -25,10 +25,9 @@ public function isForumExists(int $fid): bool
         return $this->isEntityExists($dql, ['fid' => $fid]);
     }
 
-    public function getForum(int $fid): array
+    public function getForums(array|\ArrayAccess $fids): array
     {
-        $dql = 'SELECT t.fid, t.name FROM App\Entity\Forum t WHERE t.fid = :fid';
-        return $this->createQueryWithParams($dql, ['fid' => $fid])
-            ->setMaxResults(1)->getSingleResult();
+        $dql = 'SELECT t.fid, t.name FROM App\Entity\Forum t WHERE t.fid IN (:fids)';
+        return $this->createQueryWithParams($dql, ['fids' => $fids])->getResult();
     }
 }

be/src/Repository/LatestReplierRepository.php

@@ -14,19 +14,19 @@ public function __construct(ManagerRegistry $registry)
         parent::__construct($registry, LatestReplier::class);
     }
 
-    public function getLatestRepliersWithoutNameWhenHasUid(array|\ArrayAccess $latestRepliersId): Collection
+    /** @return list<array{id: int, uid: int, createdAt: int, updatedAt: int}|LatestReplier> */
+    public function getLatestRepliersWithoutNameWhenHasUid(array|\ArrayAccess $latestRepliersId): array
     {
-        // removeSelect('t.name', 't.displayName')
-        return collect($this->getQueryResultWithParams(<<<'DQL'
+        return [ // removeSelect('t.name', 't.displayName')
+            ...$this->getQueryResultWithParams(<<<'DQL'
                 SELECT t.id, t.uid, t.createdAt, t.updatedAt
                 FROM App\Entity\LatestReplier t
                 WHERE t.id IN (:ids) AND t.uid IS NOT NULL
-                DQL, ['ids' => $latestRepliersId]))
-            ->concat(
-                $this->getQueryResultWithParams(<<<'DQL'
+                DQL, ['ids' => $latestRepliersId]),
+            ...$this->getQueryResultWithParams(<<<'DQL'
                 SELECT t FROM App\Entity\LatestReplier t
                 WHERE t.id IN (:ids) AND t.uid IS NULL
                 DQL, ['ids' => $latestRepliersId]),
-            );
+        ];
     }
 }