* change the height of .post-nav(-expand)? from fixed height: 100vh to dynamicly max-height: 100dvh @ <PostNav>

* replace some pattern of `v === a || v === b` or `v !== a && v !== b` with `Array.includes()` following https://en.wikipedia.org/wiki/De_Morgan%27s_laws except whose need type narrowing: microsoft/TypeScript#51678
* remove all unused `eslint-disable` directives for rule `compat/compat` since 037ccd9 upgraded target browser versions
@ fe

Author: n0099

fe/src/components/post/Nav.vue

@@ -1,6 +1,6 @@
 <template>
 <nav
-    class="post-nav col p-0 vh-100 sticky-top border-0"
+    class="post-nav col p-0 sticky-top border-0"
     :class="{ 'd-none': !isPostNavExpanded }" :aria-expanded="isPostNavExpanded">
     <AMenu
         v-model:selectedKeys="selectedThreads" v-model:openKeys="expandedPages" @click="selectThread($event)"
@@ -33,7 +33,7 @@
         'border-start': isPostNavExpanded,
         'border-end': !isPostNavExpanded
     }"
-    class="post-nav-expand col-auto align-items-center d-flex vh-100 sticky-top border-light-subtle">
+    class="post-nav-expand col-auto align-items-center d-flex sticky-top border-light-subtle">
     <a
         v-if="!hydrationStore.isHydratingOrSSR"
         @click="togglePostNavExpanded()" class="text-primary">
@@ -175,6 +175,9 @@ watch(viewportTopmostPost, async (to, from) => {
 .post-nav {
     overflow: hidden;
 }
+.post-nav, .post-nav-expand {
+    max-height: 100dvh;
+}
 .post-nav:hover {
     overflow-y: auto;
 }

fe/src/components/post/queryForm/QueryForm.vue

@@ -157,7 +157,7 @@
                     </option>
                 </select>
             </template>
-            <template v-if="p.name === 'authorGender' || p.name === 'latestReplierGender'">
+            <template v-if="['authorGender', 'latestReplierGender'].includes(p.name)">
                 <select v-model="p.value" class="form-control flex-grow-0 w-25">
                     <option value="0">未设置（显示为男）</option>
                     <option value="1">男 ♂</option>

fe/src/components/user/QueryForm.vue

@@ -44,7 +44,7 @@ const paramsDefaultValue = {
 } as const;
 const omitDefaultParamsValue = (params: Record<string, LocationQueryValueRaw>) => {
     _.each(paramsDefaultValue, (value, param) => {
-        if (params[param] === value || params[param] === undefined)
+        if ([value, undefined].includes(params[param]))
             Reflect.deleteProperty(params, param);
     });
 

fe/src/stores/relativeTime.ts

@@ -38,7 +38,6 @@ export const useRelativeTimeStore = defineStore('relativeTime', () => {
         return oldVisibility;
     };
     const intersectionObserver = 'IntersectionObserver' in globalThis
-        // eslint-disable-next-line compat/compat
         ? new IntersectionObserver(entries => {
             _.orderBy(entries, entry => entry.time).forEach(entry => { // https://github.com/vueuse/vueuse/issues/4197
                 const visibility = getElementVisibility(entry.target);

fe/src/stores/viewportTopmostPost.ts

@@ -10,6 +10,7 @@ export const useViewportTopmostPostStore = defineStore('viewportTopmostPost', ()
         return { cursor, tid: Number(tid), pid: undefinedOr(pid, Number) };
     };
     type UsingImplement = Promise<(stickyTitleEl: Ref<HTMLElement | undefined | null>, newTopmostPost: TopmostPost, topOffset?: number) => void>;
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
     const usingScrollState = async (): UsingImplement => {
         const stuckPosts = ref<TopmostPost[]>([]); // https://github.com/w3c/csswg-drafts/issues/12302
         type Record = Parameters<ConstructorParameters<typeof StyleObserver>[0]>[0];
@@ -62,9 +63,7 @@ export const useViewportTopmostPostStore = defineStore('viewportTopmostPost', ()
         // https://stackoverflow.com/questions/16302483/event-to-detect-when-positionsticky-is-triggered
         // https://stackoverflow.com/questions/54807535/intersection-observer-api-observe-the-center-of-the-viewport
         // https://web.archive.org/web/20240111160426/https://wilsotobianco.com/experiments/intersection-observer-playground/
-        // eslint-disable-next-line compat/compat
         const observerForZeroTopOffset = new IntersectionObserver(onIntersect, { rootMargin: '0px 0px -100% 0px' });
-        // eslint-disable-next-line compat/compat
         let observerForNonZeroTopOffset = new IntersectionObserver(noop);
 
         return (stickyTitleEl, newTopmostPost, topOffset = 0) => {

fe/src/utils/post/queryForm/index.ts

@@ -113,7 +113,7 @@ export const getQueryFormDeps = () => {
 
         // check params required post types, index query doesn't restrict on post types
         invalidParamsIndex.value = []; // reset to prevent duplicate indexes
-        if (currentQueryType.value !== 'postID' && currentQueryType.value !== 'fid') {
+        if (!['postID', 'fid'].includes(currentQueryType.value)) {
             /** we don't {@link Array.filter()} here for post types validate */
             params.value.map(clearParamDefaultValue).forEach((param, paramIndex) => {
                 if (param?.name === undefined || param.value === undefined) {

fe/src/utils/post/renderer/list/scroll.ts

@@ -50,7 +50,7 @@ export const scrollToPostListItemByRoute = (route: RouteLocationNormalized) => {
     const el = document.querySelector(scrollPosition.el);
     if (el === null)
         return;
-    // eslint-disable-next-line compat/compat
+
     requestIdleCallback(function retry(deadline) {
         if (deadline.timeRemaining() > 0)
             scrollToPostListItem(el);