Skip to content

Commit 8c71a54

Browse files
authored
ci(release-please): skip GitHub Release creation; release.yml owns it (#9)
release-please was about to collide with release.yml on GitHub Release creation; release.yml's idempotent skip-if-exists would have left the tarball asset off. With `skip-github-release: true`, release-please owns version bump + CHANGELOG + tag, release.yml owns the GitHub Release with tarball + npm publish. ## Test plan - [x] YAML valid - [ ] After merge: release-please re-runs (push to main triggers it), updates PR #8 (no version-content change since v1.2.1 is still the calculated bump) - [ ] Merging PR #8 creates v1.2.1 tag (release-please) WITHOUT a GitHub Release - [ ] release.yml fires from tag push, creates GitHub Release v1.2.1 with the tarball asset, then OIDC-publishes to npm
1 parent 1d6d91c commit 8c71a54

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

.github/workflows/release-please.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,3 +31,9 @@ jobs:
3131
token: ${{ secrets.GITHUB_TOKEN }}
3232
config-file: release-please-config.json
3333
manifest-file: .release-please-manifest.json
34+
# release-please owns: version bumps, CHANGELOG entries, the v<X.Y.Z>
35+
# tag created on PR merge. release.yml owns: building + smoke-testing
36+
# the tarball, creating the GitHub Release WITH that tarball as an
37+
# asset, and OIDC-publishing to npm. Skipping the bot's own GitHub
38+
# Release here prevents the two from colliding.
39+
skip-github-release: true

0 commit comments

Comments
 (0)