Use encoded style ids for AutoRep representations - #297
Open
cpignedoli wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
PR-S1 for surfaces AutoRep support, stacked on the existing split surfaces chain.
This PR adds AutoRep support for the encoded viewer representation IDs introduced in aiidalab-widgets-base PR-R1 (#768) and keeps imported/stored viewer representation arrays intact when structures change.
AutoRep remains surfaces-only because it uses lowdimfinder/surfaces domain logic. The widget writes molecule atoms as ball+stick and non-molecule atoms as spacefill using the same encoded representation naming convention as widgets-base.
Dependencies
Implemented with Codex.
Validation