Skip to content

fix(deezer): silence connection pool warnings by sizing the requests adapter correctly #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
berettavexee wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

fix(deezer): silence connection pool warnings by sizing the requests adapter correctly #997

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdb5831
fix(deezer): size requests connection pool to match max_connections
Jun 14, 2026
dd19bc3
fix(deezer): set pool_maxsize well above max_connections to prevent o…
Jun 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions streamrip/client/deezer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import logging

import deezer
import requests
from Cryptodome.Cipher import AES

from ..config import Config
Expand Down Expand Up @@ -40,6 +41,21 @@ def __init__(self, config: Config):
self.logged_in = False
self.config = config.session.deezer

# Increase the deezer-py requests session pool well above max_connections.
# Each concurrent download spawns several API calls (metadata, track token,
# GW info…) via asyncio.to_thread(), so the actual number of simultaneous
# requests easily exceeds max_connections. pool_maxsize is just a ceiling —
# no memory is pre-allocated — so a generous value avoids the urllib3
# "Connection pool is full" warning without any real cost.
max_conn = config.session.downloads.max_connections
adapter = requests.adapters.HTTPAdapter(
pool_connections=max_conn,
pool_maxsize=max(max_conn * 4, 32),
max_retries=0,
)
self.client.session.mount("https://", adapter)
self.client.session.mount("http://", adapter)

async def login(self):
# Used for track downloads
self.session = await self.get_session(
Expand Down