Merge pull request #122 from Siergiej29/feature/mapbox-marker-image-source

feat: Add imageSource support for marker rendering

Author: farfromrefug

src/ui-mapbox/common.ts

@@ -147,6 +147,11 @@ export interface MapboxMarker extends LatLng {
      * Example: "~/assets/markers/green_pin_marker.png"
      */
     iconPath?: string;
+    /**
+     * Runtime-generated image used directly as a marker icon.
+     * Useful when the app composes an icon in memory instead of loading it from a resource, file path, or URL.
+     */
+    imageSource?: ImageSource;
     /**
      * A callback function to invoke when the marker is tapped.
      */

src/ui-mapbox/index.android.ts

@@ -1376,11 +1376,13 @@ export class Mapbox extends MapboxCommon implements MapboxApi {
                         console.warn(`No icon found for this device density for icon ' ${marker.icon}'. Falling back to the default icon.`);
                     }
                 } else if (marker.icon.startsWith('http')) {
-                    if (marker.downloadedIcon !== null) {
+                    if (marker.downloadedIcon) {
                         icon = marker.downloadedIcon;
 
                         // markerOptions.setIcon(iconFactory.fromBitmap(marker.iconDownloaded));
                     }
+                } else if (marker.imageSource) {
+                    icon = marker.imageSource;
                 } else {
                     if (Trace.isEnabled()) {
                         CLog(CLogTypes.info, 'Please use res://resourcename, http(s)://imageurl or iconPath to use a local path');
@@ -3566,14 +3568,17 @@ export class Mapbox extends MapboxCommon implements MapboxApi {
             return marker;
         } catch (error) {
             console.error(error);
+            return marker;
         }
     }
 
     async _downloadMarkerImages(markers: MapboxMarker[]) {
         const result: MapboxMarker[] = [];
         for (let i = 0; i < markers.length; i++) {
             const marker = markers[i];
-            if (marker.icon && marker.icon.startsWith('http')) {
+            if (marker.imageSource || marker.downloadedIcon) {
+                result.push(marker);
+            } else if (marker.icon && marker.icon.startsWith('http')) {
                 const mark = await this._downloadImage(marker);
                 result.push(mark);
             } else {

src/ui-mapbox/index.ios.ts

@@ -626,7 +626,11 @@ export class Mapbox extends MapboxCommon implements MapboxApi {
 
                 const updated = await Promise.all(
                     markers.map(async (m) => {
-                        if (m.icon && typeof m.icon === 'string' && m.icon.startsWith('http')) {
+                        if (m.imageSource) {
+                            (m as any).iconDownloaded = m.imageSource.ios;
+                        } else if (m.downloadedIcon) {
+                            (m as any).iconDownloaded = m.downloadedIcon.ios;
+                        } else if (m.icon && typeof m.icon === 'string' && m.icon.startsWith('http')) {
                             (m as any).iconDownloaded = await fetchImageIOS(m.icon);
                         }
                         return m;