Skip to content

Commit a833dbc

Browse files
serrrfiratclaude
andcommitted
ci(test): stop the v1 monolith re-running reborn composition/memory/secrets
The legacy `tests` job re-ran three things already covered by reborn-side CI: - `cargo test -p ironclaw_reborn_composition --features libsql,postgres` - `cargo test -p ironclaw_memory` - the `secret-store-contract-tests` job (`-p ironclaw_secrets --test secret_store_contract`) All three run per-crate in reborn-tests.yml (libsql) and in coverage.yml (`cargo llvm-cov --all-features --workspace` with a Postgres service), so the v1 monolith was duplicating them on every legacy run. Remove the two in-job steps and the standalone secret-store job (it was not gated by the run-tests aggregator). Pure waste removal — no coverage lost: libsql via the closure, postgres via coverage.yml + the hooks-parity Postgres job. Scope note: this does NOT touch the 31 reborn_*.rs root tests the v1 `cargo test` also re-runs. Excluding those cleanly needs binary-level exclusion (the obvious `--skip reborn_` is unsafe — the v1 suite has its own reborn_*-named tests in dockerfile_runtime_home.rs / workspace), so that is deferred to the v1 build-smoke restructure. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 parent e849e83 commit a833dbc

1 file changed

Lines changed: 6 additions & 42 deletions

File tree

.github/workflows/test.yml

Lines changed: 6 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -199,48 +199,12 @@ jobs:
199199
run: |
200200
timeout --signal=INT --kill-after=30s 40m \
201201
cargo test ${{ matrix.flags }} -- --nocapture
202-
# The root cargo test invocation above runs only the `ironclaw`
203-
# package's tests. Reborn memory regression coverage lives in
204-
# `crates/ironclaw_memory/tests/*` and must be explicitly invoked
205-
# with `-p ironclaw_memory` (or `--workspace`) — otherwise the
206-
# Tier A guards for PR #3180 invariants compile but never run.
207-
- name: Run reborn composition substrate tests
208-
run: |
209-
timeout --signal=INT --kill-after=30s 15m \
210-
cargo test -p ironclaw_reborn_composition --no-default-features --features libsql,postgres --tests -- --nocapture
211-
212-
- name: Run ironclaw_memory tests
213-
run: |
214-
timeout --signal=INT --kill-after=30s 15m \
215-
cargo test -p ironclaw_memory --tests -- --nocapture
216-
217-
secret-store-contract-tests:
218-
name: Secret Store Contract Tests
219-
needs: changes
220-
if: needs.changes.outputs.docs_only != 'true' && needs.changes.outputs.has_legacy_tests == 'true' && needs.changes.outputs.has_core_code == 'true'
221-
runs-on: ubuntu-latest
222-
timeout-minutes: 15
223-
env:
224-
CARGO_PROFILE_DEV_DEBUG: 0
225-
CARGO_PROFILE_TEST_DEBUG: 0
226-
steps:
227-
- name: Checkout repository
228-
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
229-
with:
230-
ref: ${{ inputs.ref || github.sha }}
231-
persist-credentials: false
232-
- name: Install Rust
233-
uses: dtolnay/rust-toolchain@29eef336d9b2848a0b548edc03f92a220660cdb8 # stable
234-
- uses: Swatinem/rust-cache@e18b497796c12c097a38f9edb9d0641fb99eee32 # v2
235-
with:
236-
key: secret-store-contract
237-
# Keep saves to protected-branch and merge_group runs so the ~10 GB
238-
# repo cache LRU is seeded by shared states, not arbitrary PR branches.
239-
save-if: ${{ (github.event_name == 'push' && github.ref == 'refs/heads/main') || github.event_name == 'merge_group' }}
240-
- name: Run secret store contract
241-
run: |
242-
timeout --signal=INT --kill-after=30s 10m \
243-
cargo test -p ironclaw_secrets --test secret_store_contract -- --nocapture
202+
# Note: ironclaw_reborn_composition, ironclaw_memory, and the
203+
# ironclaw_secrets secret_store_contract are no longer re-run here.
204+
# They are covered per-crate by reborn-tests.yml (libsql) and by
205+
# coverage.yml (`cargo llvm-cov --all-features --workspace` with a
206+
# Postgres service), so running them in the v1 monolith was pure
207+
# duplication.
244208

245209
heavy-integration-tests:
246210
name: Heavy Integration Tests

0 commit comments

Comments
 (0)