Small fixes

Author: madchicken

lib/src/graph.rs

@@ -431,8 +431,8 @@ impl Graph {
     }
 
     #[cfg(feature = "unstable-bolt-protocol-impl-v2")]
-    pub fn with_session(&self, config: Option<SessionConfig>) -> Session<'_> {
-        Session::new(config.unwrap_or_default(), self)
+    pub fn with_session(&self, config: Option<SessionConfig>) -> Session {
+        Session::new(config.unwrap_or_default(), Arc::new(self.clone()))
     }
 
     #[cfg(feature = "unstable-bolt-protocol-impl-v2")]

lib/src/session.rs

@@ -3,6 +3,7 @@ use crate::summary::Counters;
 use crate::{Database, DetachedRowStream, Error, Graph, Operation, Query, RowStream, RunResult};
 use std::sync::atomic::AtomicBool;
 use std::sync::atomic::Ordering::Relaxed;
+use std::sync::Arc;
 
 #[derive(Default)]
 pub struct SessionConfig {
@@ -57,17 +58,19 @@ impl SessionConfigBuilder {
     }
 }
 
-pub struct Session<'a> {
+/// A session is a context for running queries and transactions against a Neo4j database.
+/// It maintains state such as the target database, impersonated user, fetch size, and bookmarks.
+pub struct Session {
     db: Option<Database>,
     imp_user: Option<ImpersonateUser>,
     fetch_size: Option<usize>,
     bookmarks: Vec<String>,
     should_fetch_default_db: AtomicBool,
-    driver: &'a Graph,
+    driver: Arc<Graph>,
 }
 
-impl<'a> Session<'a> {
-    pub(crate) fn new(config: SessionConfig, graph: &'a Graph) -> Session<'a> {
+impl Session {
+    pub(crate) fn new(config: SessionConfig, graph: Arc<Graph>) -> Session {
         Self {
             db: config.db,
             imp_user: config.imp_user,

lib/src/txn.rs

@@ -23,7 +23,7 @@ pub struct Txn {
     connection: ManagedConnection,
     operation: Operation,
     imp_user: Option<ImpersonateUser>,
-    #[allow(dead_code)]
+    #[cfg(feature = "unstable-bolt-protocol-impl-v2")]
     bookmark: Option<String>,
 }
 
@@ -43,7 +43,6 @@ impl Txn {
                 fetch_size,
                 connection,
                 operation,
-                bookmark: None,
                 imp_user,
             }),
             msg => Err(msg.into_error("BEGIN")),