Fix apoc.search.multiSearchReduced UnsupportedOperationException (#936)

Author: gem-neo4j

core/src/main/java/apoc/search/ParallelNodeSearch.java

@@ -309,9 +309,9 @@ public static class NodeReducedResult {
         public final Map<String, Object> values;
 
         public NodeReducedResult(long id, List<String> labels, Map<String, Object> val) {
-            this.labels = labels;
             this.id = id;
-            this.values = val;
+            this.labels = new ArrayList<>(labels);
+            this.values = new HashMap<>(val);
         }
     }
 }

core/src/test/java/apoc/search/ParallelNodeSearchTest.java

@@ -23,6 +23,7 @@
 import apoc.util.TestUtil;
 import apoc.util.Util;
 import com.neo4j.test.extension.EnterpriseDbmsExtension;
+import java.util.Map;
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
 import org.neo4j.graphdb.GraphDatabaseService;
@@ -121,4 +122,59 @@ void testMultiSearchNodeNumberExactComparison() {
                 "call apoc.search.nodeAllReduced({Person: 'born', Movie: ['released']},'exact',2000) yield labels as n return count(n) as c";
         TestUtil.testCall(db, query, (row) -> assertEquals(3L, row.get("c")));
     }
+
+    @Test
+    void testMultiSearchReduced() {
+        String query =
+                "CALL apoc.search.multiSearchReduced('{Person: \"name\",Movie: [\"title\",\"tagline\"]}','CONTAINS','her') YIELD id RETURN count(id) AS c";
+        TestUtil.testCall(db, query, (row) -> assertEquals(6L, row.get("c")));
+        query =
+                "CALL apoc.search.multiSearchReduced('{Person: \"name\",Movie: [\"title\",\"tagline\"]}','STARTS WITH','Tom') YIELD values RETURN count(values) AS c";
+        TestUtil.testCall(db, query, (row) -> assertEquals(4L, row.get("c")));
+        query =
+                "CALL apoc.search.multiSearchReduced('{Person: \"name\",Movie: [\"title\",\"tagline\"]}','ENDS WITH','s') YIELD labels RETURN count(labels) AS c";
+        TestUtil.testCall(db, query, (row) -> assertEquals(29L, row.get("c")));
+    }
+
+    @Test
+    void testMultiSearchReducedMergesMultiplePropertyMatches() {
+        db.executeTransactionally("CREATE (:SearchTest {alpha: 'hello world', beta: 'hello there'})");
+        try {
+            TestUtil.testCall(
+                    db,
+                    "CALL apoc.search.multiSearchReduced({SearchTest: ['alpha', 'beta']}, 'contains', 'hello')"
+                            + " YIELD labels, values RETURN labels, values",
+                    row -> {
+                        assertEquals(java.util.List.of("SearchTest"), row.get("labels"));
+                        @SuppressWarnings("unchecked")
+                        Map<String, Object> values = (Map<String, Object>) row.get("values");
+                        assertEquals(2, values.size());
+                        assertEquals("hello world", values.get("alpha"));
+                        assertEquals("hello there", values.get("beta"));
+                    });
+        } finally {
+            db.executeTransactionally("MATCH (n:SearchTest) DELETE n");
+        }
+    }
+
+    @Test
+    void testNodeReducedMergesMultiplePropertyMatches() {
+        db.executeTransactionally("CREATE (:SearchTest {alpha: 'hello world', beta: 'hello there'})");
+        try {
+            TestUtil.testCall(
+                    db,
+                    "CALL apoc.search.nodeReduced({SearchTest: ['alpha', 'beta']}, 'contains', 'hello')"
+                            + " YIELD labels, values RETURN labels, values",
+                    row -> {
+                        assertEquals(java.util.List.of("SearchTest"), row.get("labels"));
+                        @SuppressWarnings("unchecked")
+                        Map<String, Object> values = (Map<String, Object>) row.get("values");
+                        assertEquals(2, values.size());
+                        assertEquals("hello world", values.get("alpha"));
+                        assertEquals("hello there", values.get("beta"));
+                    });
+        } finally {
+            db.executeTransactionally("MATCH (n:SearchTest) DELETE n");
+        }
+    }
 }